Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

  1. 06 Jun, 2018 1 commit
    • Boudewijn Rempt's avatar
      Remove obsolete KoGlobal singleton · 528b0481
      Boudewijn Rempt authored
      This was only used to access kritarc in an obsolete way and to
      build a list of languages that was used in two places: the old
      text tool and the document info dialog. However, it has been
      broken and returned an empty list for many years now.
      528b0481
  2. 05 Jun, 2018 1 commit
  3. 01 Jun, 2018 1 commit
  4. 31 May, 2018 1 commit
  5. 30 May, 2018 4 commits
  6. 29 May, 2018 1 commit
    • Pino Toscano's avatar
      Fix loading of the Python library · 1553c126
      Pino Toscano authored
      Summary:
      Instead of assuming the unversioned .so symlink will exist also at
      runtime (which is not the case for binary distros), use the QLibrary
      features: the SONAME of the Python library is "1.0", so use the
      unsuffixed filename of Python library with it.
      
      Additionally, this extends the loading also to Unices platforms
      different than macOS (since Boud excluded it in a previous commit),
      and destroy the QLibrary in case of loading failure.
      
      BUG: 393307
      Fixed-In: 4.0.4
      
      Reviewers: rempt
      
      Reviewed By: rempt
      
      Subscribers: rempt
      
      Differential Revision: https://phabricator.kde.org/D13144
      1553c126
  7. 22 May, 2018 1 commit
  8. 21 May, 2018 1 commit
  9. 16 May, 2018 1 commit
  10. 08 May, 2018 1 commit
  11. 07 May, 2018 2 commits
    • Boudewijn Rempt's avatar
      Rename foreGround/backGround to foreground/background · 21e8384d
      Boudewijn Rempt authored
      This is more consistent with the rest of Krita and is more correct.
      However, the colorSource and halftone filter haven't been changed
      since those used these strings to save and load config.
      21e8384d
    • Boudewijn Rempt's avatar
      Add Document::setBackgroundColor API · 24f97f7d
      Boudewijn Rempt authored
      This can be used like this:
      
      from krita import Krita
      from PyQt5.QtGui import QColor
      
      kt = Krita.instance()
      doc = kt.activeDocument()
      
      test_color = QColor(128, 128, 128, 255)  # change as needed
      
      old_background = doc.backGroundColor()
      print("Old background: {}".format(old_background.getRgb()))
      
      doc.setBackGroundColor(test_color)
      
      new_background = doc.backGroundColor()
      print("New background {}".format(new_background.getRgb()))
      
      Patch by Jeroen Hoolmans, thanks!
      fferential Revision: https://phabricator.kde.org/D12729
      24f97f7d
  12. 04 May, 2018 1 commit
  13. 04 Apr, 2018 1 commit
  14. 27 Mar, 2018 1 commit
  15. 25 Mar, 2018 1 commit
  16. 24 Mar, 2018 1 commit
  17. 21 Mar, 2018 1 commit
  18. 17 Mar, 2018 1 commit
  19. 15 Mar, 2018 4 commits
    • Boudewijn Rempt's avatar
      Remove weird unicode characters · b4b14592
      Boudewijn Rempt authored
      b4b14592
    • Boudewijn Rempt's avatar
      Fix assert when loading the python plugin · 58b02fd1
      Boudewijn Rempt authored
      The python plugin shouldn't be a KisActionPlugin since it's loaded
      only once and is owned by the application not the view manager;
      KusActionPlugin shouldn't hard assert, since it checks carefully
      whether the viewmanager is 0 in the rest of the code, however, it's
      still wrong if it's created without a viewmanager as parent, so
      do a KIS_ASSERT_RECOVER_NOOP(m_viewManager);.
      58b02fd1
    • Boudewijn Rempt's avatar
      s/qDebug/dbgScript/g · 6c820cbf
      Boudewijn Rempt authored
      6c820cbf
    • Boudewijn Rempt's avatar
      Resources: Remove KoResourceLoaderThread · 5d361cf0
      Boudewijn Rempt authored
      All resources were loaded synchronously by now, so KoResourceLoaderThread
      was obsolete. This also moved the bundle server to it's own singleton,
      since it needs a completely instantiated singleton of KisResourceServerProvider.
      
      KisApplication now instantiates the singletons in the correct order, without
      superfluously getting the actual resource providers. Since the order is now
      properly known, we can clear the empty krita 3 system preset tags from the
      tag database after loading the last bundles. However, the tag system seems
      to be case-insensitive, but we used to have both ink and Ink; that still
      needs fixing.
      
      This fixes item 2 from
      
      CCBUG:391576
      
      Curiously enough, this also makes Krita start quite a bit faster for me...
      5d361cf0
  20. 14 Mar, 2018 6 commits
    • Boudewijn Rempt's avatar
      Remove the Action class from the libkis API · 92972401
      Boudewijn Rempt authored
      This class was a wrapper around QAction, which we can use directly.
      The wrapper was leaked in an a number of places.
      
      (cherry picked from commit 0020dcb8)
      92972401
    • Boudewijn Rempt's avatar
      Remove the Action class from the libkis API · 0020dcb8
      Boudewijn Rempt authored
      This class was a wrapper around QAction, which we can use directly.
      The wrapper was leaked in an a number of places.
      0020dcb8
    • Boudewijn Rempt's avatar
      Create actions per-window instead of per-application · e9b06616
      Boudewijn Rempt authored
      Note that this changes the libkis scripting api. The Extension
      class now has two methods: setup and createActions. Old code
      was like this:
      
      from PyQt5.QtGui import *
      from PyQt5.QtWidgets import *
      from krita import *
      
      def hello():
          QMessageBox.information(QWidget(), "Test", "Hello World")
      
      class HelloExtension(Extension):
      
        def __init__(self, parent):
            super().__init__(parent)
      
        def setup(self):
            action = Krita.createAction("Hello")
            action.triggered.connect(hello)
      
      Krita.instance().addExtension(HelloExtension(Krita.instance()))
      
      New code is like this:
      
      from PyQt5.QtGui import *
      from PyQt5.QtWidgets import *
      from krita import *
      
      def hello():
          QMessageBox.information(QWidget(), "Test", "Hello World")
      
      class HelloExtension(Extension):
      
        def __init__(self, parent):
            super().__init__(parent)
      
        def setup(self):
            pass
      
        def createActions(self, window):
            action = window.createAction("Hello")
            action.triggered.connect(hello)
      
      Krita.instance().addExtension(HelloExtension(Krita.instance()))
      
      This also adds a new parameter to createAction: the menu location. This
      is a path separated by /, for instance tools/scripts. Note that this
      path must exist, otherwise a crash will happen. The paths are defined in
      krita4.xmlgui...
      
      BUG:391705
      
      Note: we're still leaking Action objects created in Window::createAction;
      that's the next fix.
      
      CCMAIL:kimageshop@kde.org
      e9b06616
    • Boudewijn Rempt's avatar
      Fix loading the action plugins in new windows · ab523d80
      Boudewijn Rempt authored
      We were caching the loaded plugins, so a new window would not load
      the per-window action plugins, which made for empty menus.
      
      However, the Python plugin was a KisActionPlugin but should only
      be loaded once, on application start, when the first window is
      being created. It should not be reloaded when a new window is
      created.
      ab523d80
    • Boudewijn Rempt's avatar
      Hide the viewManager member from subclasses and use getter instead · f895420e
      Boudewijn Rempt authored
      This also renames every place where "view" was used for "viewManager".
      f895420e
    • Boudewijn Rempt's avatar
      Rename KisViewPlugin to KisActionPlugin · e443dc64
      Boudewijn Rempt authored
      These plugins are not created per-view, but per-mainwindow, and exist
      so every main window can have its own actions, so this makes the naming
      more clear.
      
      CCBUG:391705
      e443dc64
  21. 13 Mar, 2018 1 commit
    • Boudewijn Rempt's avatar
      Set the maximum values for width and height to 100000000.000000 · 581d1379
      Boudewijn Rempt authored
      This is the same value as in the new image dialog, which makes
      sense. This partially reverts
      
      commit 40c93621
      Author: Juan Palacios <jpalaciosdev@gmail.com>
      Date:   Sun Nov 24 20:22:24 2013 +0100
      
          Tweak value range of size dialog's spinboxes.
      
          Incremented number of decimals for QDoubleSpinbox and set a more sane
          range for allowed values in all spinboxes of canvas size, image size
          and layer size dialogs.
      
      BUG:391763
      581d1379
  22. 12 Mar, 2018 2 commits
  23. 10 Mar, 2018 1 commit
  24. 09 Mar, 2018 1 commit
    • Boudewijn Rempt's avatar
      Disable the 3.0 defaults bundle by default · 720abdf6
      Boudewijn Rempt authored
      This is an ugly hack, but since we cannot whitelist by-default-blacklisted
      default resources, since there's no concept of whitelisting, hacking around
      with the config file is the best we can do.
      
      BUG:391508
      720abdf6
  25. 07 Mar, 2018 2 commits
  26. 28 Feb, 2018 1 commit