GitLab

BUG:370193 Save a copy of the image not the original

This restores the delayed saving dialog, which is now even weirder,
with a cancel running operating button which mostly doesn't work,
a do not save button, and a don't care, save a broken copy button.

See also

https://phabricator.kde.org/D3258
https://phabricator.kde.org/T4220
https://bugs.kde.org/show_bug.cgi?id=370566
https://bugs.kde.org/show_bug.cgi?id=369368
https://bugs.kde.org/show_bug.cgi?id=370193

This is a simple search and replace for KisLayer which is a QObject.
qobject_cast doesn't require RTTI and is faster.

BUG:372171

BUG:372171

# Conflicts:
#	libs/ui/tests/CMakeLists.txt

That ancient KisImageWSP find-replace refactoring was really
not right.

BUG:372247

Now it catches report 372171

CCBUG:372171

We shouldn't call any node's method that accesses parent() or
next/prevSibling() in ctor and dtor. It is just unsafe.

BUG:372184

# Conflicts:
#	libs/ui/flake/kis_shape_layer.cc

A Krita document is never really empty, this code was only useful
for office document, and the flag only "used" in KoDocumentInfo.

Neither of the two private variables was used or initiated, thus the
delete was always going to be a segfault.

BUG: 371788

Before the calligra product removal, this was protected by an ifdef
which would never be true.

Summary:
This made sense for the office suite, currently it's just added
complexity without benefit.

After this change, all parts of Krita will be built, is there a neccessity
to disable for example the vectorimage support?

Reviewers: #krita

Differential Revision: https://phabricator.kde.org/D3182

Summary:
This actually makes it less boiler plate heavy.
It also fixes a few small issues with the tests, three tests were
previously forgotten and have been re-added.

With the custom krita_add_broken_unit_test the same functionallty is
preserved that was there before in the fork of the kde4 macro.
This is a step towards reducing the amount of custom cmake code that
Krita drags around and will make the build system easier.

Thanks to the new macros, the total amount of redundant macro code is
reduced and we lose a bit over 1000 lines of useless boilerplate.

The total test count goes up by three.

The flake tests had their data in the source path, which is unlike any
other tests and were relying on some old defines. They have been adapted
to behave like any other test.

Reviewers: #krita

Subscribers: rempt

Differential Revision: https://phabricator.kde.org/D3167

This can be used to correctly configure the dialogs, which don't
have access to the document or the image. This also means the
save profile option works again in the png export dialog.

BUG:367832

http://www.drdobbs.com/keywords-that-arent-or-comments-by-anoth/184403859
Summary:
They keyword is deprecated, doesn't do anything in C++ and is
incompatible with C++1z. When should I use it? Never.

Calling data() is expensive since it detaches, creating a copy of the
data it points to.

Krita cannot load Gimp 2.9 files (and never will be, probably,
because xcf-tools isn't maintained anymore and the file format
is un(der)documented). But we shouldn't crash and burn trying
to load them anyway.

This adds two new strings for translation, I'm afraid :-(

CCMAIL:kde-i18n-doc@kde.org

There is no need to explicitly initialize QString in constructurs.
Using "" for an empty string is actually less type safe and more costly
than using QString() which returns an empty shared null string, so it's
always preferable to signify empty QStrings that way.

/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [clang-diagnostic-array-bounds]
    T alpha = pixel->data[alphaPos];
              ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<half, ExrPixel_<half, 1>, 1, -1>' requested here
            multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
            ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::encodeData' requested here
    EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:949:24: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::EncoderImpl' requested here
            return new EncoderImpl < half, 1, -1 > (&file, &info, width);
                       ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
    _T_ data[size];
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:359:9: warning: array index -1 is before the beginning of the array [clang-diagnostic-array-bounds]
        pixel->data[alphaPos] = alpha;
        ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
    _T_ data[size];
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [-Warray-bounds]
    T alpha = pixel->data[alphaPos];
              ^           ~~~~~~~~
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<half, ExrPixel_<half, 1>, 1, -1>' requested here
            multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
            ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::encodeData' requested here
    EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:949:24: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::EncoderImpl' requested here
            return new EncoderImpl < half, 1, -1 > (&file, &info, width);
                       ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
    _T_ data[size];
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [-Warray-bounds]
    T alpha = pixel->data[alphaPos];
              ^           ~~~~~~~~
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<float, ExrPixel_<float, 1>, 1, -1>' requested here
            multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
            ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<float, 1, -1>::encodeData' requested here
    EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:952:24: note: in instantiation of member function 'EncoderImpl<float, 1, -1>::EncoderImpl' requested here
            return new EncoderImpl < float, 1, -1 > (&file, &info, width);
                       ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
    _T_ data[size];
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:359:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
        pixel->data[alphaPos] = alpha;
        ^           ~~~~~~~~
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
    _T_ data[size];
    ^
3 warnings generated.

/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [clang-diagnostic-array-bounds]
    T alpha = pixel->data[alphaPos];
              ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<half, ExrPixel_<half, 1>, 1, -1>' requested here
            multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
            ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::encodeData' requested here
    EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:949:24: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::EncoderImpl' requested here
            return new EncoderImpl < half, 1, -1 > (&file, &info, width);
                       ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
    _T_ data[size];
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:359:9: warning: array index -1 is before the beginning of the array [clang-diagnostic-array-bounds]
        pixel->data[alphaPos] = alpha;
        ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
    _T_ data[size];
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [-Warray-bounds]
    T alpha = pixel->data[alphaPos];
              ^           ~~~~~~~~
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<half, ExrPixel_<half, 1>, 1, -1>' requested here
            multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
            ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::encodeData' requested here
    EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:949:24: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::EncoderImpl' requested here
            return new EncoderImpl < half, 1, -1 > (&file, &info, width);
                       ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
    _T_ data[size];
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [-Warray-bounds]
    T alpha = pixel->data[alphaPos];
              ^           ~~~~~~~~
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<float, ExrPixel_<float, 1>, 1, -1>' requested here
            multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
            ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<float, 1, -1>::encodeData' requested here
    EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:952:24: note: in instantiation of member function 'EncoderImpl<float, 1, -1>::EncoderImpl' requested here
            return new EncoderImpl < float, 1, -1 > (&file, &info, width);
                       ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
    _T_ data[size];
    ^
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:359:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
        pixel->data[alphaPos] = alpha;
        ^           ~~~~~~~~
/home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
    _T_ data[size];
    ^
3 warnings generated.

The intent was to show the invalid number.

warning: adding 'Compression::CompressionType' to a string does not
append to the string [-Wstring-plus-int]