1. 19 Nov, 2016 3 commits
  2. 10 Nov, 2016 2 commits
  3. 09 Nov, 2016 5 commits
  4. 03 Nov, 2016 1 commit
  5. 02 Nov, 2016 3 commits
  6. 01 Nov, 2016 1 commit
  7. 31 Oct, 2016 3 commits
  8. 28 Oct, 2016 4 commits
  9. 27 Oct, 2016 1 commit
    • Frederik Gladhorn's avatar
      cmake: use cmake-extra-modules for Unit Tests · 27d0b63e
      Frederik Gladhorn authored
      Summary:
      This actually makes it less boiler plate heavy.
      It also fixes a few small issues with the tests, three tests were
      previously forgotten and have been re-added.
      
      With the custom krita_add_broken_unit_test the same functionallty is
      preserved that was there before in the fork of the kde4 macro.
      This is a step towards reducing the amount of custom cmake code that
      Krita drags around and will make the build system easier.
      
      Thanks to the new macros, the total amount of redundant macro code is
      reduced and we lose a bit over 1000 lines of useless boilerplate.
      
      The total test count goes up by three.
      
      The flake tests had their data in the source path, which is unlike any
      other tests and were relying on some old defines. They have been adapted
      to behave like any other test.
      
      Reviewers: #krita
      
      Subscribers: rempt
      
      Differential Revision: https://phabricator.kde.org/D3167
      27d0b63e
  10. 25 Oct, 2016 1 commit
  11. 24 Oct, 2016 3 commits
  12. 23 Oct, 2016 5 commits
  13. 22 Oct, 2016 6 commits
    • Frederik Gladhorn's avatar
      Cleanup usage of empty strings · ad15727c
      Frederik Gladhorn authored
      There is no need to explicitly initialize QString in constructurs.
      Using "" for an empty string is actually less type safe and more costly
      than using QString() which returns an empty shared null string, so it's
      always preferable to signify empty QStrings that way.
      ad15727c
    • Halla Rempt's avatar
      Fix warning · a275a902
      Halla Rempt authored
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [clang-diagnostic-array-bounds]
          T alpha = pixel->data[alphaPos];
                    ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<half, ExrPixel_<half, 1>, 1, -1>' requested here
                  multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
                  ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::encodeData' requested here
          EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:949:24: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::EncoderImpl' requested here
                  return new EncoderImpl < half, 1, -1 > (&file, &info, width);
                             ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
          _T_ data[size];
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:359:9: warning: array index -1 is before the beginning of the array [clang-diagnostic-array-bounds]
              pixel->data[alphaPos] = alpha;
              ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
          _T_ data[size];
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [-Warray-bounds]
          T alpha = pixel->data[alphaPos];
                    ^           ~~~~~~~~
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<half, ExrPixel_<half, 1>, 1, -1>' requested here
                  multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
                  ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::encodeData' requested here
          EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:949:24: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::EncoderImpl' requested here
                  return new EncoderImpl < half, 1, -1 > (&file, &info, width);
                             ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
          _T_ data[size];
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [-Warray-bounds]
          T alpha = pixel->data[alphaPos];
                    ^           ~~~~~~~~
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<float, ExrPixel_<float, 1>, 1, -1>' requested here
                  multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
                  ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<float, 1, -1>::encodeData' requested here
          EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:952:24: note: in instantiation of member function 'EncoderImpl<float, 1, -1>::EncoderImpl' requested here
                  return new EncoderImpl < float, 1, -1 > (&file, &info, width);
                             ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
          _T_ data[size];
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:359:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
              pixel->data[alphaPos] = alpha;
              ^           ~~~~~~~~
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
          _T_ data[size];
          ^
      3 warnings generated.
      a275a902
    • Halla Rempt's avatar
      Fix warning · 1c7eabc8
      Halla Rempt authored
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [clang-diagnostic-array-bounds]
          T alpha = pixel->data[alphaPos];
                    ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<half, ExrPixel_<half, 1>, 1, -1>' requested here
                  multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
                  ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::encodeData' requested here
          EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:949:24: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::EncoderImpl' requested here
                  return new EncoderImpl < half, 1, -1 > (&file, &info, width);
                             ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
          _T_ data[size];
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:359:9: warning: array index -1 is before the beginning of the array [clang-diagnostic-array-bounds]
              pixel->data[alphaPos] = alpha;
              ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
          _T_ data[size];
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [-Warray-bounds]
          T alpha = pixel->data[alphaPos];
                    ^           ~~~~~~~~
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<half, ExrPixel_<half, 1>, 1, -1>' requested here
                  multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
                  ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::encodeData' requested here
          EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:949:24: note: in instantiation of member function 'EncoderImpl<half, 1, -1>::EncoderImpl' requested here
                  return new EncoderImpl < half, 1, -1 > (&file, &info, width);
                             ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
          _T_ data[size];
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:350:15: warning: array index -1 is before the beginning of the array [-Warray-bounds]
          T alpha = pixel->data[alphaPos];
                    ^           ~~~~~~~~
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:935:13: note: in instantiation of function template specialization 'multiplyAlpha<float, ExrPixel_<float, 1>, 1, -1>' requested here
                  multiplyAlpha<_T_, ExrPixel, size, alphaPos>(rgba);
                  ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:896:5: note: in instantiation of member function 'EncoderImpl<float, 1, -1>::encodeData' requested here
          EncoderImpl(Imf::OutputFile* _file, const ExrPaintLayerSaveInfo* _info, int width) : file(_file), info(_info), pixels(width), m_width(width) {}
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:952:24: note: in instantiation of member function 'EncoderImpl<float, 1, -1>::EncoderImpl' requested here
                  return new EncoderImpl < float, 1, -1 > (&file, &info, width);
                             ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
          _T_ data[size];
          ^
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:359:9: warning: array index -1 is before the beginning of the array [-Warray-bounds]
              pixel->data[alphaPos] = alpha;
              ^           ~~~~~~~~
      /home/frederik/dev/kde/krita/plugins/impex/exr/exr_converter.cc:880:5: note: array 'data' declared here
          _T_ data[size];
          ^
      3 warnings generated.
      1c7eabc8
    • Frederik Gladhorn's avatar
      Remove unused variables · 0f66e2d4
      Frederik Gladhorn authored
      0f66e2d4
    • Frederik Gladhorn's avatar
      09043163
    • Halla Rempt's avatar
      186046f8
  14. 19 Oct, 2016 2 commits