GitLab

run through levels are a kind of super-z-index used in textdocuments

 #include <QDialog> instead of #include <qdialog.h>

This is already a tiny part of preparation for Qt5, where QtGui is split
into QtGui and QtWidgets. If we use explicit module names in our includes,
we are liable to churn like this.

Since KDE applications always have all Qt modules in the include path
anyway, direct includes always work (both in Qt4 and Qt5), and since we
already used direct includes in thousands of places, this change makes
our code more consistent, too.

REVIEW: 10348

That way headers and footers and their anchored shapes always end up behind main text

BUG:286589

If we clear the KoImageDataPrivate object, we should also clear away
the pixmap we cache of the image, since that is invalid as well.

called, and when later focusChanged is called because the new window becomes
active then it doesn't call postSwitchTool either because it thinks the canvas
is already active.

BUG:284196

BUG:292018

BUG:288341

This fixes bug 291751 -  Text in rotated Shape is rotated twice as much as the shape
The text is rotated with it's parent so it does not need to be rotated too.

BUG: 291751

To do so I had to reroute doubleclicking into toolproxy mousepress

However for applications there are no change, except tools can now
reimplement mouseTripleClickEvent to be notified of a triple click

4 or more clicks are interpreted as (repeated) tripleclick. That
is until the doubleclicktimeout period has elapsed since the first
click.

The behaviour is smooth and as expected. I've also change texttool
take advantage of it and actiually select the paragraph on third
click and not as before where doubliclcking alternated between
selecting word and line

This patch also fixes a bug where doublclickig a word selects the
space after (it's a matter of taste and windows always selects the
space. but it seems most people like to only select the word.
BUG: 291124

When deleting the shape that is part of a KoTextAnchor we also need to delete the
KoTextAnchor from the document, so that it works correctly. This adds a new method
to KoShapeBasedDocumentBase that makes it possible to attach commands that needs to
be done after a shape has been deleted.

This changes the xml loading to no longer strip whitespace. This fixes one of the
problems attached to the bug report where there is a text node with only a space
e.g. <text:line-break/> <text:s/>2 space.
This change uncovered some problems where white space was not handled properly:
anchors and line-breaks in filters, frame element loading in libs.
It also fixes saving of line-break to use the correct tag instead of the QChar::LineSperator as char.
Also whitespace handling after tabs, bookmark-ref and when variables are used have been fixed.

REVIEW: 103568

BUG: 290091

When adding a defered tool make sure the registry is loaded. Otherwise the tools
will not loaded as tools is no longer empty. This happens when a TableShape is created
during shape loading.

There are no users of this flag anymore now that we don't change tool
on input device change.

If you had set a custom shortcut for an action owned by a tool, it would
get reset to the default value on switching to another tool and back.

This is because we explicitly set the shortcut to the default one; so
let's not do that.

Note: this patch also chances several instances of QAction to KAction.
It's dangerous to use the base QAction class when dealing with a KAction
because the setShortCut method is _not_ virtual.

See: http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKAction.html#_details

288697 - Unavail shape generates invalid xml on saving

The problem was that a unknown namespace is used in the document. This resulted
in a :tag="value" which is invalid odf.
In case such a namespace is detected a new shortcut for the namespace is used and
the namespace is added as attribute to the tag.

Qt always uses the boring Windows95 style by default, but we want to use
the XP and Vista style when applicable, so hard-code that in KoApplication
for all Calligra apps to use and enjoy.

 Previously the option widgets would be spread out over the modebox or
 tool options docker.
 Before we couldn't just fix the height because then the tool option docker
 tabbed with other dockers would limit the other tabs height.

Solution is adding a QWidget named SpecialSpacer that basically acts as any
other spacer but we can now detect if it is present and act accordingly.

As an option widget designer you should add such a SpecialSpacer at the bottom
of your optionwidget. Unless the widget itself can make use of expanding height
in which case you shouldn't add the SpecialSpacer.

This fixes bug 288138 - Unavail shape creates invalid xml on saving

BUG: 288138