1. 14 Jan, 2012 7 commits
  2. 13 Jan, 2012 1 commit
  3. 12 Jan, 2012 1 commit
  4. 11 Jan, 2012 1 commit
  5. 09 Jan, 2012 2 commits
  6. 08 Jan, 2012 5 commits
  7. 07 Jan, 2012 2 commits
  8. 06 Jan, 2012 4 commits
  9. 05 Jan, 2012 6 commits
  10. 04 Jan, 2012 3 commits
  11. 03 Jan, 2012 3 commits
  12. 02 Jan, 2012 5 commits
    • Sven Langkamp's avatar
      don't do anything if there is no current node · 8f089713
      Sven Langkamp authored
      BUG:290402
      8f089713
    • Dmitry Kazakov's avatar
      Removed blocking signals from the KisImageSignalRouter · ef487ff7
      Dmitry Kazakov authored
      Currently, there is a quite annoying limitation: we cannot add/remove/move
      layers from the context of the scheduler's thread. We can do it only from
      the UI thread. It means that the actions, which work with nodes' position
      should work using legacy undo adapter.
      
      Here is an explanation of the problem
      (from KisImageSignalRouter::emitAboutToAddANode):
      
      Some of the users of our signals rely on the fact that the
      signals are emitted synchronously from the same thread. Such
      users are KisNodeModel, KisShapeController. They request the
      data of the signal right from the node data, so these signals cannot
      be emitted asynchronously. We cannot use BlockingQueued
      connections here, because the we'll get a deadlock when UI
      will decide to wait for scheduler to finish it's job.
      That is why we explicitly check that no nodes are added,
      removed or moved from the context of the scheduler thread.
      Currently we have no other way than to assert in such a case.
      So all the node modifications should be done using legacy
      undo adapter, in the context of the UI thread.
      ef487ff7
    • Dmitry Kazakov's avatar
      Fix compilation · 047e3889
      Dmitry Kazakov authored
      047e3889
    • Boudewijn Rempt's avatar
      232cb5b1
    • Boudewijn Rempt's avatar
      assignImageProfile should not create commands · 16f6b255
      Boudewijn Rempt authored
      As the apidox already made clear (but it's even clearer now) this method
      is for setting the profile on an image during creation or loading. At
      that time, undo commands are not needed and can be dangerous because
      they lead to a projection update.
      16f6b255