1. 08 Jul, 2010 1 commit
  2. 04 Jul, 2010 1 commit
  3. 25 Jun, 2010 1 commit
  4. 16 Jun, 2010 1 commit
  5. 22 May, 2010 1 commit
    • Thomas Zander's avatar
      Make inheriting transformation an explicit property. · cbc15f9a
      Thomas Zander authored
      When the KoShapeContainer was introduced it had a 'clipped'
      property which implied two things;
       * the shape is clipped to the outline of its parent container.
       * the shape inherits the transformation of its parent container.
      
      When I used a container, now 4 years later, I was confused why my
      shape didn't inherit the transformation and only by reading the code
      did I figure out thats because I designed it that way...
      Now it doesn't make sense to me anymore that one implies the other,
      the connection between them is a bit thin.
      So, split up the two properties and provide plenty of API docs on the
      matter.
      
      Incidentally, this helps a usecase where I need the inherit concept
      but not the clipping concept ;)
      
      svn path=/trunk/koffice/; revision=1129452
      cbc15f9a
  6. 16 May, 2010 2 commits
    • Thomas Zander's avatar
      Rename setScale() to scale() · d9b62d53
      Thomas Zander authored
      Its not a setter, scale is an additive operation and there is no getter for it.
      
      svn path=/trunk/koffice/; revision=1127436
      d9b62d53
    • Thomas Zander's avatar
      Rename setShear() to shear() · 4df41f1e
      Thomas Zander authored
      Its not a setter, shear is an additive operation and there is no getter for it.
      
      svn path=/trunk/koffice/; revision=1127435
      4df41f1e
  7. 09 May, 2010 1 commit
  8. 07 May, 2010 1 commit
    • Thomas Zander's avatar
      API review of KoShapeContainer · 7114c121
      Thomas Zander authored
      Make the methods much more consistent both with each other
      and with other classes which follow a Qt-ish api.
      childClipped() -> isClipped()
      setClipping() -> setClipped()
      
      etc.
      
      svn path=/trunk/koffice/; revision=1124024
      7114c121
  9. 05 May, 2010 1 commit
    • Thorsten Zachmann's avatar
      o Fix Bug 236395 - attribute style:protect saved but not loaded · 51c87e17
      Thorsten Zachmann authored
        load attribute style:protect
        save attribute directly to style without going over additional
        attriutes which has the problem that it needs to be removed again
        after saving as otherwise it will be saved again the next time even if
        the flag is no longer set.
      
      @koffice-devel: please review so I can backport to 2.2
      
      CCBUG: 236395
      CCMAIL: koffice-devel@kde.org
      
      
      svn path=/trunk/koffice/; revision=1122951
      51c87e17
  10. 04 May, 2010 1 commit
  11. 23 Apr, 2010 2 commits
    • Thomas Zander's avatar
      Save the clipping of a shape. · dea94e14
      Thomas Zander authored
      This is a bit tricky to verify since OOo is, ehm, odd...
      First it only actually recognizes the clip option if the parent style
      is "Graphics". Thats a literal name, it doesn't matter if the style is
      defined or not.
      In OOo the unit system used for the clip is not in document units, not
      sure what it expects.
      
      svn path=/trunk/koffice/; revision=1118034
      dea94e14
    • Thomas Zander's avatar
      Cleanup the signature a bit for a variable we never used · da5482d4
      Thomas Zander authored
      Also move a methods to the private
      
      svn path=/trunk/koffice/; revision=1118032
      da5482d4
  12. 17 Apr, 2010 2 commits
  13. 30 Mar, 2010 2 commits
    • Boudewijn Rempt's avatar
      Merged revisions 1108961,1108972,1108989 via svnmerge from · acf9adc6
      Boudewijn Rempt authored
      https://rempt@svn.kde.org/home/kde/trunk/koffice
      
      ........
        r1108961 | lassin | 2010-03-30 10:08:15 +0200 (Tue, 30 Mar 2010) | 3 lines
        
        Fixes small caps for 2007 DrawingML
      ........
        r1108972 | vandenoever | 2010-03-30 10:31:49 +0200 (Tue, 30 Mar 2010) | 1 line
        
        Fix crash caused by dereferencing a zero pointer.
      ........
        r1108989 | staniek | 2010-03-30 11:26:10 +0200 (Tue, 30 Mar 2010) | 33 lines
        
        KoGenStyle(s) cleanup
        
        * KoGenStyle::Type cleanup:
        - renamed StyleUser to StyleParagraph
        - renamed StyleAuto to StyleParagraphAuto
        - move the 'Auto' to the end for the table style families
        * KoGenStyles::Flags made QFlags                         
        * KoGenStyles::lookup() -> KoGenStyles::insert()
        * move KoGenStyle::isEmpty() code to .cpp
        * use constFind(), constBegin(), constEnd() for iterators if possible
        * made some methods const
        * introduced KoGenStyles::StylesPlacement for saving odf and inserting raw styles.
        * insertRawStyles() replaces 4 methods. saveOdfStyles() replaces 4 other methods.
        * KoGenStyle::N_NumTypes -> KoGenStyle::N_NumPropertyTypes
        * added KoGenStyle::N_NumTypes
        * KoGenStyles: StyleArray -> QList<KoGenStyles::NamedStyle>
        * KoGenStyles: NameMap typedef removed, using just QSet<QString> is clear
        * To minimize size of the patch, I am noting down remaining possible TODOs:
        * Implemented qDebug() for KoGenStyles instead of dump()
        * Added KoGenStyles::FontFaceDecls to enum KoGenStyles::StylesPlacement, so
        - removed void KoGenStyles::saveOdfFontFaceDecls(KoXmlWriter* xmlWriter) const; for the same result use KoGenStyles::saveOdfStyles(FontFaceDecls, xmlWriter)
        - it's possible to add font faces using raw XML in insertRawOdfStyles()
        - moved private methods to the Private class
        * Added other proposed improvements
        * Use Style and AutoStyle suffixes for Type enum
        * Updated the whole koffice code for the KoGenStyle(s) change
        
        Revieweing, testing:
        *reviewed and approved by Jos; http://reviewboard.kde.org/r/3090/
        *builds agains trunk, checked if there's no change in semantics, relevant unit tests updated and passed
        *while global search/replace was executed to port to the new API, the change has been reviewed line-by-line too
      ........
      
      svn path=/branches/work/koffice-ko/; revision=1108994
      acf9adc6
    • Jarosław Staniek's avatar
      KoGenStyle(s) cleanup · 51f546dc
      Jarosław Staniek authored
      * KoGenStyle::Type cleanup:
      - renamed StyleUser to StyleParagraph
      - renamed StyleAuto to StyleParagraphAuto
      - move the 'Auto' to the end for the table style families
      * KoGenStyles::Flags made QFlags                         
      * KoGenStyles::lookup() -> KoGenStyles::insert()
      * move KoGenStyle::isEmpty() code to .cpp
      * use constFind(), constBegin(), constEnd() for iterators if possible
      * made some methods const
      * introduced KoGenStyles::StylesPlacement for saving odf and inserting raw styles.
      * insertRawStyles() replaces 4 methods. saveOdfStyles() replaces 4 other methods.
      * KoGenStyle::N_NumTypes -> KoGenStyle::N_NumPropertyTypes
      * added KoGenStyle::N_NumTypes
      * KoGenStyles: StyleArray -> QList<KoGenStyles::NamedStyle>
      * KoGenStyles: NameMap typedef removed, using just QSet<QString> is clear
      * To minimize size of the patch, I am noting down remaining possible TODOs:
      * Implemented qDebug() for KoGenStyles instead of dump()
      * Added KoGenStyles::FontFaceDecls to enum KoGenStyles::StylesPlacement, so
      - removed void KoGenStyles::saveOdfFontFaceDecls(KoXmlWriter* xmlWriter) const; for the same result use KoGenStyles::saveOdfStyles(FontFaceDecls, xmlWriter)
      - it's possible to add font faces using raw XML in insertRawOdfStyles()
      - moved private methods to the Private class
      * Added other proposed improvements
      * Use Style and AutoStyle suffixes for Type enum
      * Updated the whole koffice code for the KoGenStyle(s) change
      
      Revieweing, testing:
      *reviewed and approved by Jos; http://reviewboard.kde.org/r/3090/
      *builds agains trunk, checked if there's no change in semantics, relevant unit tests updated and passed
      *while global search/replace was executed to port to the new API, the change has been reviewed line-by-line too
      
      
      svn path=/trunk/koffice/; revision=1108989
      51f546dc
  14. 26 Feb, 2010 1 commit
    • Thomas Zander's avatar
      Introduce new concept; 'toolDelegates' · 444efa4a
      Thomas Zander authored
      From the API docs;
      In Flake a shape being selected will cause the tool manager to make available
      all tools that can edit the selected shapes.  In some cases selecting one
      shape should allow the tool to edit a related shape be available too.  The
      tool delegates allows this to happen by taking all the shapes in the set
      into account on tool selection.
      
      This is step one to fix headers/footers in KWord properly.
      This is inspired by the needs for things like text-on-shape and caption-shape
      
      svn path=/trunk/koffice/; revision=1096387
      444efa4a
  15. 31 Jan, 2010 2 commits
  16. 23 Jan, 2010 1 commit
    • Thomas Zander's avatar
      Remove dateCenterMap · f203dce8
      Thomas Zander authored
      The dataCenterMap is unused now as all shared resources are stored
      in the resourceManager which doesn't require to inherit from the
      dataCenter class (which most did without implementing any of its
      methods).
      Also various cleanups and stuff I missed on previous commits.
      
      svn path=/trunk/koffice/; revision=1079005
      f203dce8
  17. 14 Jan, 2010 2 commits
  18. 10 Jan, 2010 2 commits
    • Thomas Zander's avatar
      API review for KoShapeShadow · 01521265
      Thomas Zander authored
      * make 'insets' const.
      * make 'insets' not pass in a KoShape; there is no way the insets
        can change based on the shape passed in.
      * rename setVisibility -> setVisible so its a match with isVisible
      * fix bug in insets() when the shape is invisible the insets are
        set to zero, not left untouched.
      
      svn path=/trunk/koffice/; revision=1072431
      01521265
    • Thomas Zander's avatar
      Replace addUser/removeUser with ref/deref · 5d74215f
      Thomas Zander authored
      This makes sure we follow the Qt APIs and be more consistent and
      compatible.
      
      svn path=/trunk/koffice/; revision=1072430
      5d74215f
  19. 30 Dec, 2009 1 commit
  20. 26 Dec, 2009 1 commit
  21. 19 Dec, 2009 1 commit
  22. 15 Dec, 2009 1 commit
  23. 13 Dec, 2009 1 commit
    • Thomas Zander's avatar
      Remove the private methods from KoShape.h · 26e3c709
      Thomas Zander authored
      Also remove the friend there, which is a bit ugly and the removal
      showed one bug in the API; KoShape::setCollisionDetection() was
      protected while it should be public. Fixed that too.
      
      Moved the private methods to the private object.
      
      svn path=/trunk/koffice/; revision=1061930
      26e3c709
  24. 06 Dec, 2009 1 commit
  25. 12 Nov, 2009 1 commit
  26. 11 Nov, 2009 1 commit
    • Thorsten Zachmann's avatar
      o save layers of shapes that are part of a container · a50bfb99
      Thorsten Zachmann authored
      o use layer of child shapes to find out the layer of a group shape.
        This is done as the group does not allow to save its layer in odf
      
      This fixes loading and saving of grouped shapes. Before the fix the
      group was always added to the default layer. Now the group is added to
      the layer it is was in when saving.
      
      OK to backport to 2.1? I think it is a important fix as some information
      is lost during save/load of the document.
      
      CCMAIL: koffice-devel@kde.org
      
      svn path=/trunk/koffice/; revision=1047373
      a50bfb99
  27. 14 Oct, 2009 1 commit
  28. 02 Oct, 2009 1 commit
    • Thorsten Zachmann's avatar
      o Fix Bug: group order breaks in karbon · f32ddfc4
      Thorsten Zachmann authored
      This fixes the painting of shapes to appear in random order.
      
      This also changes the way the painting of the shapes is done. Now the
      shapes are painted by their hierarchy. This means it is no longer
      possible to have shapes in different layers that are drawn mixed.
      (Meaning shapes from on layer are drawn between shapes from a different
       layer.)
      Also the reorder commands have changed to make sure the created
      z-index's are allways unique in one level of the hierarchy.
      The creation of the layers are fixed to create a unique z-index.
      No command will be generated if the order has not changed, e.g. if the
      top most shape is risen.
      The feature to raise above a shape overlapping the risen one gone for
      now. Not sure if it is possible with the used algorithm.
      
      BUG: 185952
      
      svn path=/trunk/koffice/; revision=1030297
      f32ddfc4
  29. 04 Sep, 2009 1 commit
  30. 15 Aug, 2009 1 commit
  31. 07 Aug, 2009 1 commit
  32. 05 Aug, 2009 1 commit
  33. 01 Aug, 2009 1 commit