GitLab

This is a mandatory function to be able to load shapes from SVG,
because the same shape may be instantiated from different places.
We still need to discuss whether we need to really "share" the
shape template, but for now I just deep-copy them (which is the
easiest because of shape normalization problem we have).

There are the following drawbacks/hacks in this patch:

1) Not all the shapes have KoShape::cloneShape() implemented! Basically,
   it is defined only for group shape and all the descendants of a path
   shape (which are the only shapes used in SVG). Other shapes use the
   default implementation which simply returns null.

   Ideally, there should be no default implementation and all the shapes
   should define it. But, given that we are going to deprecate quite a lot
   of stuff, I'll keep them just unimplemented for now.

2) The following shape properties are not yet copied during cloning:

   * toolDelegates
   * dependees
   * shadow
   * border
   * filterEffectStack

   All the properties, except of tool delegates will probably be
   deprecated soon. And for the tool delegates we need to invent
   something ingenious to handle the pointers to recover pointers
   to the *cloned* shapes.

3) I cannot guarantee TextShape's work anymore. I just blindly
   refactored it to use QScopedPointer to QTextDocument instead of
   the previous raw pointers trickery and never tested it. Hope it
   still works...

* fixes for the wrong usage of K/QIcon vs. pixmap (from incomplete Qt3->Qt4 porting):
  Q/KIcon does not have a real size, it's more kind of a factory for whatever
  pixmap size it is asked for, so just loading a certain icon pixmap and setting that
  to a KIcon/QIcon is useless, as the widget which takes the icon might request a
  different size. So e.g. passing a SmallIcon("icon-foo") to a button which takes a
  QIcon can result in badly scaled icons instead of loading the most perfect size
  match from the icon-set.
* removes lots of unneeded includes, usually kiconloader.h
* makes the API consistent for some classes, with
 "iconName" for a QString-based icon name and
 "icon" for a KIcon/QIcon type property
* use consistently "IconSize" everywhere instead of "KIconLoader::global()->currentSize"
* removes unused "KPrFactory::iconLoader()"
* adds a simple script tools/iconcheck/iconcheck.py to find iconnames without existing icons

REVIEW: 105289

ConnectionTool is supposed to be the only way to create connections

This is the logical conclusion to the last 3 commits.

REVIEW: 104421

As written in the review request:

There are 2 reasons for this change:

 1. It increases the way the name describes what it actually is
    for. There are many places in the code that looks like:
      KoShapeBorderModel *stroke = ...
    so naming it "...Stroke..." is both closer to the odf tags and
    also to the rest of the code.
 2. It reduces the confusion between KoShapeBorderModel and KoBorder
    which don't have anything to do with each other.

REVIEW: 104405

KoResourceManager was used in two places: the canvas and document
classes. This gave rise to endless confusion about which resource
manager should be used where and contains what. The KoResourceManager
api also contained methods that were only relevant when used from
a document and others that were only relevant when used from a canvas.

This patch splits the resourcemanager into two public and one private
class. The public classes are KoDocumentResourceManager and
KoCanvasResourceManager, the private class is KoResourceManager. The
public classes defer to the private class for code-sharing purposes.

The old KoCanvasResource and KoDocumentResource enums have been taken
into the classes themselves.

BUG:236562
BUG:271360
BUG:274654
REVIEW:102315

svn path=/trunk/koffice/; revision=1193929

r1187091 | scripty | 2010-10-18 11:00:47 +0200 (Mon, 18 Oct 2010) | 1 line
Changed paths:
   M /trunk/koffice/filters/kspread/excel/export/kspread_excel_export.desktop
   M /trunk/koffice/filters/kword/dcm/kword_dcm_import.desktop
   M /trunk/koffice/filters/kword/html-odf/html-odf_export.desktop
   M /trunk/koffice/kplato/templates/Simple/Basicproject.desktop
   M /trunk/koffice/kpresenter/plugins/pageeffects/fade/kpr_pageeffect_fade.desktop
   M /trunk/koffice/kpresenter/plugins/pageeffects/spacerotation/kpr_pageeffect_spacerotation.desktop
   M /trunk/koffice/kpresenter/plugins/pageeffects/swapeffect/kpr_pageeffect_swapeffect.desktop
   M /trunk/koffice/krita/data/templates/comics/.directory
   M /trunk/koffice/krita/data/templates/comics/BD-EuroTemplate.desktop
   M /trunk/koffice/krita/data/templates/comics/Comics-USTemplate.desktop
   M /trunk/koffice/krita/data/templates/comics/Manga-JpTemplate.desktop
   M /trunk/koffice/krita/data/templates/comics/a4_waffle_grid.desktop
   M /trunk/koffice/krita/plugins/extensions/dockers/colorselectorng/krita_colorselectorng.desktop
   M /trunk/koffice/krita/plugins/filters/phongbumpmap/kritaphongbumpmapfilter.desktop
   M /trunk/koffice/krita/plugins/paintops/hatching/kritahatchingpaintop.desktop
   M /trunk/koffice/krita/plugins/paintops/sketch/kritasketchpaintop.desktop
   M /trunk/koffice/libs/koreport/koreport_itemplugin.desktop
   M /trunk/koffice/plugins/commentshape/commentshape.desktop
   M /trunk/koffice/plugins/pluginshape/pluginshape.desktop
   M /trunk/koffice/plugins/reporting/barcode/koreport_barcodeplugin.desktop
   M /trunk/koffice/plugins/reporting/chart/koreport_chartplugin.desktop
   M /trunk/koffice/plugins/reporting/shape/koreport_shapeplugin.desktop
   M /trunk/koffice/plugins/treeshape/treeshape.desktop
   M /trunk/koffice/tools/f-office/freoffice.desktop
   M /trunk/koffice/tools/okularodpgenerator/libokularGenerator_odp.desktop
   M /trunk/koffice/tools/okularodpgenerator/okularApplication_odp.desktop
   M /trunk/koffice/tools/okularodpgenerator/okularOdp.desktop

SVN_SILENT made messages (.desktop file)

------------------------------------------------------------------------
r1187125 | breitmeyer | 2010-10-18 13:20:06 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/plugins/chartshape/PlotArea.cpp

fixed a crash caused by  unbalanced save restore calls on KoStyleStack


------------------------------------------------------------------------
r1187130 | breitmeyer | 2010-10-18 13:37:33 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/plugins/chartshape/ChartProxyModel.cpp
   M /trunk/koffice/plugins/chartshape/ChartShape.cpp

added some functionality for colors data series in stock charts

------------------------------------------------------------------------
r1187131 | mlaurent | 2010-10-18 13:41:55 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/krita/plugins/filters/blur/kis_wdg_blur.cpp
   M /trunk/koffice/krita/plugins/filters/blur/kis_wdg_blur.h
   M /trunk/koffice/krita/plugins/filters/blur/kis_wdg_gaussian_blur.cpp
   M /trunk/koffice/krita/plugins/filters/blur/kis_wdg_gaussian_blur.h
   M /trunk/koffice/krita/plugins/filters/blur/kis_wdg_lens_blur.cpp
   M /trunk/koffice/krita/plugins/filters/blur/kis_wdg_lens_blur.h
   M /trunk/koffice/krita/plugins/filters/blur/kis_wdg_motion_blur.cpp
   M /trunk/koffice/krita/plugins/filters/blur/kis_wdg_motion_blur.h

Fix mem leak

------------------------------------------------------------------------
r1187132 | mlaurent | 2010-10-18 13:45:58 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/krita/plugins/filters/colors/kis_wdg_color_to_alpha.cpp
   M /trunk/koffice/krita/plugins/filters/colors/kis_wdg_color_to_alpha.h
   M /trunk/koffice/krita/plugins/filters/fastcolortransfer/kis_wdg_fastcolortransfer.cpp
   M /trunk/koffice/krita/plugins/filters/noisefilter/kis_wdg_noise.cpp
   M /trunk/koffice/krita/plugins/filters/randompickfilter/kis_wdg_random_pick.cpp
   M /trunk/koffice/krita/plugins/filters/unsharp/kis_wdg_unsharp.cpp
   M /trunk/koffice/krita/plugins/filters/unsharp/kis_wdg_unsharp.h
   M /trunk/koffice/krita/plugins/filters/wavefilter/kis_wdg_wave.cpp

Fix mem leak

------------------------------------------------------------------------
r1187133 | mlaurent | 2010-10-18 13:47:16 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/krita/plugins/formats/tiff/kis_dlg_options_tiff.cpp

Fix mem leak


------------------------------------------------------------------------
r1187142 | lassin | 2010-10-18 14:34:08 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/filters/kpresenter/pptx/PptxXmlSlideReader.cpp
   M /trunk/koffice/filters/libmsooxml/MsooXmlCommonReader.cpp
   M /trunk/koffice/filters/libmsooxml/MsooXmlCommonReader.h
   M /trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h

Fixed pptx bug where slide with two containers with same Id would mess with each other's styles.


------------------------------------------------------------------------
r1187145 | lukast | 2010-10-18 14:49:46 +0200 (Mon, 18 Oct 2010) | 3 lines
Changed paths:
   M /trunk/koffice/krita/image/kis_curve_rect_mask_generator.cpp

Fix the softbrush rect mask too.

CCBUG:252144

------------------------------------------------------------------------
r1187158 | breitmeyer | 2010-10-18 15:27:44 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/plugins/chartshape/kdchart/src/KDChartModelDataCache_p.h

fix from sebastian for inconsistent DataModelCaches


------------------------------------------------------------------------
r1187162 | breitmeyer | 2010-10-18 15:50:39 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/plugins/chartshape/ChartConfigWidget.cpp

added the support for 3D bubble charts again


------------------------------------------------------------------------
r1187164 | lassin | 2010-10-18 15:52:24 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/filters/kpresenter/pptx/PptxXmlSlideReader.cpp
   M /trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h
   M /trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h
   M /trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp
   M /trunk/koffice/filters/libmsooxml/MsooXmlUtils.h

Fixed pptx cases where partial list override would override list for everything in the frame.


------------------------------------------------------------------------
r1187173 | breitmeyer | 2010-10-18 16:24:36 +0200 (Mon, 18 Oct 2010) | 3 lines
Changed paths:
   M /trunk/koffice/filters/kspread/xlsx/XlsxXmlChartReader.cpp

fixed bubble chart bubble sizes by writing the bubble size into the
internal table


------------------------------------------------------------------------
r1187180 | breitmeyer | 2010-10-18 16:58:09 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/filters/kspread/xlsx/XlsxXmlChartReader.cpp

Fixed bubble chart bubble sizes if no refernces are in the document

------------------------------------------------------------------------
r1187181 | langkamp | 2010-10-18 17:03:15 +0200 (Mon, 18 Oct 2010) | 3 lines
Changed paths:
   M /trunk/koffice/krita/CMakeLists.txt
   M /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_line.cc
   M /trunk/koffice/krita/plugins/tools/tool_star/kis_tool_star.cc
   M /trunk/koffice/krita/ui/tool/kis_tool_ellipse_base.cpp
   M /trunk/koffice/krita/ui/tool/kis_tool_freehand.cc
   M /trunk/koffice/krita/ui/tool/kis_tool_paint.cc
   M /trunk/koffice/krita/ui/tool/kis_tool_paint.h
   M /trunk/koffice/krita/ui/tool/kis_tool_polyline_base.cpp
   M /trunk/koffice/krita/ui/tool/kis_tool_rectangle_base.cpp

don't paint on local selections with painting tools
BUG:252453


------------------------------------------------------------------------
r1187214 | rempt | 2010-10-18 18:48:07 +0200 (Mon, 18 Oct 2010) | 1 line
Changed paths:
   M /trunk/koffice/plugins/colorengines/CMakeLists.txt

better message
------------------------------------------------------------------------
r1187215 | langkamp | 2010-10-18 18:53:19 +0200 (Mon, 18 Oct 2010) | 3 lines
Changed paths:
   M /trunk/koffice/krita/plugins/extensions/imagesize/imagesize.cc
   M /trunk/koffice/krita/ui/kis_layer_manager.cc

fix scale layer for shape layers
CCBUG:251168


------------------------------------------------------------------------
r1187223 | langkamp | 2010-10-18 19:36:55 +0200 (Mon, 18 Oct 2010) | 3 lines
Changed paths:
   M /trunk/koffice/krita/ui/kis_layer_manager.cc

fix mirroring of layers
CCBUG:251168


------------------------------------------------------------------------
r1187238 | uzak | 2010-10-18 20:55:45 +0200 (Mon, 18 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/filters/kpresenter/powerpoint/PptToOdp.cpp
   M /trunk/koffice/filters/kpresenter/powerpoint/PptToOdp.h

PPT: DocumentContainer/SlideHeadersFootersContainer/HeadersFootersAtom saved by MS Office 2003 require corrections.


------------------------------------------------------------------------
r1187326 | mlaurent | 2010-10-19 00:19:29 +0200 (Tue, 19 Oct 2010) | 2 lines
Changed paths:
   M /trunk/koffice/krita/plugins/generators/solid/kis_wdg_color.cpp
   M /trunk/koffice/krita/plugins/paintops/curvebrush/kis_curve_paintop_settings_widget.cpp

Fix mem leak


------------------------------------------------------------------------
r1187362 | zachmann | 2010-10-19 05:15:23 +0200 (Tue, 19 Oct 2010) | 7 lines
Changed paths:
   M /trunk/koffice/karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShapeFactory.cpp
   M /trunk/koffice/karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShapeFactory.h
   M /trunk/koffice/kformula/flake/KoFormulaShapeFactory.cpp
   M /trunk/koffice/kformula/flake/KoFormulaShapeFactory.h
   M /trunk/koffice/kspread/shape/TableShapeFactory.cpp
   M /trunk/koffice/kspread/shape/TableShapeFactory.h
   M /trunk/koffice/libs/flake/KoConnectionShapeFactory.cpp
   M /trunk/koffice/libs/flake/KoConnectionShapeFactory.h
   M /trunk/koffice/libs/flake/KoPathShapeFactory.cpp
   M /trunk/koffice/libs/flake/KoPathShapeFactory.h
   M /trunk/koffice/libs/flake/KoShapeFactoryBase.cpp
   M /trunk/koffice/libs/flake/KoShapeFactoryBase.h
   M /trunk/koffice/libs/flake/tests/TestKoShapeFactory.cpp
   M /trunk/koffice/plugins/artistictextshape/ArtisticTextShapeFactory.cpp
   M /trunk/koffice/plugins/artistictextshape/ArtisticTextShapeFactory.h
   M /trunk/koffice/plugins/chartshape/ChartShapeFactory.cpp
   M /trunk/koffice/plugins/chartshape/ChartShapeFactory.h
   M /trunk/koffice/plugins/commentshape/CommentShapeFactory.cpp
   M /trunk/koffice/plugins/commentshape/CommentShapeFactory.h
   M /trunk/koffice/plugins/divineProportion/DivineProportionShapeFactory.cpp
   M /trunk/koffice/plugins/divineProportion/DivineProportionShapeFactory.h
   M /trunk/koffice/plugins/dockers/shapecollection/CollectionShapeFactory.cpp
   M /trunk/koffice/plugins/dockers/shapecollection/CollectionShapeFactory.h
   M /trunk/koffice/plugins/musicshape/MusicShapeFactory.cpp
   M /trunk/koffice/plugins/musicshape/MusicShapeFactory.h
   M /trunk/koffice/plugins/pathshapes/ellipse/EllipseShapeFactory.cpp
   M /trunk/koffice/plugins/pathshapes/ellipse/EllipseShapeFactory.h
   M /trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp
   M /trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.h
   M /trunk/koffice/plugins/pathshapes/rectangle/RectangleShapeFactory.cpp
   M /trunk/koffice/plugins/pathshapes/rectangle/RectangleShapeFactory.h
   M /trunk/koffice/plugins/pathshapes/spiral/SpiralShapeFactory.cpp
   M /trunk/koffice/plugins/pathshapes/spiral/SpiralShapeFactory.h
   M /trunk/koffice/plugins/pathshapes/star/StarShapeFactory.cpp
   M /trunk/koffice/plugins/pathshapes/star/StarShapeFactory.h
   M /trunk/koffice/plugins/pictureshape/PictureShapeFactory.cpp
   M /trunk/koffice/plugins/pictureshape/PictureShapeFactory.h
   M /trunk/koffice/plugins/pluginshape/PluginShapeFactory.cpp
   M /trunk/koffice/plugins/pluginshape/PluginShapeFactory.h
   M /trunk/koffice/plugins/textshape/TextShapeFactory.cpp
   M /trunk/koffice/plugins/textshape/TextShapeFactory.h
   M /trunk/koffice/plugins/treeshape/TreeShapeFactory.cpp
   M /trunk/koffice/plugins/treeshape/TreeShapeFactory.h
   M /trunk/koffice/plugins/vectorshape/VectorShapeFactory.cpp
   M /trunk/koffice/plugins/vectorshape/VectorShapeFactory.h
   M /trunk/koffice/plugins/videoshape/VideoShapeFactory.cpp
   M /trunk/koffice/plugins/videoshape/VideoShapeFactory.h

The attached patch adds the KoShapeLoadingContext the the
KoShapeFactoryBase::supports method so that information stored in there can be
used to determine if the factory supports the shape.

It removes some wrong test form the KarbonCalligraphicShapeFactory and optimizes
the KoPathShapeFactory to check for the namespace only ones.



svn path=/branches/work/koffice-essen/; revision=1187383

KoShapeFactoryBase::supports method so that information stored in there can be
used to determine if the factory supports the shape.

It removes some wrong test form the KarbonCalligraphicShapeFactory and optimizes
the KoPathShapeFactory to check for the namespace only ones.

svn path=/trunk/koffice/; revision=1187362

There is no reason for the registries and the factories the registries
contain to be QObjects. The only thing it was used for was the
parent-child relation so the factories would be deleted on shutdown.

The objects would thus both be in the hashmap and in the list of
children of the registry, effectively clouding the ownership relation.

To make all registries in KOffice consistent in usage, the destructors
of the registries now delete their contents, there is no parent-child
relationship anymore.

It also saves memory and makes it clear where all these objects are
destroyed

svn path=/branches/work/koffice-essen/; revision=1183433

svn path=/trunk/koffice/; revision=1081943

The dataCenterMap is unused now as all shared resources are stored
in the resourceManager which doesn't require to inherit from the
dataCenter class (which most did without implementing any of its
methods).
Also various cleanups and stuff I missed on previous commits.

svn path=/trunk/koffice/; revision=1079005

svn path=/trunk/koffice/; revision=1078997

Somehow flake/ got left out.

svn path=/trunk/koffice/; revision=865831

svn path=/trunk/koffice/; revision=842719

svn path=/trunk/koffice/; revision=824697

* added some loading code (needs glue point loading in KoShape to work properly)


svn path=/trunk/koffice/; revision=734699

A connection shape which is a parameter shape and 
which can be manipulated with the standard path
tool. You can change the type of the connection 
and connect/disconnect to and from other shapes.
Loading and saving is not implemented yet.
You can change the stroke of the connection like 
with every other shape by using the stroke docker.


svn path=/trunk/koffice/; revision=733107