GitLab

Otherwise strangeness happens.

Just hold Ctrl key and drag outside the Cage bounds

CCMAIL:kimageshop@kde.org

Press Ctrl to select multiple points.

Move --- drag from the inside of the polygon
Rotate --- drag from the outside of the polygon

CCMAIL:kimageshop@kde.org

Which causes asserts.

QColor::fromHsvF: HSV parameters out of range
Could not construct valid color from h 0.833333 s 1 l -8.63674e-28 a 1

This code was off by one and tried to look for anchors after the line current
layouting.

Testing done on :
- the two test cases for bug 332220 : no more crash, comment still visible.
- a simple non-crashing file : no crash, comment still visible.

REVIEW: 120375
BUG: 332220

Some anti-wiggly measure for the color slider docker. This is not as
effective as actually increasing the precision of the algorithms
involved, but it sorta helps decreasing the noise up to 2 colour models
at once.
For all 12 sliders at once the algorithms need to become mre precise,
but that has been more complex than I anticipated. For now, a stopgap
solution.

That was a tough task. The points outside of the outline of the cage
are not defined in green coordinates, so we would either need to:

- chop the grid into smaller chunks near the outline, which would make
  the grid non-uniform with lots of inherited complications

- extrapolate the points near the outline of the cage based on the
  internal points which lay inside the cage polygon.

I chose the latter approach. It is much easier to implement, but has one
small drawback. Sometimes, if your cage is too narrow (e.g. 8-16px wide),
the interpolator may not find the points suitable for a base. In such a case
the corresponding cell of the grind will be dropped from the processing
and you may see an empty cell.

The cell sizes:

1) Preview: 16 px
2) Real transform: 8 px

So when creating the cage, just ensure you are not creating the cage
polygons more narrow than 8 px. This limitation applies only to the
non-deformed grid. The deformed one can have arbitrary configuration.

CCMAIL:kimageshop@kde.org

const char *x[] is still a variable, being an array of non-const pointers
to const chars, x[2] = anotherconststring; is still possible.
const char * const x[] is a const itself, x[2] = anotherconststring; no
longer possible. And is one indirection less when accessing the data,
because x is now the symbol of the actual data and not of the variable
keeping the address of the actual data.

REVIEW: 120326

Thanks Jarosław for review

"const char *x" is still a variable just pointing to const chars,
x = anotherconststring; still possible
"const char x[]" or "const char * const x" is a const itself,
x = anotherconststring; no longer possible and one indirection less when
accessing the data

FindDCMTK.cmake: forgotten to be removed in 44a9df40fe8e604e56d75d68e51f39198c130d58
FindGIF2.cmake: forgotten to be removed in e891dace2586104ad6fd08c7cf7c0e56d37b3a16
FindGLPK.cmake: required for the painterlymixer for unknown reason, which no longer exists (for what I saw)
FindGMM.cmake: forgotten to be removed in 8c0aa949162f9e2ec4da0874815025782ad261f2 ()
FindKunittest.cmake: this is kde3-times stuff, no longer in use
FindLIBGSF.cmake: forgotten to be removed in 65e29251823fcaa8878dc0ab917d53581437cc0b

REVIEW: 120209

thanks Lukáš for review

Those export clauses have to be really correct to work on Windows

Removing some copiler errors.

(in Kexi Report elements)

REVIEW:120290

Use ICU-based collator for sorting text, the same that is used by an SQLite
extension.

BUG:338808
REVIEW:120274
FIXED-IN:2.8.6

Missed custom_commands parameter in call to gmic(...)
in KisGmicTests::filterWithGmic)

Also revert to relying on default values instead of passing them explicitly