GitLab

Should speed things up.

Also speed up the timers a little bit.

According to boud, some desktop enviroments have no close button on dialogs.

Ref T2438

By removing a mask check.

Ref T2438

This was a matter of toggling an option. Beware that tagging with palettes will have all the bugs associated with the other tagging options.

With the colorname hover-options, this means that this fixes
BUG:360453

Seemed like it should to me.

This also implements two 'closest match' functions in kocolorset. One for the name, the other only for the index.

BUG:348837

If I was better with regexp it might've been a bit smoother, but at the least you can now type in a colorname to select it quickly.

Ref T2438

Also fix some issues with setting hsv and fix and remove some debug.

Now the palette swatches align :)

Ref 2438

The palette docker doesn't have the ability to give tooltips due being a slightly different model, so hence the extra label.

I also tried setting the kocolorsetwidget the size of the current column count, but this crashes on startup for reasons I cannot understand.

Ref 2438

This doesn't prevent a crash when closing all available documents, sadly.

But it's not fast enough yet. Also using QImage everywhere now, it's a bit more sensible...

Ref T2438

BUG:367537 fix 3_texture PNG file so it shows transparency. It was set to sRGB and I changed it to RGB

Ref T2438

Ref T2438

I spent 9+ hours trying to figure out how to make one where the value length fully vertical, but failed, so gave up and copied the kis_color_selector_triangle solution.

Ref 2438

Patch by Joe (joewinzer@googlemail.com). Thanks!

If the label is beyond the currently allowed range of labels, set
it to the last available label.

We had "spray shape" used twice, and incorrectly for the first
entry.

BUG:367540
CCMAIL:kde-i18n-doc@kde.org

fixes up the grids portion of the grids & guides docker a fair bit.

Makes the code simpler though...

The jaggies were starting to annoy me.

Might make the pixmap into a image later just so we can have proper transparency.

The previous code made not much sense...

They should always have some color and not become transparent again.

BUG:367547

This is a bit finicky still. Also weird bugs with Qt cause flickering when changing widgets, due to having to force them to show. :/ Might need to think a bit longer about this...

Ref T2438

only for reading. The format has a new #Folder row which sets absolute paths for the pictures of each layers.
I think this solution is weaker than the old one, so I added only read support.

This is useful for non-cyclic channels.

moves the aspect ratio button for offsets to the right of
the spin boxes

puts almost all widgets into a single GridLayout

reorganizes the items in the code to correspond to their order
in the grid

Summary:
KisUpdaterContext::waitForDone() method must lock context and wait
untill all threads finish their current tasks.
We cannot call QThreadPool.waitForDone() to do this, because after
waiting it removes all threads from the pool.

Test Plan:
Verified that no extra threads created: 8 for global thread pool and 8 for
KisUpdaterContext

(gdb) info threads
  Id   Target Id         Frame
  22   Thread 0x7fff8cff9700 (LWP 18481) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  21   Thread 0x7fff8d7fa700 (LWP 18480) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  20   Thread 0x7fff8dffb700 (LWP 18479) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  19   Thread 0x7fff8e7fc700 (LWP 18478) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  18   Thread 0x7fff8effd700 (LWP 18477) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  17   Thread 0x7fff8f7fe700 (LWP 18476) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  16   Thread 0x7fff8ffff700 (LWP 18475) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  15   Thread 0x7fff9bfff700 (LWP 18474) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  13   Thread 0x7fffb8ff9700 (LWP 18471) "QFileInfoGather" 0x00007fffef6e291f in pthread_cond_wait () from /lib64/libpthread.so.0
  12   Thread 0x7fffb97fa700 (LWP 18470) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  11   Thread 0x7fffb9ffb700 (LWP 18469) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  10   Thread 0x7fffba7fc700 (LWP 18468) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  9    Thread 0x7fffbaffd700 (LWP 18467) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  8    Thread 0x7fffbb7fe700 (LWP 18466) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  7    Thread 0x7fffbbfff700 (LWP 18465) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  6    Thread 0x7fffc8f8a700 (LWP 18464) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  5    Thread 0x7fffc978b700 (LWP 18463) "Thread (pooled)" 0x00007fffef6e2cc8 in pthread_cond_timedwait () from /lib64/libpthread.so.0
  4    Thread 0x7fffca38d700 (LWP 18462) "KisTileDataSwap" 0x00007fffef6e291f in pthread_cond_wait () from /lib64/libpthread.so.0
  3    Thread 0x7fffcab8e700 (LWP 18461) "KisTileDataPool" 0x00007fffef6e291f in pthread_cond_wait () from /lib64/libpthread.so.0
  2    Thread 0x7fffe0843700 (LWP 18460) "QXcbEventReader" 0x00007ffff16a33ed in poll () from /lib64/libc.so.6
* 1    Thread 0x7fffe7f3f7c0 (LWP 18456) "krita" 0x00007ffff16a33ed in poll () from /lib64/libc.so.6

Reviewers: dkazakov

Reviewed By: dkazakov

Subscribers: fazek
BUG:360677
Differential Revision: https://phabricator.kde.org/D1166

Not too useful and actually a little slow, but good practice.

Also rearranged the widget a lot. The KoColorSetWidget is automatically filled with the first palette in the list(which is, as always, concept cookie), and the palette is saved... right now on leave and accept events, which might not be the most intuitive, but at the least it is saved and loaded correctly.

Neither widget has the color management from the displayrenderer, as that would require me editing those directly.

I would like an eye on said save/load code.
Auditors: rempt

The cursor won't flip about when desaturated, but saturation itself is
still very tricky. Either way, outside updates won't affect a thing.

Turns out there was an 'undefined' value...

Ref T2438

Previous version just didn't work. This fixes the HSL output.

Ref T2438