GitLab

Forward port of 817e66fd

new icon for transform from pivot

KoFileDialog saves the last used location based on the OpenDocument
flag, and it's really annoying if the dialog resets to ~/Pictures
all the time.

QUrl::file() is a very false friend...

This must've been broken since September, and it meant that you'd
only see use system monitor profile checkbox if colord wasn't running,
which meant nothing would happen.

Even for floating point lab the unit value should be
 0-100, -128-127, -128-127

Summary:
Some actions should not be started before all the previous actions
are finished. That is especially true for the actions that work
with layers stack, like "Merge Down" and "Flatten".

Now KisDelayedSaveDialog is used not only for saving, but also for
waiting before doing usual actions. It also has a busy-loop timeout of
1 second before showing up, for not distracting painters from their
workflow when the action is postponed only a little bit.

BUG:372724
Fixes T4593

Test Plan:
Basically, the steps like in bug 372724.

1) Select multiple layers
2) Start a long stroke (1000px colorsmudge brush is a good example)
3) Press Ctrl+E ***multiple*** times quickly
4) After all the background work is finished, press Ctrl+Z

There should be no crash, and the result should be somewhat expected.

Repeat the same for:
1) Merge down
2) Flatten Image
3) Flatten Layer
4) Transform a layer using "Layers" menu(?)

Reviewers: #krita, timotheegiet, scottpetrovic

Maniphest Tasks: T4593

Differential Revision: https://phabricator.kde.org/D3449

The right extension is now always used, and if the codecs are
there, ffmpeg will render the animation.

For the future, we should probably implement a way to set the
framerate for animation...

Summary:
This patch should fix a crash that happens after
KisShapeLayerCanvas::repaint() is called on a cloned image. Actually,
KisShapeLayer::setImage() was implemented incorrectly. It deleted
m_d->converter and m_d->paintDevice, although canvas still owned a link
to them. Therefore the next coming update crashed the application.

BUG:372357

Test Plan:
I could never reproduce the original bug, I only used the results of
Boud's valgrind output. So please test the original bug with the patch
before I push it into 3.1 and impex.

Reviewers: #krita, rempt

Differential Revision: https://phabricator.kde.org/D3452

update zoom menu icons with latest version from breeze which works better

BUG:369344

use the exact same color on all svg icons

BUG: 372695

fix up the alignmen a bit on the predefined presets widget. also update the auto-spacing widget so the checkbox aligns better with the left edge

add asterisk to preset names if they are in a tweaked state. This should help in a details view if the icon is smaller

add connection back that got lost in the merge. this hooks up changing the brush engine icon to the toolbar

We should pass already normalized base angle values to the sensor

BUG:366289,369451

The brushes should be loaded before doing any testing

Summary: BUG:372545

Test Plan:
This patch touches rotation and mirroring capabilities of the brushes. These
parameters depend on both, brush and canvas rotation/mirroring capabilities,
so they should be tested in complex.

1) Test with rotated (or drawing angle) brushes
2) Test with mirrored (including using sensor) brushes
3) Test with rotated canvas
4) Test with mirrored canvas
5) Test with all combinations of the above :)

The general idea of canvas rotation/mirroring is:

Whenever you rotate or mirror the canvas, brush shape *doesn't* change
its shape from your point of view. That is if you paint with a
vertical rectangular brush, the brush should still stay vertical
whenever you rotate/miror the canvas. In other words, the brush shape
is linked to your stylus tip, not to the canvas.

Reviewers: #krita, woltherav, timotheegiet

Differential Revision: https://phabricator.kde.org/D3420

1) Don't start copying the image when another saving operation
   is already in progress.

2) Don't reset d->savingImage to null without holding the lock