GitLab

Make some file formats return KisImportExportFilter::UserCancelled when their options dialogs are cancelled

Summary:
The file formats affected by this patch are: r16 heightmap/r8 heightmap/JPEG-2000/JPEG/PNG/PPM/PGM/PBM

These formats return KisImportExportFilter::OK rather than KisImportExportFilter::UserCancelled when their import/export options dialog is cancelled.

This leads to buggy behaviour that can be reproduced using either set of the following steps:
CASE 1
    * Create a new document and modify it
    * Close the document and opt to save it as one of the affected formats
    * Cancel when the export options appear
    * (The document closes without saving)
CASE 2
    * Open a heightmap
    * Cancel when the import options appear
    * (Krita crashes)

I've also modified kis_png_export.cc so that it sets up the Cancel/OK buttons explicitly instead of relying on getting them by default from KDialog.

Reviewers: #krita:_stable, rempt

Reviewed By: #krita:_stable, rempt

Subscribers: rempt

Differential Revision: https://phabricator.kde.org/D548

Patch by Nicholas LaPointe, thanks!

This adds another optional framework. Probably only useful on Linux.

So we can reuse it for a news/forum feed widget that gets shown
when there are no open windows.

It is useful to have krita.input separated from krita.tabletlog.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: Here is a diff which contains my local work done so far.  Although there is always more work to do to get the internals looking cleaner, I think the core is now in an acceptable state. The primary step after this will be to implement loading and saving.  Once that is finished, schemes support should be straightforward to implement.

Reviewers: rempt

Maniphest Tasks: T947

Differential Revision: https://phabricator.kde.org/D498

Summary:
This replaces most calls to `new QAction` with `KisActionRegistry::makeQAction()`, getting rid of static data in the code.

Now, instead of i18n() calls in the code right next to each action, krita.action  (and the other .action files) become the primary source of strings.

To handle this, we make a small modification to the script extractrc, which I've called action_i18n.pl.  This is intended for testing, the ultimate goal being to merge the changes to upstream extractrc.

Messages.sh is modified to include action_i18n.pl for the generation of translation strings.

Depends on D478

Tasks: T947

Reviewers: kossebau, rempt

Differential Revision: https://phabricator.kde.org/D479

Summary:
This removes most of the shortcut management code from KisPart.

Depends on D476

Tasks: T947

Reviewers: rempt

Reviewed By: rempt

Differential Revision: https://phabricator.kde.org/D478

Also fix duplicated signals problem caused by adding the proxies twice

BUG:352918

See a comment in KisMergeWalker::startTripWithMask()

BUG:353043

This happened becayse KisView stored a pointer to a locally active
layer which has been deleted while the view was inactive

BUG:355205

Fixes T1045

Instead of using a QImage, either full-sized or already down-sampled,
that then gets scaled again.

CCBUG:352781

This reverts commit dd81431d.

This prevents the theme from reloading all icons during startup,
loading them once is enough now.

Switching themes is still broken, though, that needs bisecting, I'm
afraid.

add animation stop icons

Ref T1042

Just press Shift and drag over the sliders and they'll be ordered accordingly.
If you also press Ctrl or right mouse button, the sliders will move smoothly.

This feature doesn't work for the top buttons, but if you want to disable
some skins, just drag over the bottom part of the widget and when the sliders
reach 0 level, the buttons will be disabled automatically

Fixes:T1043

Fixes T1044

CCBUG:352781

add Animation workspace

Seriously, tell me it's not a little ridiculous that
QCoreApplication::applicationDirPath() would be dropped from
QCoreApplication::libraryPaths().

Summary: This seems almost finished, but I'm stuck. I create an installer successfully but get a "windows platform plugin not found" error on the target machine.

Reviewers: rempt

Differential Revision: https://phabricator.kde.org/D506

This fixes some names and some TRCs.

Resolves T1039