• Nicholas LaPointe's avatar
    Scale channel values by 255.0 when sending a non-RGBA image to G'MIC · 26e32b7e
    Nicholas LaPointe authored
    A different code path is taken depending on whether or not the image data to be sent to G'MIC is in the RGBA space.
    In the RGBA case, the channel values are scaled to range between 0.0 and 255.0
    In the non-RGBA case, the values were not being similarly scaled before this commit.
    (In both cases, the image is converted to use 32-bit float RGBA before any scaling is applied.)
    
    This is different from how the old plug-in worked:
    Old plug-in
        convertToGmicImageFast() on RGBA image fills gmicImage._data with values between 0.0 and 1.0
        convertToGmicImage() on non-RGBA image fills gmicImage._data with values between 0.0 and 1.0
    
    New plug-in, after commit
        convertToGmicImageFast() on RGBA image fills gmicImage->_data with values between 0.0 and 255.0
        convertToGmicImage() on non-RGBA image fills gmicImage->_data with values between 0.0 and 255.0
    
    New plug-in, before commit
        convertToGmicImageFast() on RGBA image fills gmicImage->_data with values between 0.0 and 255.0
        convertToGmicImage() on non-RGBA image fills gmicImage->_data with values between 0.0 and 1.0
    
    BUG: 382396
    Differential Revision: https://phabricator.kde.org/D7225
    26e32b7e
kis_qmic_simple_convertor.h 1.81 KB