1. 10 Jul, 2019 3 commits
    • Boudewijn Rempt's avatar
      Try to make this test succeed on Jenkins · 32f46f79
      Boudewijn Rempt authored
      Apparently, on Jenkins we cannot create all of these colorspaces,
      so don't fail by dereferencing a null pointer:
      
      ********* Start testing of TestLcmsRGBP2020PQColorSpace *********
      Config: Using QtTest library 5.12.4, Qt 5.12.4 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.1.1 20190611 [gcc-9-branch revision 272147])
      PASS   : TestLcmsRGBP2020PQColorSpace::initTestCase()
      AddressSanitizer:DEADLYSIGNAL
      =================================================================
      ==6181==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000008 (pc 0x7f3f02031167 bp 0x7fff6f5c1290 sp 0x7fff6f5c1280 T0)
      ==6181==The signal is caused by a READ memory access.
      ==6181==Hint: address points to the zero page.
          #0 0x7f3f02031166 in KoColorSpace::id() const /home/jenkins/workspace/Extragear/krita/kf5-qt5 SUSEQt5.12/libs/pigment/KoColorSpace.cpp:106
          #1 0x41535a in testRoundTrip(KoColorSpace const*, KoColorSpace const*, SourceType) /home/jenkins/workspace/Extragear/krita/kf5-qt5 SUSEQt5.12/plugins/color/lcms2engine/tests/TestLcmsRGBP2020PQColorSpace.cpp:44
          #2 0x418726 in testRoundTrip(KoID const&, KoID const&, SourceType) /home/jenkins/workspace/Extragear/krita/kf5-qt5 SUSEQt5.12/plugins/color/lcms2engine/tests/TestLcmsRGBP2020PQColorSpace.cpp:118
          #3 0x4192b2 in TestLcmsRGBP2020PQColorSpace::test() /home/jenkins/workspace/Extragear/krita/kf5-qt5 SUSEQt5.12/plugins/color/lcms2engine/tests/TestLcmsRGBP2020PQColorSpace.cpp:143
          #4 0x40aa2c in TestLcmsRGBP2020PQColorSpace::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) /home/jenkins/workspace/Extragear/krita/kf5-qt5 SUSEQt5.12/build/plugins/color/lcms2engine/tests/TestLcmsRGBP2020PQColorSpace_autogen/EWIEGA46WW/moc_TestLcmsRGBP2020PQColorSpace.cpp:78
          #5 0x7f3efcc6889a in QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const (/usr/lib64/libQt5Core.so.5+0x29689a)
          #6 0x7f3f050a0962  (/usr/lib64/libQt5Test.so.5+0x19962)
          #7 0x7f3f050a1352  (/usr/lib64/libQt5Test.so.5+0x1a352)
          #8 0x7f3f050a1910  (/usr/lib64/libQt5Test.so.5+0x1a910)
          #9 0x7f3f050a1cda in QTest::qRun() (/usr/lib64/libQt5Test.so.5+0x1acda)
          #10 0x7f3f050a1edb in QTest::qExec(QObject*, int, char**) (/usr/lib64/libQt5Test.so.5+0x1aedb)
          #11 0x41b9d7 in main /home/jenkins/workspace/Extragear/krita/kf5-qt5 SUSEQt5.12/plugins/color/lcms2engine/tests/TestLcmsRGBP2020PQColorSpace.cpp:185
          #12 0x7f3efc4f2bca in __libc_start_main (/lib64/libc.so.6+0x26bca)
          #13 0x40a8f9 in _start (/home/jenkins/workspace/Extragear/krita/kf5-qt5 SUSEQt5.12/build/plugins/color/lcms2engine/tests/TestLcmsRGBP2020PQColorSpace+0x40a8f9)
      
      AddressSanitizer can not provide additional info.
      SUMMARY: AddressSanitizer: SEGV /home/jenkins/workspace/Extragear/krita/kf5-qt5 SUSEQt5.12/libs/pigment/KoColorSpace.cpp:106 in KoColorSpace::id() const
      ==6181==ABORTING
      32f46f79
    • Boudewijn Rempt's avatar
      Fix the KisimageSignalRouterTest · c5986f60
      Boudewijn Rempt authored
      Either an update to Qt broke testing unregistered types, or
      this test has always been broken, or some other change to
      the KisImageSignalRouter class made it necessary that the
      arguments were registered with qRegisterMetaType...
      
      But KoColorProfile and KoColorSpace cannot be registered
      with qRegisterMetaType because they are abstract classes,
      so we cannot check those signals in this test.
      c5986f60
    • Ivan Yossi's avatar
      Fix copy/paste frames to clipboard · 5b8660d2
      Ivan Yossi authored
      This does not work if source was closed inbetween operations or
      source is in another krita instance.
      
      BUG:408421
      BUG:404595
      5b8660d2
  2. 09 Jul, 2019 17 commits
  3. 08 Jul, 2019 4 commits
    • Agata Cacko's avatar
      Fix Mirror All Layers Horizontally · 8ee3fe67
      Agata Cacko authored
      Before this commit this action would mirror them vertically.
      (It's under Layer -> Transform All Layers -> menu entry)
      8ee3fe67
    • Boudewijn Rempt's avatar
      Add a log line for instant preview · 779e3cba
      Boudewijn Rempt authored
      779e3cba
    • Dmitry Kazakov's avatar
      Possibly fix a crash on systems with openGL 2.1 · d927af0c
      Dmitry Kazakov authored
      OpenGL 2.1 systems are supported, but Small Colro Selector is not
      available for them, because it doesn't have legacy shaders (needs
      to be implemented).
      
      CCBUG:408872
      d927af0c
    • Agata Cacko's avatar
      Fix switching profile to default in New file dialog · 9ebd13b4
      Agata Cacko authored
      Before this commit if you first selected the color model,
      then color profile, then color depth, the color profile would switch to
      default for this color depth no matter that the user just set it
      manually. This is mostly the problem if someone is for example using
      Rec2020 profile for HDR images and switches between 32 and 16 bit
      color depths.
      
      Behaviour now:
      - by default color profile changes to the default one that suits
      the color model and color depth
      - if the user sets the profile manually, it is remembered
      and if it changes color depth, the profile doesn't change
      (keep in mind that "(Default)" suffix is still attached
      to the default profile, so it's easy to find in case the user wants it
      - if the user changes the color model, the default behaviour
      (switching profile automatically) is restored until the user
      sets up the profile maually again.
      
      BUG:406700
      9ebd13b4
  4. 06 Jul, 2019 13 commits
  5. 05 Jul, 2019 3 commits
    • Dmitry Kazakov's avatar
      Fix KisNodeModelTest · dd2b417e
      Dmitry Kazakov authored
      dd2b417e
    • Boudewijn Rempt's avatar
      Also fix the timeline_model_test · c1981cf4
      Boudewijn Rempt authored
      c1981cf4
    • Boudewijn Rempt's avatar
      "Fix" kisNodeModelTest · 90a2de3c
      Boudewijn Rempt authored
      The KisNodeModelTest didn't set the image it was testing with on
      the document. This broke in KisShapeController::setImage(KisImageWSP image),
      which cleared all connections, then didn't use the image parameter
      but the local doc's image object (which is 0) to reconnect the signals/slots,
      and which then crashed in KisShapeController::slotUpdateDocumentResolution(),
      where the image would still be 0.
      
      Howewever, the question is: should this function even have this parameter?
      If so, should the image then be set on the doc? Should this function even
      exist since it makes it possible to have a local m_doc->image() that is
      different from the image parameter?
      
      There are still a bunch of warnings, too.
      
      boud@boud-ThinkPad-T470p:~/dev/b-krita/libs/ui/tests$ ./kis_node_model_test
      ********* Start testing of KisNodeModelTest *********
      Config: Using QtTest library 5.12.3, Qt 5.12.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.4.0)
      PASS   : KisNodeModelTest::initTestCase()
      QWARN  : KisNodeModelTest::testSetImage() KoColor debug runtime checks are active.
      PASS   : KisNodeModelTest::testSetImage()
      QWARN  : KisNodeModelTest::testAddNode() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testAddNode() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testAddNode() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testAddNode() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testAddNode() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      PASS   : KisNodeModelTest::testAddNode()
      QWARN  : KisNodeModelTest::testRemoveAllNodes() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testRemoveAllNodes() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testRemoveAllNodes() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testRemoveAllNodes() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testRemoveAllNodes() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      PASS   : KisNodeModelTest::testRemoveAllNodes()
      QWARN  : KisNodeModelTest::testRemoveIncludingRoot() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testRemoveIncludingRoot() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testRemoveIncludingRoot() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testRemoveIncludingRoot() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      QWARN  : KisNodeModelTest::testRemoveIncludingRoot() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500
      PASS   : KisNodeModelTest::testRemoveIncludingRoot()
      PASS   : KisNodeModelTest::cleanupTestCase()
      Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted, 1597ms
      ********* Finished testing of KisNodeModelTest *********
      90a2de3c