1. 10 Jul, 2019 1 commit
  2. 06 Jul, 2019 1 commit
  3. 07 Jun, 2019 1 commit
    • Dmitry Kazakov's avatar
      Fix a crash when creating a text shape · eb611609
      Dmitry Kazakov authored
      Every KoShapeController used to reset the global "shape document" in its
      KoDocumentResourceManager. The problem is that in Krita we have multiple
      KoShapeController-s, but the resource manager is the only one. It means
      that every shape selection or shape layer used to reset the pointer to
      the global "shape document" to its own one. The only reason why we didn't
      have too many crashes is that almost noone uses this "shape document".
      
      Ideally we should:
      1) Remove KoDocumentResourceManager::GlobalShapeController resource. This
         resource is not global to the document, but is created per-layer. The only
         user of it atm is the legacy text tool, which should be deprecated.
      
      2) Remove KoDocumentResourceManager at all. There is no much use of it
         anymore. Its main user is legacy text tool.
      
      BUG:407554
      eb611609
  4. 19 Apr, 2019 1 commit
  5. 05 Mar, 2019 1 commit
    • Agata Cacko's avatar
      Refactor KoUnit · 9d5baac8
      Agata Cacko authored
      Summary:
      This commit fixes two problems in KoUnit:
      (1) two functions named differently while doing
      nearly exactly the same thing (ptToUnit, toUserValue)
      and the difference in the name or arguments of functions
      not showing the difference in the results,
      (2) repeated constant values in functions
      called to[Unit] (i.e. toMillimeters).
      This commit is not to cause any difference in behaviour
      (including in particular converting and rounding values)
      and contains unit tests to test that.
      
      Test Plan:
      - created unit test to test the difference in conversions
      (should not none).
      - all the places where the difference in functions naming
      caused changes in files other than [Test]KoUnit.h/.cpp
      
      Reviewers: #krita, rempt
      
      Reviewed By: #krita, rempt
      
      Subscribers: rempt
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D19537
      9d5baac8
  6. 23 Jan, 2019 1 commit
  7. 10 Jan, 2019 1 commit
  8. 09 Jan, 2019 1 commit
  9. 07 Jan, 2019 1 commit
  10. 06 Jan, 2019 1 commit
  11. 05 Jan, 2019 1 commit
  12. 29 Nov, 2018 1 commit
    • Boudewijn Rempt's avatar
      add a createActions method to KoToolFactoryBase · 5f91230f
      Boudewijn Rempt authored
      Actions created by a tool instance only exist if there's an open
      document, which means they cannot be configured or placed in
      toolbars. We should only have per-window actions, not per-action
      actions.
      
      Creating the actions in the toolfactory instead of the tool when
      the window is created fixes that: now the tools will retrieve
      the actions from the global action collection on activations
      and de-activation, like the freehand tool already did for increase
      and decrease brush size.
      
      Note: this commit breaks the following tools because it's not
      worth porting hidden tools in any case:
      
      * artistic text tool
      * odf text tool
      * connection tool
      
      BUG:365222
      
      CMAIL:kimageshop@kde.org
      5f91230f
  13. 07 Oct, 2018 1 commit
  14. 06 Oct, 2018 1 commit
  15. 29 Sep, 2018 1 commit
  16. 27 Sep, 2018 1 commit
  17. 23 Aug, 2018 1 commit
  18. 20 Aug, 2018 1 commit
  19. 09 Aug, 2018 2 commits
  20. 06 Aug, 2018 1 commit
  21. 05 Aug, 2018 2 commits
  22. 31 Jul, 2018 1 commit
  23. 24 Jul, 2018 1 commit
  24. 26 Jun, 2018 1 commit
    • Boudewijn Rempt's avatar
      Remove obsolete KoGlobal singleton · 2bc337cd
      Boudewijn Rempt authored
      This was only used to access kritarc in an obsolete way and to
      build a list of languages that was used in two places: the old
      text tool and the document info dialog. However, it has been
      broken and returned an empty list for many years now.
      2bc337cd
  25. 06 Jun, 2018 1 commit
    • Boudewijn Rempt's avatar
      Remove obsolete KoGlobal singleton · 528b0481
      Boudewijn Rempt authored
      This was only used to access kritarc in an obsolete way and to
      build a list of languages that was used in two places: the old
      text tool and the document info dialog. However, it has been
      broken and returned an empty list for many years now.
      528b0481
  26. 10 May, 2018 1 commit
  27. 26 Apr, 2018 5 commits
  28. 24 Apr, 2018 1 commit
    • Dmitry Kazakov's avatar
      Fix crashes on undo/redo of vector path points operations · 25a628eb
      Dmitry Kazakov authored
      1) KoPathToolSelection keeps pointers to the shapes and its path points,
         therefore it should subscribe to the updates on the shapes and their
         points (using ShapeChangeListener framework).
      
      2) The patch also fixes a lot of bugs in "Join by segment" and
         "Merge points", which should behave correctly now.
      
      3) The patch also partially implements "keep path point selection"
         idea, which selects newly created point after each operation. The
         stuff is achieved using KoPathShape::PointSelectionChangeListener
         listener.
      
      BUG:393209
      BUG:393087
      25a628eb
  29. 04 Apr, 2018 1 commit
  30. 19 Mar, 2018 1 commit
  31. 27 Feb, 2018 1 commit
  32. 23 Feb, 2018 1 commit
  33. 13 Feb, 2018 1 commit
  34. 09 Feb, 2018 1 commit