1. 27 Mar, 2013 1 commit
  2. 24 Jan, 2013 1 commit
    • Vishesh Handa's avatar
      KFileItemModelRolesUpdater: Avoid multiple updates for Nepomuk data · af280715
      Vishesh Handa authored
      The Nepomuk ResourceWatcher emits 3 signals - propertyChanged,
      propertyAdded and propertyRemoved. We should only listen to either the
      propertyChanged signal or the propertyAdded + Removed signals. There is
      no point in listening to all 3 signals. That will just result in
      unnecessary updates.
      
      Additionally, we do not need to listen to the resourceCreated signal.
      That is only emitted when we are watching for a specific types, which we
      are not.
      
      REVIEW: 108543
      af280715
  3. 30 Oct, 2012 1 commit
    • Frank Reininghaus's avatar
      Remove workaround for bug 304986 which is not needed in master · 66a35712
      Frank Reininghaus authored
      Commit ea6a7c09 added a workaround for
      bug 304986 (high CPU usage because KFileItemModelRolesUpdater requests
      previews for the same files over and over again after, e.g., a rename
      operation). The KDE/4.10 branch of kdelibs contains the real fix for
      this issue (b8f64ca3f4b6311519c21046031d66d9d0a570c6), so the workaround
      can be removed.
      66a35712
  4. 27 Oct, 2012 1 commit
    • Frank Reininghaus's avatar
      Workaround for failed comparison of items in KFileItemModelRolesUpdater · ea6a7c09
      Frank Reininghaus authored
      The real fix is in the KDE/4.10 branch of kdelibs
      (commit b8f64ca3f4b6311519c21046031d66d9d0a570c6). We work around the
      problem that the KFileItem that a preview has been requested for is
      different from the KFileItems in the sets m_pendingVisibleItems and
      m_pendingInvisibleItems by refreshing those sets when we detect that
      the bug has been triggered.
      
      BUG: 304986
      FIXED-IN: 4.9.3
      ea6a7c09
  5. 15 Oct, 2012 1 commit
  6. 27 Sep, 2012 1 commit
  7. 26 Sep, 2012 1 commit
  8. 24 Sep, 2012 1 commit
  9. 06 Aug, 2012 2 commits
  10. 28 Jul, 2012 2 commits
  11. 11 Jun, 2012 1 commit
    • Peter Penz's avatar
      Update "isExpandable" and "size"-roles · 783b3219
      Peter Penz authored
      If the "isExpandable"- or "size"-role is shown for a folder, the
      number of sub-items must be watched to be able to update the
      state of those 2 roles.
      
      This fixes the issue that e.g. no expanding-toggle is shown
      if an sub-directory has been created inside an empty directory.
      
      BUG: 293972
      FIXED-IN: 4.9.0
      783b3219
  12. 09 Jun, 2012 1 commit
    • Peter Penz's avatar
      Folders Panel: Also count directory links · 3c3d437d
      Peter Penz authored
      ... otherwise no expansion toggle will be shown. The implementation
      is a compromise between performance and correctness: If the directory
      contains links that are not directories, an unnecessary expansion
      toggle will be shown. But this is better than showing no expansion
      toggle in case if the directory contains links that point to other
      directories.
      
      BUG: 299997
      FIXED-IN: 4.9.0
      3c3d437d
  13. 08 Jun, 2012 1 commit
  14. 06 May, 2012 3 commits
  15. 17 Apr, 2012 1 commit
    • Peter Penz's avatar
      Ensure authentication data is cached properly · ff37139b
      Peter Penz authored
      The attached patch sets the main window on the main directory
      lister in DolphinView and KIO jobs in DolphinMainWindow to ensure
      that login data for remote protocols such as sftp, ftp are cached
      properly for the duration of the application. Otherwise, the end
      user is going to end up being unnecessarily re-prompted to enter
      password login information.
      
      Thanks to Dawit Alemayehu for the patch!
      
      REVIEW: 104614
      FIXED-IN: 4.9.0
      ff37139b
  16. 11 Apr, 2012 2 commits
    • Peter Penz's avatar
      KFileItemModel: interface cleanups · 6390544e
      Peter Penz authored
      Fix some naming inconsistencies regarding the usage of 'dir' vs.
      'directory' vs. 'folder'.
      6390544e
    • Peter Penz's avatar
      KItemViews: Internal directory restructuration · 2caff15b
      Peter Penz authored
      - Move all private headers from the kitemviews-directory into
      the 'private' subdirectory.
      
      - Get rid of DolphinDirLister and just use a directory-lister
        internally in KFileItemModel.
      
      - Minor interface-cleanups for signals
      2caff15b
  17. 10 Apr, 2012 1 commit
    • Peter Penz's avatar
      Improvements for slow sorting roles · 99ccc5f4
      Peter Penz authored
      If the sorting is done for data which is resolved asynchronously
      (e.g. rating), it is important to give a visual feedback about
      the state of the sorting. This is done now by a progress
      indication in the statusbar.
      
      Also optimizations for "Sort by type" have been done: Although
      resolving a type can be expensive in the most often case it is a
      very cheap operation. So it the sorting is done by type, try
      to resolve the type synchronously for at least 200 ms to prevent
      a asynchronous resorting. This is usually sufficient to have
      resolved types even for directories with several thousands of
      items.
      
      BUG: 292733
      FIXED-IN: 4.9.0
      99ccc5f4
  18. 08 Apr, 2012 2 commits
  19. 06 Apr, 2012 2 commits
  20. 01 Apr, 2012 1 commit
    • Peter Penz's avatar
      Allow showing Nepomuk metadata inside views · 270e0c3e
      Peter Penz authored
      Metadata like image-size, rating, comments, tags, ... can be shown
      now in the view (e.g. as column in the Details mode).
      
      Still open: The rating-information needs to be shown as stars.
      
      In the context of this feature also the following bugs have been
      fixed:
      - Fix visual glitches in the header of the Details mode
      - Improve the minimum column width calculation to respect also
        the headling and not only the content
      
      BUG: 296782
      FIXED-IN: 4.9.0
      270e0c3e
  21. 21 Mar, 2012 1 commit
    • Peter Penz's avatar
      Prevent flickering when updating items · d389ae95
      Peter Penz authored
      When downloading images from e.g. the camera-IO-slave the files
      will be downloaded as *.part files and renamed afterwards. The renaming
      results in an undetermined mimetype and hence the probably already available
      preview or icon gets replaced by a dummy icon. The patch fixes this by
      keeping the old values as long until they have been resolved by
      KFileItemModelRolesUpdater.
      d389ae95
  22. 23 Feb, 2012 1 commit
  23. 21 Feb, 2012 1 commit
    • Peter Penz's avatar
      Don't trigger assert when switching to details-view · ac818a14
      Peter Penz authored
      If the visible roles of the details-view are equal to the visible roles
      of other views, then switching to the details-view will trigger an
      assert because the invisible roles don't get updated.
      
      Thanks to Frank Reininghaus for the detailed analyses!
      
      In the context of this fix optimizations have been done when switching
      view-modes: The "don't-animate-workaround" could be removed.
      
      BUG: 294531
      FIXED-IN: 4.8.1
      ac818a14
  24. 03 Feb, 2012 2 commits
    • Peter Penz's avatar
      Show the value "Unknown" for the item-count only after it has been verified · 9643e50a
      Peter Penz authored
      During determining the item-count for directories just show an empty string
      until either the item-count has been calculated or if the item-count is unknown.
      
      Thanks to Nikita Skovoroda for the initial proof-of-concept patch.
      
      BUG: 291823
      FIXED-IN: 4.8.1
      9643e50a
    • Peter Penz's avatar
      Folders Panel: Show expansion toggles for directories on ISO-images · 912765b5
      Peter Penz authored
      When counting the number of sub-directories consider unknown file types
      as potential directories. In the "worst case" an expansion toggle will be
      shown although the directory contains only files, however from a performance
      point of view this seems to be an acceptable compromise.
      
      BUG: 292642
      FIXED-IN: 4.8.1
      912765b5
  25. 01 Feb, 2012 2 commits
    • Peter Penz's avatar
      KFileItemModelRolesUpdater: Optimize updates · 4ffaf462
      Peter Penz authored
      The asynchronous resolving to bypass performance bottlenecks is not necessary
      anymore as multiple ranges can be inserted in one step now. This solves the issue
      that e.g. opening a tree resulted in temporary unknown icons for a short period
      of time.
      4ffaf462
    • Peter Penz's avatar
      KFileItemModelRolesUpdater: Optimize updates · fba1e446
      Peter Penz authored
      The asynchronous resolving to bypass performance bottlenecks is not necessary
      anymore as multiple ranges can be inserted in one step now. This solves the issue
      that e.g. opening a tree resulted in temporary unknown icons for a short period
      of time.
      fba1e446
  26. 15 Jan, 2012 2 commits
  27. 11 Jan, 2012 2 commits
  28. 09 Jan, 2012 2 commits
    • Peter Penz's avatar
      Prevent generating previews all the time during downloading a large file · 5ce50afb
      Peter Penz authored
      When downloading a large file the preview should not be recreated each time
      a change-notification has been received. Create the preview after getting
      the first file change, but postpone creating the next previews until no change
      has been done during a longer period of time.
      
      BUG: 290698
      FIXED-IN: 4.8.0
      5ce50afb
    • Peter Penz's avatar
      Prevent generating previews all the time during downloading a large file · 0829313c
      Peter Penz authored
      When downloading a large file the preview should not be recreated each time
      a change-notification has been received. Create the preview after getting
      the first file change, but postpone creating the next previews until no change
      has been done during a longer period of time.
      
      BUG: 290698
      FIXED-IN: 4.8.0
      0829313c