Commit 34d0ad72 authored by Frank Reininghaus's avatar Frank Reininghaus

Comment out assertion to fix a crash when filtering in Icons/Compat View

I'm not sure yet if there is a problem somewhere else in the code. For
the time being, I think it's better to replace the assert by a TODO
comment to prevent that users find out the hard way that there is
something that we're not quite sure about.

BUG: 317827
FIXED-IN: 4.10.3
parent 52a38ee9
......@@ -1147,7 +1147,10 @@ void KItemListView::slotItemsRemoved(const KItemRangeList& itemRanges)
// Important: Don't read any m_layouter-property inside the for-loop in case if
// multiple ranges are given! m_layouter accesses m_sizeHintResolver which is
// updated in each loop-cycle and has only a consistent state after the loop.
Q_ASSERT(m_layouter->isDirty());
// TODO: This assert can be hit when filtering in Icons and Compact view,
// see https://bugs.kde.org/show_bug.cgi?id=317827 comments 2 and 3.
// We should try to figure out if the assert is wrong or if there is a bug in the code.
//Q_ASSERT(m_layouter->isDirty());
#endif
m_endTransactionAnimationHint = NoAnimation;
endTransaction();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment