Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Open sidebar
Unmaintained
KDE Libraries
Commits
c89a9d3d
Commit
c89a9d3d
authored
Dec 20, 2014
by
Andrea Iacovitti
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Unneeded DOMString->QString conversion and check.
parent
8f85b26d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
6 deletions
+3
-6
khtml/html/html_formimpl.cpp
khtml/html/html_formimpl.cpp
+2
-5
khtml/rendering/render_form.cpp
khtml/rendering/render_form.cpp
+1
-1
No files found.
khtml/html/html_formimpl.cpp
View file @
c89a9d3d
...
...
@@ -2518,10 +2518,7 @@ bool HTMLSelectElementImpl::encoding(const QTextCodec* codec, khtml::encodingLis
(
items
[
0
]
->
id
()
==
ID_OPTION
&&
!
items
[
0
]
->
disabled
())
)
{
HTMLOptionElementImpl
*
const
option
=
static_cast
<
HTMLOptionElementImpl
*>
(
items
[
0
]);
encoded_values
+=
enc_name
;
if
(
option
->
value
().
isNull
())
encoded_values
+=
fixUpfromUnicode
(
codec
,
option
->
text
().
string
());
else
encoded_values
+=
fixUpfromUnicode
(
codec
,
option
->
value
().
string
());
encoded_values
+=
fixUpfromUnicode
(
codec
,
option
->
value
().
string
());
successful
=
true
;
}
...
...
@@ -2801,7 +2798,7 @@ DOMString HTMLOptionElementImpl::value() const
if
(
!
m_value
.
isNull
()
)
return
m_value
;
// Use the text if the value wasn't set.
return
text
()
.
string
()
;
return
text
();
}
void
HTMLOptionElementImpl
::
setValue
(
DOMStringImpl
*
value
)
...
...
khtml/rendering/render_form.cpp
View file @
c89a9d3d
...
...
@@ -1856,7 +1856,7 @@ void RenderSelect::updateFromElement()
// Prefer label if set
DOMString
label
=
optElem
->
getAttribute
(
ATTR_LABEL
);
if
(
!
label
.
isEmpty
())
domText
=
label
.
string
()
;
domText
=
label
;
domText
=
domText
.
implementation
()
->
collapseWhiteSpace
(
false
,
false
);
QString
text
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment