GitLab

Konqueror's about page doesn't show icons if the breeze icon theme is
used.
The reason is that khtml doesn't support SVG images.
This patch is supposed to fix it by allowing to use Qt's support in that
case.

This is a backport of commit ed5c039f2d1996545b95a24e9bff4264144f9f6d
in khtml

FIXED-IN: 4.14.35
CCBUG: 355872

GIT_SILENT

GIT_SILENT

CVE-2017-8422

GIT_SILENT

BUG: 373323

Backport from KF5 kio

GIT_SILENT

Fixup to commit 947ffe60 ("backport 02c3192 - Patch some memory leaks"),
which backported part of the fix in the wrong order, as it was first
returning and then deleting a pointer.

Noticed by Matthew Rezny <rezny@FreeBSD.org>.

GIT_SILENT

Remove user/password information
For https: remove path and query

Backport from kio f9d0cb47cf94e209f6171ac0e8d774e68156a6e4

This fixes building with GCC 7 which fails with
"ISO C++ forbids comparison between pointer and integer [-fpermissive]"

GIT_SILENT

GIT_SILENT

GIT_SILENT

This makes sure the reply from the user is used and sent back.

Fixes commit b68911a6.

(manual backport of commit 856a96852f566ed7eb855810e347f95003c25017 and
commit bd4be07823e422fa15bf4273e0bb9df35b866e35 from khtml)

GIT_SILENT

Backported from e2a6886 in kitemmodels.

If the row being removed from the source model isn't shown by KRFPM,
it's correct that we don't need to emit any signals, however we still
need to tell our base class QSFPM so that it updates the mappings
of the visible siblings below that removed row.

Testcase: deleting the Last Search folder in kmail
(full integration test for this testcase will be added to mailcommon).

REVIEW: 128428
CCBUG: 349789

Programs using KFileDialog's setConfirmOverwrite(true) (e.g. LibreOffice with KDE4 integration, Mozilla products with KDE4 integration, several components of the PIM suite) will trigger the following strange behaviour:
If the file name in the save file dialog is empty and the user selects "Save", the dialog will ask if you want to overwrite the current directory (instead of just ignoring the empty input).

By moving the query below the directory checks the order is correct again, showing the overwrite confirmation dialog only if the field contains a unique filename.

Looking at the code this also affects Frameworks 5 / kio, though I haven't tested it yet.

Acked by dfaure

REVIEW: 120127

RFC3986 defines the following syntax for URI schemes
scheme = alpha *( alpha | digit | "+" | "-" | "." )

The '.' was missing which leaded to the problem that
xdg-open opc.tcp://localhost didn't work.

Background:
xdg-open calls kde-open which then uses KUrl and so leaded to this
problem. Of course this bug may affect also many other locations
using KUrl::isRelativeUrl.

This fix also adds a unit test to test the fix and avoid future
regressions.

Acked by dfaure

REVIEW: 129208

REVIEW: 128600

On newer distros the check fails because trunc is ambiguous, so tell sizeof exactly which trunc we're speaking about.

REVIEW: 129119

Commit dadacaf995170f44e6d392fce2c3f6c7e4967989

Sorry ^_^

GIT_SILENT

Without this I get

CMakeFiles/KF5Codecs.dir/kcharsets.cpp.o: In function KCharsets::fromEntity(QString const&)': kcharsets.cpp:(.text+0x5cf): undefined reference tokde_findEntity'

Use gperf C++ generated code instead of C

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41194 for more info

REVIEW: 128750

Now that kde-workspace is obsolete and kdelibs is only used by some still unported applications, it doesn't make sense to force using strigi
anymore. This will allow dropping this old unmaintained library from distributions.

REVIEW: 127823

GIT_SILENT

REVIEW: 128749

Provide also empty implementations of the two methods preferredGroups()
and supportedGroups() of the KFileMetaInfo class, otherwise they are
left unimplemented when building kdelibs without strigi.

Clearly the author of this regexp, in 2006, thought gcc would never
hit version 6 :-)

REVIEW: 128697

GIT_SILENT