Commit e9b1714f authored by Frank Reininghaus's avatar Frank Reininghaus

Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

This makes crashes like the one I'm closing with this report impossible,
even though the root cause might be somehing else, possibly related to
Qt and particular settings of certain styles.

In any case, that class does not need anything from QWidget any more, so
this change would make sense even without the crash.

Thanks to Aurelién Gâteau and David Faure, both for coming up with the
idea to fix it this way in the first place and for explaining why
deriving the class from QWidget did make sense in the past.

BUG: 303169
FIXED-IN: 4.9.1
REVIEW: 105920
parent ee4cad3e
......@@ -38,7 +38,7 @@
* the different supported platforms.
* @internal
class KModifierKeyInfoProvider : public QWidget
class KModifierKeyInfoProvider : public QObject
......@@ -101,7 +101,7 @@ bool KModifierKeyInfoProvider::s_eventFilterEnabled = false;
QAbstractEventDispatcher::EventFilter KModifierKeyInfoProvider::s_nextFilter = 0;
: QWidget(0)
: QObject(0)
int code, xkberr, maj, min;
m_xkbAvailable = XkbQueryExtension(QX11Info::display(), &code, &m_xkbEv, &xkberr, &maj, &min);
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment