Commit 210c12d5 authored by Laurent Montel's avatar Laurent Montel 😁

Create for the moment external apps when we want to open new tab. Need to...

Create for the moment external apps when we want to open new tab. Need to improve how we open new tab
parent 2e19b14a
......@@ -91,6 +91,10 @@ QWebEngineView *ArticleViewerWebEngine::createWindow(QWebEnginePage::WebWindowTy
{
qDebug()<<" QWebEngineView *ArticleViewerWebEngine::createWindow(QWebEnginePage::WebWindowType type) not implemented yet" << type;
switch (type) {
//For the moment create external windows.
case QWebEnginePage::WebDialog:
//TODO add in tab
case QWebEnginePage::WebBrowserTab:
case QWebEnginePage::WebBrowserWindow: {
if (!Settings::newWindowInTab()) {
WebEngineViewer::WebEngineView *view = new WebEngineViewer::WebEngineView();
......@@ -99,13 +103,10 @@ QWebEngineView *ArticleViewerWebEngine::createWindow(QWebEnginePage::WebWindowTy
return view;
}
}
case QWebEnginePage::WebDialog:
//TODO add in tab
case QWebEnginePage::WebBrowserTab:
default:
break;
}
return Q_NULLPTR;
return QWebEngineView::createWindow(type);
}
QVariantHash ArticleViewerWebEngine::introductionData() const
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment