GitLab

Probably some OTP refactoring broke displaying of ITIP invitation.
This patch fixes the problem. It may not fix the root cause of the
problem, but at least it makes ITIP invitations work again.

What happens is that OTP::parseObjectTreeInternal() first calls
Formatter::format() without the asyncResultObserver. Without this
patch it still creates the new memento, but does not connect it to
the observer. Then OTP calls the Formatter again immediatelly after,
but this time with a valid asyncResultObserver. Because the memento
already exists, this only triggers the codepath that checks whether
the memento is finished (which it is not) and exists. When the memento
is finished nothing happens, because it wasn't initially connected
to the observer to force update of the Viewer.

With this patch we don't create the memento if there is no
asyncResultObserver. That means that the next time the Formatter is
called with a valid asyncResultObserver we create the memento and
connect it to the observer. Once the memento is finished, the Viewer
is updated and the invitation is displayed correctly.

Differential Revision: https://phabricator.kde.org/D1512

I stopped maintaining korg a long time ago

Neither is Allen though.
CCMAIL: winter@kde.org

FIXED-IN:5.2.1
BUG: 362471

FIXED-IN: 5.2.1
BUG: 362368

FIXED-IN: 5.2.1
BUG: 362152

(we need to change css too with grantlee)

FIXED-IN: 5.2.1
BUG: 362220

CCBUG: 362152
(still a bug as it doesn't want to change font/size when we change it from settings)

CCBUG: 362152

FIXED-IN: 5.2.1
BUG: 361605

Possible fix for bugs 361539, 361717.

After adding a new calendar, the calendar list showed two entries
for the new calendar, one labelled "akonadi_kalarm_resource_*" and
with invalid details.

BUG: 361543