Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Unmaintained
Rekonq
Commits
fba0b940
Commit
fba0b940
authored
Mar 27, 2011
by
Andrea Diamantini
Browse files
Untrack the bookmarks menu list and set a parent to automagically
delete it as object child CCBUG:269490
parent
fc7f946a
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/bookmarks/bookmarkprovider.cpp
View file @
fba0b940
...
...
@@ -49,10 +49,10 @@
BookmarkProvider
::
BookmarkProvider
(
QObject
*
parent
)
:
QObject
(
parent
)
,
m_manager
(
0
)
,
m_owner
(
0
)
,
m_actionCollection
(
new
KActionCollection
(
this
))
:
QObject
(
parent
)
,
m_manager
(
0
)
,
m_owner
(
0
)
,
m_actionCollection
(
new
KActionCollection
(
this
))
{
// NOTE
// This hackish code is needed to continue sharing bookmarks with konqueror,
...
...
@@ -95,7 +95,6 @@ BookmarkProvider::BookmarkProvider(QObject *parent)
BookmarkProvider
::~
BookmarkProvider
()
{
qDeleteAll
(
m_bookmarkMenus
);
delete
m_manager
;
}
...
...
@@ -109,8 +108,8 @@ KActionMenu* BookmarkProvider::bookmarkActionMenu(QWidget *parent)
bookmarkActionMenu
->
setMenu
(
menu
);
bookmarkActionMenu
->
setText
(
i18n
(
"&Bookmarks"
));
BookmarkMenu
*
bMenu
=
new
BookmarkMenu
(
m_manager
,
m_owner
,
menu
,
m_actionCollection
);
m_bookmarkMenus
.
append
(
bM
enu
);
bMenu
->
setParent
(
m
enu
);
return
bookmarkActionMenu
;
}
...
...
@@ -219,8 +218,8 @@ void BookmarkProvider::fillBookmarkBar(BookmarkToolBar *toolBar)
KBookmarkActionMenu
*
menuAction
=
new
KBookmarkActionMenu
(
bookmark
.
toGroup
(),
this
);
menuAction
->
setDelayed
(
false
);
BookmarkMenu
*
bMenu
=
new
BookmarkMenu
(
bookmarkManager
(),
bookmarkOwner
(),
menuAction
->
menu
(),
bookmark
.
address
());
m_bookmarkMenus
.
append
(
bMenu
);
bMenu
->
setParent
(
menuAction
->
menu
()
);
connect
(
menuAction
->
menu
(),
SIGNAL
(
aboutToShow
()),
toolBar
,
SLOT
(
menuDisplayed
()));
connect
(
menuAction
->
menu
(),
SIGNAL
(
aboutToHide
()),
toolBar
,
SLOT
(
menuHidden
()));
...
...
src/bookmarks/bookmarkprovider.h
View file @
fba0b940
...
...
@@ -150,7 +150,6 @@ private:
KActionCollection
*
m_actionCollection
;
QList
<
BookmarkToolBar
*>
m_bookmarkToolBars
;
QList
<
BookmarksPanel
*>
m_bookmarkPanels
;
QList
<
BookmarkMenu
*>
m_bookmarkMenus
;
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment