Commit 02d26d42 authored by Elvis Angelaccio's avatar Elvis Angelaccio
Browse files

part: connect to KJob::finished instead of result when registering jobs

The Part used to emit the signal ready upon receiving the KJob::result signal,
on jobs completion.

After commit a537c5ee, the Part would not receive anymore this signal after
killing a ListJob. According to the KJob docs, this is probably due
to a change in the event loop behavior (due to CliInterface now being in the main
thread) which cause the job to be deleted before than expected.

The finished signal is always guaranteed to be emitted (upon
jobs destruction), so it makes sense to use it instead, in this specific case.

Task: T2225
parent d508d8fe
......@@ -197,7 +197,7 @@ void Part::registerJob(KJob* job)
emit busy();
connect(job, &KJob::result, this, &Part::ready);
connect(job, &KJob::finished, this, &Part::ready);
// TODO: KIO::mostLocalHere is used here to resolve some KIO URLs to local
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment