Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Utilities
Ark
Commits
68f9dadb
Commit
68f9dadb
authored
Aug 30, 2020
by
Elvis Angelaccio
Browse files
libzip: drop redundant get() calls
unique_ptr has an `operator bool`, so they are not needed.
parent
bcc40c12
Changes
1
Hide whitespace changes
Inline
Side-by-side
plugins/libzipplugin/libzipplugin.cpp
View file @
68f9dadb
...
...
@@ -675,9 +675,9 @@ bool LibzipPlugin::extractEntry(zip_t *archive, const QString &entry, const QStr
// Handle password-protected files.
std
::
unique_ptr
<
zip_file
,
decltype
(
&
zip_fclose
)
>
zipFile
{
nullptr
,
&
zip_fclose
};
bool
firstTry
=
true
;
while
(
!
zipFile
.
get
()
)
{
while
(
!
zipFile
)
{
zipFile
.
reset
(
zip_fopen
(
archive
,
entry
.
toUtf8
().
constData
(),
0
));
if
(
zipFile
.
get
()
)
{
if
(
zipFile
)
{
break
;
}
else
if
(
zip_error_code_zip
(
zip_get_error
(
archive
))
==
ZIP_ER_NOPASSWD
||
zip_error_code_zip
(
zip_get_error
(
archive
))
==
ZIP_ER_WRONGPASSWD
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment