Commit 765ba237 authored by David Edmundson's avatar David Edmundson
Browse files

Cleaup AddJob on destruction

In a recent patch m_addJob was cleaned up correctly. The code throughout
already checked pointer validity, but at no point was this reset.

This meant a queued task would then hit a dangling pointer.

BUG: 442774
parent c31afbce
Pipeline #91638 passed with stage
in 2 minutes and 35 seconds
......@@ -39,6 +39,7 @@
#include <QElapsedTimer>
#include <QTemporaryDir>
#include <QPointer>
namespace Kerfuffle
{
......@@ -215,7 +216,7 @@ protected:
bool doKill() override;
private:
AddJob *m_addJob = nullptr;
QPointer<AddJob> m_addJob;
QVector<Archive::Entry*> m_entries;
CompressionOptions m_options;
};
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment