Commit bec033a9 authored by Nate Graham's avatar Nate Graham
Browse files

Clarify selection-scope Open actions

Ark currently has two "Open" actions: one is global-scope (open a new
archive file) while the other is selection-scope (open the selected file
in an external program). They both have identical text and icons, and
are disambiguated only by their tooltips and locations in the menu
structure. However this does not help when the action is added to the
toolbar, as it is by default. In this circumstance, its purpose is very
unclear as it has the same name and icon as a typical "Open a new file"
action, but it doesn't open a new file.

To clarify the situation, this commit makes the following changes to the
selection-scope open actions:
1. Use longer text that explains what the action will do, and delete the
   special tooltip text
2. Use the document-export icon, which uses the more appropriate visual
   metaphor of "get the document out of this app".
parent 2369716a
Pipeline #219123 passed with stage
in 1 minute and 22 seconds
......@@ -370,14 +370,13 @@ void Part::setupActions()
actionCollection()->addAction(QStringLiteral("ark_file_save_as"), m_saveAsAction);
m_openFileAction = actionCollection()->addAction(QStringLiteral("openfile"));
m_openFileAction->setText(i18nc("open a file with external program", "&Open"));
m_openFileAction->setIcon(QIcon::fromTheme(QStringLiteral("document-open")));
m_openFileAction->setToolTip(i18nc("@info:tooltip", "Click to open the selected file with the associated application"));
m_openFileAction->setText(i18nc("open a file with external program", "&Open in External Application"));
m_openFileAction->setIcon(QIcon::fromTheme(QStringLiteral("document-export")));
connect(m_openFileAction, &QAction::triggered, this, [this]() { slotOpenEntry(OpenFile); });
m_openFileWithAction = actionCollection()->addAction(QStringLiteral("openfilewith"));
m_openFileWithAction->setText(i18nc("open a file with external program", "Open &With..."));
m_openFileWithAction->setIcon(QIcon::fromTheme(QStringLiteral("document-open")));
m_openFileWithAction->setIcon(QIcon::fromTheme(QStringLiteral("document-export")));
m_openFileWithAction->setToolTip(i18nc("@info:tooltip", "Click to open the selected file with an external program"));
connect(m_openFileWithAction, &QAction::triggered, this, [this]() { slotOpenEntry(OpenFileWith); });
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment