From ead7a07ee145d41d3f3c737b93862c6ef0c067be Mon Sep 17 00:00:00 2001 From: Elvis Angelaccio Date: Tue, 19 Jul 2016 22:36:00 +0200 Subject: [PATCH] Drop direct connection for finished signal The direct connection was added in commit acb455da04, but since Ark 16.08 is not necessary anymore (CliInterface runs on the main thread). This prevents a possible race condition in our jobs (see https://git.reviewboard.kde.org/r/128113/) CCBUG: 193908 Differential Revision: D2225 --- kerfuffle/jobs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kerfuffle/jobs.cpp b/kerfuffle/jobs.cpp index c14e5142..d0f82551 100644 --- a/kerfuffle/jobs.cpp +++ b/kerfuffle/jobs.cpp @@ -132,7 +132,7 @@ void Job::connectToArchiveInterfaceSignals() connect(archiveInterface(), &ReadOnlyArchiveInterface::entryRemoved, this, &Job::onEntryRemoved); connect(archiveInterface(), &ReadOnlyArchiveInterface::progress, this, &Job::onProgress); connect(archiveInterface(), &ReadOnlyArchiveInterface::info, this, &Job::onInfo); - connect(archiveInterface(), &ReadOnlyArchiveInterface::finished, this, &Job::onFinished, Qt::DirectConnection); + connect(archiveInterface(), &ReadOnlyArchiveInterface::finished, this, &Job::onFinished); connect(archiveInterface(), &ReadOnlyArchiveInterface::userQuery, this, &Job::onUserQuery); } -- GitLab