Commit eeee61d2 authored by Ragnar Thomsen's avatar Ragnar Thomsen
Browse files

Forward errors from archive interface when batch-extracting

Errors from ExtractJob are not handled when called as a subjob of
BatchExtractJob. This can result in silently failing extractions.

CCBUG: 387996
Differential Revision: D28721
parent ec320540
......@@ -411,6 +411,7 @@ void BatchExtractJob::slotLoadingFinished(KJob *job)
if (m_extractJob) {
connect(m_extractJob, &KJob::result, this, &BatchExtractJob::emitResult);
connect(m_extractJob, &Kerfuffle::Job::userQuery, this, &BatchExtractJob::userQuery);
connect(archiveInterface(), &ReadOnlyArchiveInterface::error, this, &BatchExtractJob::onError);
if (archiveInterface()->hasBatchExtractionProgress()) {
// The LoadJob is done, change slot and start setting the percentage from m_lastPercentage on.
disconnect(archiveInterface(), &ReadOnlyArchiveInterface::progress, this, &BatchExtractJob::slotLoadingProgress);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment