1. 09 Jun, 2016 1 commit
    • Elvis Angelaccio's avatar
      Fix crash with blocking Open dialog · 0d16e7d0
      Elvis Angelaccio authored
      `QDialog::exec()` is bad and should not be used unless strictly necessary.
      The exec() call is blocking and anything can happen before it returns to the caller.
      The old workaround is to use a `QPointer` to guard the dialog.
      Yet there is a crash when calling `QCoreApplication::quit()` via dbus while the dialog is open.
      The proper fix is to call the dialog in a non-blocking way. Nowadays this is trivial thanks to C++11 lambdas.
      Differential Revision: D1786
  2. 26 Apr, 2016 1 commit
  3. 21 Apr, 2016 1 commit
  4. 16 Mar, 2016 1 commit
    • Ragnar Thomsen's avatar
      Improve handling of supported mimetypes · 01fd1abe
      Ragnar Thomsen authored
      Move mimetype-handling functions from archive-kerfuffle.cpp to own file
      In MainWindow::openArchive() set filter using
      QFileDialog::setMimeTypeFilters() instead of using
      QFileDialog::setNameFilters(). This fixes sorting of filters in the
      "Open Archive" dialog with KF 5.20.0. Frameworkintegration 5.20.0 broke
      the old sorting with commit 415ad2ed48356c3065c937813888fa1bd2742789.
      Now we get the "All Supported Files" filter automatically.
      Differential Revision: D1144
  5. 14 Mar, 2016 1 commit
    • Elvis Angelaccio's avatar
      Hide status bar on idle · 0f539042
      Elvis Angelaccio authored
      The Ark status bar is useful only during jobs, when showing the job's
      progress bar. With this patch we show the status bar only during a job, saving screen
      space otherwise.
      This patch also removes the "Show Statusbar" checkbox from the Settings
      menu, which does not make sense anymore to have.
      Differential Revision: D1141
  6. 11 Mar, 2016 1 commit
    • Ragnar Thomsen's avatar
      Add support for lzipped tar-archives · dea04e27
      Ragnar Thomsen authored
      Support for lzipped tar-archives was enabled in the libarchiveplugin.
      Libarchive creates tar.lz archives. However, the lzip format only has a
      mimetype for single-compressed file (application/x-lzip) and not for
      tar.lz archives. Due to this limitation, a rewrite of CreateDialog was
      needed to be able to modify mimetypes in the filter combobox.
      BUG: 209418
      FIXED-IN: 16.04.0
      Differential Revision: D1098
  7. 27 Feb, 2016 1 commit
  8. 24 Feb, 2016 1 commit
  9. 14 Jan, 2016 1 commit
    • Elvis Angelaccio's avatar
      Rename the File menu as Archive menu · 7f83b412
      Elvis Angelaccio authored
      Since an archive is a file that contains other files, the current Ark menu
      structure can be confusing. The File menu currently contains actions regarding the
      archive, while the Action menu contains actions regarding the files within the
      This patch renames the File menu as Archive menu, to reduce this ambiguity.
      Task: T915
      Differential Revision: D788
  10. 31 Oct, 2015 1 commit
  11. 27 Oct, 2015 1 commit
  12. 15 Oct, 2015 1 commit
    • Ragnar Thomsen's avatar
      Use ecm_qt_declare_logging_category() cmake macro · 5e04e640
      Ragnar Thomsen authored
      This macro was introduced in ECM 5.14.0 and generates logging category
      declarations. This removes the necessity of Q_LOGGING_CATEGORY calls in
      cpp files. A header with Q_DECLARE_LOGGING_CATEGORY is automatically
      generated, so the old logging.h file can be removed.
      Also the identifier is now ARK everywhere, so all qCDebug() should be
      This bumps the required dep version for ECM to 5.14.0.
  13. 18 Sep, 2015 1 commit
  14. 08 Sep, 2015 1 commit
  15. 22 Aug, 2015 3 commits
  16. 09 Aug, 2015 1 commit
  17. 26 Jul, 2015 1 commit
    • Elvis Angelaccio's avatar
      Fix too noisy debug · a08b961e
      Elvis Angelaccio authored
      This should have been performed by commit 402bbe84, since the mimetypes are now
      handled by the CreateDialog and therefore there is no reason to call (and send
      to debug twice) Kerfuffle::supportedWriteMimeTypes() here.
  18. 22 Jul, 2015 2 commits
    • Elvis Angelaccio's avatar
      Create password-protected archives with Ark · 402bbe84
      Elvis Angelaccio authored
      This feature allows Ark to create a password-protected archive from
      The 7z and rar plugins support both header encryption and entries-only
      encryption, while the zip one supports only the latter.
      An encrypted archive can be created through the CreateDialog (within Ark) or
      through the AddDialog (from e.g. Dolphin).
      REVIEW: 120204
      FEATURE: 253694
      FIXED-IN: 15.08
    • Elvis Angelaccio's avatar
      Implement configuration dialog · 7850a0aa
      Elvis Angelaccio authored
      This patch implements the standard configuration dialog (using
      KConfigDialog) in Ark, as expected from a KDE application.
      The widgets showed in the config dialog are provided by Kerfuffle, through the
      Ark Part interface. This should help to show the Ark settings in, for
      instance, Konqueror's config dialog.
      REVIEW: 121997
      BUG: 165314
      FIXED-IN: 15.08
  19. 12 Jul, 2015 3 commits
  20. 19 May, 2015 3 commits
  21. 18 May, 2015 4 commits
  22. 17 May, 2015 1 commit
  23. 15 May, 2015 1 commit
  24. 10 Dec, 2014 1 commit
    • Jan Grulich's avatar
      Rename archive.h to archive_kerfuffle.h · 00821257
      Jan Grulich authored
      This fixes build of libarchiveplugin, where we need to compile against libarchive, but including <archive.h> always
      found kerfuffle/archive.h and there is no way how to force using /usr/include/archive.h instead.
      Reviewed-by: Lukáš Tinkl
  25. 23 Nov, 2014 1 commit
    • Raphael Kubo da Costa's avatar
      Stop crashing on exit when being used solely as a KPart. · 9c30f30b
      Raphael Kubo da Costa authored
      This change fixes a crash introduced by commit 3b981ca9 ("Remove Part
      from KXMLGUIFactory on exit").
      Part::~Part() is the wrong place to call KXMLGUIFactory::removeClient(),
      as it assumes addClient() had been called in the first place.
      This is only true if Ark is called as a standalone program, since that
      is done in MainWindow::loadPart()'s call to KXMLGuiWindow::createGUI().
      Conversely, if the Ark KPart is being used as an embedded viewer in,
      say, Konqueror or to preview an archive inside an archive (ie. Ark
      inside Ark) that does not hold true and we try to access a
      KXMLGUIFactory that does not exist.
      Instead, call KXMLGuiWindow::removeClient() in MainWindow's destructor,
      since in this case we are certain that addClient() was been called
      BUG:      341187
      FIXED-IN: 14.12
  26. 30 Oct, 2014 1 commit
  27. 15 Oct, 2014 1 commit
  28. 14 Oct, 2014 1 commit
  29. 08 Oct, 2014 1 commit
  30. 19 Sep, 2014 1 commit