1. 14 Feb, 2021 1 commit
  2. 09 Dec, 2020 1 commit
  3. 26 Nov, 2020 1 commit
    • Friedrich W. H. Kossebau's avatar
      Ark KPart: restore mismatch of componentname and plugin id · 4c8546dc
      Friedrich W. H. Kossebau authored
      By history Ark stores the xmlgui ui.rc file for the part in the same
      subdir as the program, ark/. And set the comppnent name as needed to "ark"
      via the KAboutData instance for the KPart.
      At the same time the plugin id has been "arkpart", as derived from the
      library name due to the absence of an explicit X-KDE-PluginInfo-Name entry
      in the desktop file.
      
      With the change to the KPluginMetaData API of KParts/KPluginLoader and
      the new entries added to the desltop file based on the KAboutData values,
      that mismatch was resolved by accident. With "ark" now also the plugin id,
      the look up the kpart by the program though now fails, due to the condition
          metaData.pluginId() == QLatin1String("arkpart")
      
      BUG: 429616
      4c8546dc
  4. 17 Nov, 2020 1 commit
  5. 27 Sep, 2020 1 commit
  6. 26 Sep, 2020 1 commit
  7. 25 Sep, 2020 1 commit
  8. 26 Aug, 2020 2 commits
    • Ahmad Samir's avatar
      Part: more async KIO jobs · eff5cd0b
      Ahmad Samir authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Add comment explaining what extractSelectedFilesTo is used for.
      Slightly tweak error message.
      eff5cd0b
    • Ahmad Samir's avatar
      Part: QFileDialog asks to overwrite a file on its own · 54ba94ec
      Ahmad Samir authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      - No need to stat the url we get from QFileDialog::getSaveFileUrl, if it
        already exists the dialog should show the "do you want to overwrite?"
        message to the user on its own; also no need to check for isValid, the
        dialog will return valid urls, AFAICS
      - KIO::file_copy will check if the src url exists ...etc, we don't have
        to do that manually; also make the job async, and re-use the custom error
        messages where possible
      54ba94ec
  9. 21 Aug, 2020 1 commit
    • Ahmad Samir's avatar
      Port KRun to OpenUrlJob and ApplicationLauncherJob · c4c765a9
      Ahmad Samir authored and David Faure's avatar David Faure committed
      In BatchExtract, use QUrl::fromLocalFile to construct a url with the
      file:// scheme, so that the destination dir can be opened after the
      extraction is finished.
      
      Bump minimum KF version to 5.71 as that's where OpenUrlJob was introduced.
      c4c765a9
  10. 31 Jul, 2020 1 commit
  11. 14 Mar, 2020 1 commit
    • Nicolas Fella's avatar
      Lazily load file entry icons · 2c684ecd
      Nicolas Fella authored
      Summary:
      Building the icons datastructure is the most significant bottleneck when opening large archives. Knowing all the icons at loading time is unnecessary since most elements won't be visible anyway.
      This patch moves the icon storing into the Entry class where it is lazily determined the first time it is accessed. This improves the initial archive loading time significantly.
      
      Test Plan: It's hard to give exact numbers, but my main test archive (the Android NDK) went from ~3 seconds to load to "pretty much instant"
      
      Reviewers: #ark, elvisangelaccio
      
      Reviewed By: #ark, elvisangelaccio
      
      Subscribers: broulik, kde-utils-devel
      
      Tags: #ark
      
      Differential Revision: https://phabricator.kde.org/D26357
      2c684ecd
  12. 23 Nov, 2019 1 commit
  13. 30 Sep, 2019 1 commit
    • Nate Graham's avatar
      Improve consistency of settings window sidebar categories' text and icons · 2a772e69
      Nate Graham authored
      Summary:
      This is in support of the initiative to make settings' window sidebar categories
      consistent throughout KDE software by doing the following:
      - Remove the word "Settings" from the category names (this is implicit, and not done in other KDE software)
      - Use the app's own icon for the General category
      - Use all colorful icons
      
      Test Plan:
      Before: {F7449535}
      After: {F7449536}
      
      Reviewers: #vdg, #ark, elvisangelaccio
      
      Reviewed By: #ark, elvisangelaccio
      
      Subscribers: kde-utils-devel
      
      Tags: #ark
      
      Maniphest Tasks: T10165
      
      Differential Revision: https://phabricator.kde.org/D24270
      2a772e69
  14. 04 Sep, 2019 1 commit
  15. 02 Jun, 2019 2 commits
  16. 01 Jun, 2019 1 commit
  17. 06 Nov, 2018 2 commits
  18. 05 Sep, 2018 1 commit
  19. 22 Jul, 2018 1 commit
    • Elvis Angelaccio's avatar
      Don't show comment message widget after clearing the comment view · 31b5501b
      Elvis Angelaccio authored
      The comment message widget is supposed to be visible after the user
      edits an existing comment. However the current logic makes it visible
      even after opening two archives with a comment in a row:
      
      1. The first time the message widget is hidden as expected, because it
         was explicitly hidden in the Part ctor and `m_commentBox->show()` in
         `slotShowComment()` still leaves it hidden.
      
      2. The second time, the message widget is breafly shown is
         `slotCommentChanged()` because `m_commentView->toPlainText()` is empty
         (it gets cleared before opening the second archive). The message
         widgets stays visibile because it's not hidden anywhere else.
      
      This patch fixes the issue by preventing that the message widget gets shown
      *without reason* in the first place.
      31b5501b
  20. 17 Jul, 2018 1 commit
    • Elvis Angelaccio's avatar
      Stop ignoring compression options when dropping files · 20c6faa5
      Elvis Angelaccio authored
      Compression options set by CreateDialog were only taken into account
      when adding files through the AddDialog, but not when adding files by
      dropping them from Dolphin.
      
      We fix this issue by moving the init of compression options in a new
      dedicated function, which we can call also when dropping files.
      
      While at it, this change allows us to simplify the `droppedFiles()`
      signal emitted by ArchiveModel.
      
      BUG: 396579
      FIXED-IN: 18.07.80
      20c6faa5
  21. 02 Jul, 2018 1 commit
  22. 11 Mar, 2018 1 commit
  23. 04 Jan, 2018 1 commit
  24. 16 Oct, 2017 1 commit
    • Elvis Angelaccio's avatar
      Use KIO jobtracker from Part · 5ee79a80
      Elvis Angelaccio authored
      It is confusing to have a jobtracker call another jobtracker.
      They are both implementing the same interface in different ways, so
      don't mix them but rather use both from `Part::registerJob()`.
      
      Differential Revision: D8323
      5ee79a80
  25. 21 Aug, 2017 5 commits
  26. 18 Aug, 2017 2 commits
  27. 16 Aug, 2017 1 commit
    • Elvis Angelaccio's avatar
      part: update window title whenever the URL changes · 518350c9
      Elvis Angelaccio authored
      This fixes a small regression in commit 20c09f3c.
      A ReadOnlyPart emits `completed()` if `openUrl()` returns true, so we
      lost a call to `setFileNameFromArchive()`.
      We fix that by connecting this slot to the `urlChanged()` signal.
      
      Tested by opening some archive and then an header-encrypted archive, and
      making sure the window title had the name of the second archive while the
      password dialog was open.
      518350c9
  28. 12 Aug, 2017 2 commits
  29. 07 Aug, 2017 1 commit
  30. 31 Jul, 2017 1 commit
    • Elvis Angelaccio's avatar
      mainwindow: don't steal drops for the part · 194cd3fe
      Elvis Angelaccio authored
      The main window should accept drops only if the part cannot.
      
      To make sure that the part URL will be empty after a failed loading
      (e.g. dropping a text file onto an empty ark window), we clear the URL
      in Part::slotLoadingFinished() if the job has an error.
      194cd3fe
  31. 23 Jul, 2017 1 commit
    • Elvis Angelaccio's avatar
      Don't add invalid URLs to the recent files · 20c09f3c
      Elvis Angelaccio authored
      Part::openFile() used to return false if the URL of the part was not a
      valid archive. This is no longer the case as nowadays we run an async
      LoadJob. So MainWindow cannot use the return value of openFile() to
      choose whether to add the URL to the recent files. Instead, we connect
      to the part's completed() signal which is emitted only if the LoadJob
      ends without errors.
      20c09f3c