GitLab

Two variables were added to ReadOnlyArchiveInterface: A boolean
describing whether the archive is multi-volume and an int used for
storing number of volumes. Two corresponding Q_PROPERTY's were added to
Archive which fetch the info from ReadOnlyArchiveInterface.

The detection of multi-volume archives was fixed in cli7z.

The information is displayed in PropertiesDialog and will be used when
implementing support for creating multi-volume archives.

GUI:

This diff implements an AddDialog class that is used instead of
QFileDialogs for adding files/folders to an archive. Now both folders
and files are added to an archive with a single action in Part, instead
of two separate actions (Add File/Add Folder).

AddDialog has a button which opens a new dialog that allows setting
advanced compression settings (currently only compression level). Since
compression options are used both when creating a new archive and adding
files to an existing archive, a new class called
CompressionOptionsWidget was created which is used by both AddDialog and
CreateDialog.

Differential Revision: D2120
GUI:

Every time we do a 'make install' we also update the mime database (because we
install mimetypes) and this causes the ksycoca file to be regenerated the
next time we run Ark (because we load the Part using KService).

This is annoying and clutters the console output with ksycoca messages. We can use instead the new
json loading mechanism like we already do with our plugins.

Regarding ark_part.desktop, we continue to install it because Konqueror is
probably using it.

Differential Revision: D2140

This workarounds a git limitation that doesn't allow us to add an empty
directory in the repository.

Check for correct number of added folders. Add tests for empty subdirs
and folders with multiple level of subfolders.

Also test the RAR format, even though we currently dont provide a
"Compress Here (as RAR)" action in the service menu.

The number of folders is now also shown in PropertiesDialog. There was a
bug where number of files/folders and total uncompressed size didn't get
updated after adding/deleting files from archive. This is now fixed by
counting the files/folders and uncompressed size in
ArchiveModel::countEntriesAndSize().

BUG: 363368
FIXED-IN: 16.08.0
Differential Revision: D2130
GUI:

* Applications/16.04:
  Fix starting Ark from Plasma 5.7
  archivemodel: check for ListJob errors

Summary:
1. Compute also the MD5 in another thread (useful if the archive is huge)
2. Drop the member QByteArray. If the archive is huge this could be bad on
   systems with low amount of RAM. QCryptographicHash accepts a QIODevice, so we
   can just read the file three times.

Differential Revision: D2123

Previously, the compresion level was only set when creating new
archives.

This fixes all message widgets the are displayed in the Part even though they are not supposed to.

Differential Revision: D2095

When creating a new archive from an Ark instance where an archive with
comment already is opened, the comment widget from the previous archive
remains visible. This is now fixed by clearing and hiding the
QPlaintTextEdit in beginning of Part::openFile().

Part::slotCommentChanged() gets called when calling
QPlainTextEdit::clear(), so to avoid a segfault we need to check for an
invalid m_model.archive() and in that case return.

Differential Revision: D2114

We use this cmake function to install our plugins. For the kerfuffle ones, we
also define a cmake wrapper that calls this function and also links to the
kerfuffle library.

Differential Revision: D2113

Plasma 5.7 introduced some changes that exposed a bug in Ark, resulting in the
app not starting when invoked from the start menu or KRunner.

Dropping the X-KDE-HasTempFileOption property from the Ark .desktop file fixes
this issue.

This property was (wrongly) set in commit bc6dcce5, where Ark was ported
away from KUniqueApplication.

Thanks to Ragnar Thomsen for the bugfix.

If a ListJob ends up with an error (e.g. job aborted due to corrupted archive),
we should not add the listed entries in the model.

BUG: 361757
FIXED-IN: 16.04.3

Differential Revision: D2082

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The recently released libarchive 3.2.0 adds support for LZ4-compression.
We utilize this to enable support for LZ4-compressed tarballs in
libarchiveplugin.

Libarchive requires the lz4 executable to be found in path.

cmake < 3.6 is not able to detect version number of libarchive 3.2 and
therefore LZ4-support will not be enabled for older cmake versions, even
though libarchive 3.2 is installed.

Differential Revision: D1821

For a rationale, see https://git.reviewboard.kde.org/r/128225/
This will allow Dolphin to locate our plugins without having to check every
plugin in $QT_PLUGIN_DIR.

GIT_SILENT

This is recommended by the KXMLGuiWindow documentation. Passing Create to
setupGUI() will end up calling createGUI(), but KParts::MainWindow instances
are supposed to call createGUI(part) instead.

See also:
https://api.kde.org/frameworks/kxmlgui/html/classKXmlGuiWindow.html#a938a747d4c9aad833848dee2e0b3121fab21e394f15c27dba750c4e5e88427184

The recent-files action is already connected to the openUrl() slot, and this
other connect() is always ignored.

This allow use to drop quite a lot of old, buggy and redundant code that is already
provided by setupGUI() for free.

We also gain the standard "Show Toolbar" checkbox in the Settings menu.

BUG: 357660
FIXED-IN: 16.08.0

Differential Revision: D1829

The property is unused since commit a040f885.

GIT_SILENT

Remove unused fields from the plugin json files (Authors, License,
Website and X-KDE-Kerfuffle-APIRevision). The fields have not been
updated for ages. The license and authors information is available in
the .cpp and .h files.

The plugin version is now set to follow Ark version and gets
auto-updated by CMake.

Differential Revision: D1828

This will allow us to configure the supported mimetypes at build time (e.g.
depending on the libarchive version we are building against). We also don't
need anymore the check for mimetypes in two different places.

Differential Revision: D1822

Better documentation about how to do a merge.

The goal of task T916 is to stop disabling the Part UI while extracting an
entry. To do so, we need first to make sure that no race condition would occur
if extracting two or more entries in parallel.

A race condition might occur in Part::slotOpenExtractedEntry(), where
m_openFileMode is a global member that could be accessed concurrently between
different threads. We can stop using this variable if we introduce dedicated
jobs for preview/opening of files. This way we can simply do a dynamic_cast on
the local job variable, to check whether the user wants to open or open-with
the file.

Preview is totally unrelated so it can be moved into a different slot. We can
also make sure that the PreviewJob deletes the temporary directory upon
completion.

Differential Revision: D1749

`QDialog::exec()` is bad and should not be used unless strictly necessary.
The exec() call is blocking and anything can happen before it returns to the caller.

The old workaround is to use a `QPointer` to guard the dialog.
Yet there is a crash when calling `QCoreApplication::quit()` via dbus while the dialog is open.

The proper fix is to call the dialog in a non-blocking way. Nowadays this is trivial thanks to C++11 lambdas.

Differential Revision: D1786