GitLab

If a ListJob ends up with an error (e.g. job aborted due to corrupted archive),
we should not add the listed entries in the model.

BUG: 361757
FIXED-IN: 16.04.3

Differential Revision: D2082

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

`QDialog::exec()` is bad and should not be used unless strictly necessary.
The exec() call is blocking and anything can happen before it returns to the caller.

The old workaround is to use a `QPointer` to guard the dialog.
Yet there is a crash when calling `QCoreApplication::quit()` via dbus while the dialog is open.

The proper fix is to call the dialog in a non-blocking way. Nowadays this is trivial thanks to C++11 lambdas.

Differential Revision: D1786

Before 16.04 Ark used to be able to open files whose mimetype is not directly
registered with Ark, but inherits from a mimetype that is supported by Ark.
Examples are .odt and .epub files that both inherits from application/zip.

Since we don't use anymore KMimeTypeTrader (since 16.04), we need to manually
do this check while loading our plugins.

BUG: 363717
FIXED-IN: 16.04.2

Differential Revision: D1725

When opening-with an entry we currently tell kioexec to autoremove the given
URL, but we actually remove this file in the Part destructor.

This results in kioexec sleeping for 3 minutes and then displaying an annoying
'about to delete <URL>' message, if Ark is started from terminal.

BUG: 363718
FIXED-IN: 16.04.2

Such error lines should not be handled by plugins. This was causing
error line to appear as comment for a corrupt RAR archive.

AddToArchive currently tries to drop the extension from any filename,
even if there is no extension in it. We now exploit the mimetype
detected-by-extension: if it's the default mimetype,
then the filename is just a string with some dots but no valid extension.
Otherwise the filename has an actual extension, which we discard.

A testcase is added to reproduce the issue.

BUG: 362690
FIXED-IN: 16.04.1

Differential Revision: D1541

Ark was ignoring the password prompt, resulting in an endless DeleteJob.
This is simply fixed by using the PasswordSwitch, like in other jobs.

Commit 8c21ca3a broke the preview/opening of files. This is actually due to
ListJobs not autodeleting themeselves upon completion. This was introduced by
commit 4b67603d to fix bug 217836, which doesn't seem reproducible nowadays.

Even if it was, we would need a better fix, because this line is causing also
different issues on master (where we now run CliInterface from the main
thread).

CCBUG: 217836

Task: T2374

This silences the -Wreorder gcc warnings

When trying to open the first vol of a multi-volume zip archive with
clizip, Ark will detect the archive as corrupt. The error message was
erroneously being detected and displayed as a comment if the user tried
to open the archive as read-only.

Since shared-mime-info v1.4 is only 15 months old, we need to support
the old mimetype for Debian packages as well. This should also fix the
autotest on the KDE CI system.

The mimetype for Debian packages (*.deb) was updated in shared-mime-info
1.4 from application/x-deb to application/vnd.debian.binary-package,
resulting in Ark failing to open this archive type.

This commit also adds an autotest for this mimetype.

BUG: 362356
FIXED-IN: 16.04.1

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This was supposed to be part of commit c1c104a6. The KMainWindow docs recommend
the parent implementation be called when reimplementing in a subclass.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

For example wget can create compressed tar archives
with this kind of name.

Differential Revision: D1384

We use the m_abortOperation flag in the same way ListJob does (see commit
acb455da).

We also need to remove the disconnect() in the Job destructor, which makes Ark
crash if we stop an AddToArchive job. This disconnect() looks like a relic of the
past (see e.g. commit 15fce6f5) and doesn't seem really necessary.

Note that the CliInterface jobs still need to be fixed. So do batch extract
jobs, which are KCompositeJobs and currently ignore the kill button in the
systray.

CCBUG: 222392

Differential Revision: D1466

by unsetting Part::widget() as their parent.

Differential Revision: D1408

Add <text> field in ark_part.rc for main toolbar. This caused an empty
checkbox appearing in the context menu when right-clicking the menubar.

Thanks to Burkhard Lueck for reporting.

The fix in commit 44dba1cf is also needed when adding files to an
existing lrzip archive.

libarchive emits ARCHIVE_WARN, instead of a ARCHIVE_OK when setting
lrzip compression filter.

Differential Revision: D1254