1. 05 Jul, 2016 1 commit
    • Elvis Angelaccio's avatar
      archivemodel: check for ListJob errors · 97eb1b35
      Elvis Angelaccio authored
      If a ListJob ends up with an error (e.g. job aborted due to corrupted archive),
      we should not add the listed entries in the model.
      
      BUG: 361757
      FIXED-IN: 16.04.3
      
      Differential Revision: D2082
      97eb1b35
  2. 02 Jul, 2016 1 commit
  3. 23 Jun, 2016 1 commit
  4. 09 Jun, 2016 1 commit
    • Elvis Angelaccio's avatar
      Fix crash with blocking Open dialog · 0d16e7d0
      Elvis Angelaccio authored
      `QDialog::exec()` is bad and should not be used unless strictly necessary.
      The exec() call is blocking and anything can happen before it returns to the caller.
      
      The old workaround is to use a `QPointer` to guard the dialog.
      Yet there is a crash when calling `QCoreApplication::quit()` via dbus while the dialog is open.
      
      The proper fix is to call the dialog in a non-blocking way. Nowadays this is trivial thanks to C++11 lambdas.
      
      Differential Revision: D1786
      0d16e7d0
  5. 07 Jun, 2016 1 commit
  6. 06 Jun, 2016 1 commit
  7. 05 Jun, 2016 1 commit
    • Elvis Angelaccio's avatar
      Fix opening of files whose mimetype inherits from a supported mimetype · 8b9cd300
      Elvis Angelaccio authored
      Before 16.04 Ark used to be able to open files whose mimetype is not directly
      registered with Ark, but inherits from a mimetype that is supported by Ark.
      Examples are .odt and .epub files that both inherits from application/zip.
      
      Since we don't use anymore KMimeTypeTrader (since 16.04), we need to manually
      do this check while loading our plugins.
      
      BUG: 363717
      FIXED-IN: 16.04.2
      
      Differential Revision: D1725
      8b9cd300
  8. 02 Jun, 2016 1 commit
    • Elvis Angelaccio's avatar
      Don't tell kioexec to autodelete our temp files · 4318ac1b
      Elvis Angelaccio authored
      When opening-with an entry we currently tell kioexec to autoremove the given
      URL, but we actually remove this file in the Part destructor.
      
      This results in kioexec sleeping for 3 minutes and then displaying an annoying
      'about to delete <URL>' message, if Ark is started from terminal.
      4318ac1b
  9. 31 May, 2016 1 commit
  10. 28 May, 2016 1 commit
  11. 05 May, 2016 1 commit
    • Elvis Angelaccio's avatar
      addtoarchive: drop extension only when present · 846febf9
      Elvis Angelaccio authored
      AddToArchive currently tries to drop the extension from any filename,
      even if there is no extension in it. We now exploit the mimetype
      detected-by-extension: if it's the default mimetype,
      then the filename is just a string with some dots but no valid extension.
      Otherwise the filename has an actual extension, which we discard.
      
      A testcase is added to reproduce the issue.
      
      BUG: 362690
      FIXED-IN: 16.04.1
      
      Differential Revision: D1541
      846febf9
  12. 03 May, 2016 1 commit
  13. 28 Apr, 2016 2 commits
    • Elvis Angelaccio's avatar
      Auto delete ListJobs · 72a46a21
      Elvis Angelaccio authored
      Commit 8c21ca3a broke the preview/opening of files. This is actually due to
      ListJobs not autodeleting themeselves upon completion. This was introduced by
      commit 4b67603d to fix bug 217836, which doesn't seem reproducible nowadays.
      
      Even if it was, we would need a better fix, because this line is causing also
      different issues on master (where we now run CliInterface from the main
      thread).
      
      CCBUG: 217836
      
      Task: T2374
      72a46a21
    • Elvis Angelaccio's avatar
      libarchive: fix wrong order in initializer list · 765202c1
      Elvis Angelaccio authored
      This silences the -Wreorder gcc warnings
      765202c1
  14. 27 Apr, 2016 5 commits
  15. 26 Apr, 2016 2 commits
  16. 23 Apr, 2016 3 commits
  17. 21 Apr, 2016 1 commit
  18. 20 Apr, 2016 1 commit
    • Ragnar Thomsen's avatar
      Add missing text for main toolbar · 18000e9a
      Ragnar Thomsen authored
      Add <text> field in ark_part.rc for main toolbar. This caused an empty
      checkbox appearing in the context menu when right-clicking the menubar.
      
      Thanks to Burkhard Lueck for reporting.
      18000e9a
  19. 13 Apr, 2016 1 commit
  20. 12 Apr, 2016 1 commit
  21. 08 Apr, 2016 1 commit
  22. 06 Apr, 2016 1 commit
  23. 03 Apr, 2016 1 commit
  24. 01 Apr, 2016 1 commit
  25. 31 Mar, 2016 1 commit
  26. 30 Mar, 2016 1 commit
  27. 29 Mar, 2016 3 commits
  28. 28 Mar, 2016 1 commit
  29. 27 Mar, 2016 1 commit
  30. 26 Mar, 2016 1 commit