1. 23 Nov, 2014 1 commit
    • Raphael Kubo da Costa's avatar
      Stop crashing on exit when being used solely as a KPart. · 9c30f30b
      Raphael Kubo da Costa authored
      This change fixes a crash introduced by commit 3b981ca9 ("Remove Part
      from KXMLGUIFactory on exit").
      
      Part::~Part() is the wrong place to call KXMLGUIFactory::removeClient(),
      as it assumes addClient() had been called in the first place.
      
      This is only true if Ark is called as a standalone program, since that
      is done in MainWindow::loadPart()'s call to KXMLGuiWindow::createGUI().
      
      Conversely, if the Ark KPart is being used as an embedded viewer in,
      say, Konqueror or to preview an archive inside an archive (ie. Ark
      inside Ark) that does not hold true and we try to access a
      KXMLGUIFactory that does not exist.
      
      Instead, call KXMLGuiWindow::removeClient() in MainWindow's destructor,
      since in this case we are certain that addClient() was been called
      before.
      
      BUG:      341187
      FIXED-IN: 14.12
      9c30f30b
  2. 14 Nov, 2014 2 commits
  3. 28 Oct, 2014 1 commit
  4. 25 Oct, 2014 2 commits
  5. 23 Oct, 2014 5 commits
    • Raphael Kubo da Costa's avatar
      Merge branch 'KDE/4.14' · 0b06929d
      Raphael Kubo da Costa authored
      This is actually just a merge commit to sync the history.
      
      It was produced with "git merge --stragegy ours", so the changes in
      commit from KDE/4.14 being merged ('Revert "Add the 'open-with' action
      and show the right-click menu."') are not being pulled in.
      
      The 'open-with' feature was only intended for this branch (master, which
      is going to be KDE Applications 14.12), as it is a new feature and
      contains new strings.
      
      Even though this means the translations which were restored in KDE/4.14
      will not be restored here, it is OK because they were never committed to
      master so there has been no effective change.
      
      CCBUG:  179066
      DIGEST:
      GUI:
      0b06929d
    • Raphael Kubo da Costa's avatar
      Revert "Add the 'open-with' action and show the right-click menu." · 2a552b1a
      Raphael Kubo da Costa authored
      This commit was only intended for the master branch (KDE Applications
      14.12) as it is a new feature and introduces new strings.
      
      It also restores some translations in ark.appdata.xml that were changed
      by mistake in the same commit.
      
      This reverts commit ed3ea7db.
      
      (I'm mentioning the digest and UI folks again to make sure everyone's
      aware of the right version and branch that will have this change)
      
      CCBUG:  179066
      DIGEST:
      DOC:
      2a552b1a
    • Elvis Angelaccio's avatar
      Merge branch 'KDE/4.14' · 4c099afe
      Elvis Angelaccio authored
      * KDE/4.14:
        Add the 'open-with' action and show the right-click menu.
      4c099afe
    • Elvis Angelaccio's avatar
      Add the 'open-with' action and show the right-click menu. · ed3ea7db
      Elvis Angelaccio authored
      This patch implements the 'open-with' action, which allows the users to
      temporarily extract a file and open it with a chosen application.
      A contextual menu has been implemented as well. This menu is showed when the
      user right-clicks on an entry in the archive.
      
      FEATURE: 179066
      FIXED-IN: 4.14.3
      REVIEW: 120216
      GUI:
      DIGEST:
      ed3ea7db
    • Raphael Kubo da Costa's avatar
      part: Remove extra empty line. · fe127a1d
      Raphael Kubo da Costa authored
      GIT_SILENT
      fe127a1d
  6. 10 Oct, 2014 1 commit
  7. 03 Oct, 2014 1 commit
  8. 02 Oct, 2014 2 commits
    • Elvis Angelaccio's avatar
      Merge branch 'KDE/4.14' · 87a05f4d
      Elvis Angelaccio authored
      * KDE/4.14:
        Add keyboard shortcuts to preview action.
        SVN_SILENT made messages (.desktop file)
        SVN_SILENT made messages (after extraction)
        SVN_SILENT made messages (.desktop file)
        Reset info panel and window caption when an archive fails to open.
        SVN_SILENT made messages (.desktop file)
        SVN_SILENT made messages (after extraction)
        SVN_SILENT made messages (.desktop file)
        SVN_SILENT made messages (after extraction)
        SVN_SILENT made messages (after extraction)
        SVN_SILENT made messages (.desktop file)
        SVN_SILENT made messages (.desktop file)
      
      Conflicts:
      	app/ark.appdata.xml
      	app/ark_addtoservicemenu.desktop
      87a05f4d
    • Elvis Angelaccio's avatar
      Add keyboard shortcuts to preview action. · ab188f35
      Elvis Angelaccio authored
      The default shortcut for the preview action is now the Return key, while the Space key
      is the alternate one.
      
      BUG: 322095
      FIXED-IN: 4.14.2
      REVIEW: 120464
      ab188f35
  9. 01 Oct, 2014 4 commits
  10. 22 Sep, 2014 2 commits
  11. 20 Sep, 2014 1 commit
  12. 06 Sep, 2014 1 commit
    • Raphael Kubo da Costa's avatar
      Reset info panel and window caption when an archive fails to open. · 03b6de3c
      Raphael Kubo da Costa authored
      When opening an archive that for whatever reason fails to load (because
      it's corrupt, or an invalid format) the archive appears to be open when
      it is not in fact open. This patch fixes that by resetting the open
      archive, info panel name and window caption.
      
      Patch by Mathias Tillman <master.homer@gmail.com>, thank you!
      
      BUG:      245705
      CCMAIl:   master.homer@gmail.com
      FIXED-IN: 4.14.1
      REVIEW:   120027
      03b6de3c
  13. 31 Aug, 2014 4 commits
  14. 18 Aug, 2014 4 commits
  15. 16 Aug, 2014 1 commit
  16. 15 Aug, 2014 1 commit
  17. 14 Aug, 2014 2 commits
  18. 12 Aug, 2014 1 commit
  19. 07 Aug, 2014 2 commits
    • Raphael Kubo da Costa's avatar
      Merge branch 'KDE/4.14' · 896c0edb
      Raphael Kubo da Costa authored
      * KDE/4.14:
        Revert "Allow multiple selection in archiveview"
      896c0edb
    • Raphael Kubo da Costa's avatar
      Revert "Allow multiple selection in archiveview" · 4429a4eb
      Raphael Kubo da Costa authored
      The commit being reverted seems to work fine for the ZIP and LHA
      backends, but for libarchive and RAR it can extract files with the wrong
      name, a varying hierarchy depending on which of the selected entries is
      being dragged or sometimes even leave selected entries out.
      
      While it is certainly bad to go back to the previous state, it is worse
      to have this working at varying degrees in each backend, the worst case
      including partial extraction with wrong names.
      
      This reverts commit 52ac4aea.
      
      CCBUG: 187152
      4429a4eb
  20. 06 Aug, 2014 2 commits