1. 31 Jul, 2011 1 commit
  2. 28 Jul, 2011 1 commit
  3. 26 Jul, 2011 1 commit
  4. 23 Jul, 2011 1 commit
  5. 19 Jul, 2011 3 commits
  6. 18 Jul, 2011 2 commits
    • Raphael Kubo da Costa's avatar
      Specify when the extraction dialog's settings should be followed. · 4d0edc91
      Raphael Kubo da Costa authored
      On ExtractJob's side, we make the extraction options it received
      publicly accessible.
      
      On Part's side, we set a "FollowExtractionDialogSettings" option to
      true only when the extraction dialog was used to extract files, and
      only actually follow these settings (for now, open the destination
      directory and/or quit Ark after the extraction) when that option is
      set.
      
      Forwardport of r1242113.
      
      CCBUG: 188857
      
      svn path=/trunk/KDE/kdeutils/ark/; revision=1242115
      4d0edc91
    • Raphael Kubo da Costa's avatar
      Move destination directory retrieval to ExtractJob. · a717ac6d
      Raphael Kubo da Costa authored
      Part::m_destinationDirectory was only set when the files were
      extracted using the extraction dialog.
      
      This meant that if the user had chosen to open the destination
      directory after an extraction he would always have his home directory
      open when the extraction was done via quick extract or drag'n'drop, as
      KRun::runUrl would have an empty KUrl as its parameter.
      
      We now make the destination directory passed to ExtractJob publicly
      available, and retrieve it from there.
      
      Forwardport of r1242112.
      
      CCBUG: 188857
      
      svn path=/trunk/KDE/kdeutils/ark/; revision=1242114
      a717ac6d
  7. 12 Jul, 2011 1 commit
  8. 11 Jul, 2011 8 commits
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) · 43d2aff9
      Script Kiddy authored
      svn path=/trunk/KDE/kdeutils/ark/; revision=1241038
      43d2aff9
    • Raphael Kubo da Costa's avatar
      cliinterface: Do not assume a process does not exist in runProcess(). · 58e97eba
      Raphael Kubo da Costa authored
      The Q_ASSERT(!m_process) in the beginning of runProcess() was wrong, as when
      one is adding files to an archive (or creating an archive) processFinished()
      calls list(), which in turn calls runProcess() as well, thus making the assert
      fail.
      
      The best thing to do is just wait for the existing process to finish before
      launching the new one.
      
      Forwardport of r1240907.
      
      CCBUG: 277393
      
      svn path=/trunk/KDE/kdeutils/ark/; revision=1240917
      58e97eba
    • Raphael Kubo da Costa's avatar
      Move the JSON parsing code to a separate class. · 2cc215fb
      Raphael Kubo da Costa authored
      Besides splitting the code a little bit and having some typedefs that make the
      code cleaner, this is a first step towards being able to use the parser in
      other classes (this is particularly useful once there are tests for
      cliinterface).
      
      Additionally, we stop compiling jsonarchiveinterface.cpp with every test, as it
      is stupid. Instead, we now create a library and link to it.
      
      svn path=/trunk/KDE/kdeutils/ark/; revision=1240916
      2cc215fb
    • Raphael Kubo da Costa's avatar
      Make jobstest behave reliably. · 758f00ce
      Raphael Kubo da Costa authored
      There were two separate problems which made the test results
      unreliable (as in they passed randomly):
      
       - The tests relied in KJob::exec() to run each job synchronously until the end
         (ie. until the KJob::result() signal was emitted).  However, KJob::exec()
         only starts an event loop if the test is still running after KJob::start()
         is called (ie. d->isFinished is true). In our case, the job would run
         synchronously in the worker thread until KJob::emitResult() was
         called. emitResult(), on its turn, sets d->isFinished to false. This all
         happens when KJob::start() is called in KJob::exec() and before the event
         loop is started, so it is never started, some signals are not delivered in
         time (as we have different threads, they are delivered asynchronously), data
         is not processed and KJob::exec() finishes, so when the unit tests later
         check for some job data it has not been properly set.
         To fix this, we do the same thing KJob's unit tests to, and explicitly run
         an event loop which stops only when the KJob::result() signal is delivered.
      
       - Some tests accessed data from the job classes after the job had finished
         running, but did not call KJob::setAutoDelete(false), so they job was
         deleted before its data was accessed. When the tests access job data after
         the job has run, KJob::setAutoDelete(false) is now properly called.
      
      svn path=/trunk/KDE/kdeutils/ark/; revision=1240915
      758f00ce
    • Raphael Kubo da Costa's avatar
      Do not connect to KJob::result() from the worker thread. · 751a0d3a
      Raphael Kubo da Costa authored
      This is another step towards getting rid of the threading mess we
      currently have.
      
      We previously connected to KJob::result() from the worker thread using
      Qt::DirectConnection just to make sure QThread::quit() was called
      right away (synchronously). We now make the connection from the main
      thread without Qt::DirectConnection, and just make sure we start the
      worker thread's event loop if there is an actual need to.
      
      The other use of Qt::DirectConnection in the worker thread (via
      QMetaObject::invkeMethod) has also been removed, as it was there to
      make sure the method was called right away from the worker thread as
      well.
      
      svn path=/trunk/KDE/kdeutils/ark/; revision=1240914
      751a0d3a
    • Raphael Kubo da Costa's avatar
      Simplify the format of the JSON test data. · bcad03cd
      Raphael Kubo da Costa authored
      We previously had each file consist of a dictionary containing a
      single key, "entries", whose value was a list of dictionaries
      contaning the properties of each file in the archive. Now we just have
      the list of dictionaries.
      
      svn path=/trunk/KDE/kdeutils/ark/; revision=1240913
      bcad03cd
    • Raphael Kubo da Costa's avatar
      cliinterface: Remove dead started() slot. · 01300385
      Raphael Kubo da Costa authored
      It looks like since 4.3.0 it was only setting an attribute which was
      not used anywhere else.
      
      svn path=/trunk/KDE/kdeutils/ark/; revision=1240912
      01300385
    • Raphael Kubo da Costa's avatar
      cliinterface: Do not assume a process does not exist in runProcess(). · 463aa763
      Raphael Kubo da Costa authored
      The Q_ASSERT(!m_process) in the beginning of runProcess() was wrong, as when
      one is adding files to an archive (or creating an archive) processFinished()
      calls list(), which in turn calls runProcess() as well, thus making the assert
      fail.
      
      The best thing to do is just wait for the existing process to finish before
      launching the new one.
      
      BUG: 277393
      FIXED-IN: 4.7.0
      
      svn path=/branches/KDE/4.7/kdeutils/ark/; revision=1240907
      463aa763
  9. 10 Jul, 2011 1 commit
  10. 09 Jul, 2011 1 commit
  11. 08 Jul, 2011 1 commit
  12. 07 Jul, 2011 1 commit
  13. 06 Jul, 2011 1 commit
  14. 05 Jul, 2011 1 commit
  15. 03 Jul, 2011 2 commits
  16. 25 Jun, 2011 1 commit
  17. 19 Jun, 2011 1 commit
  18. 07 Jun, 2011 1 commit
  19. 04 Jun, 2011 1 commit
  20. 31 May, 2011 1 commit
  21. 29 May, 2011 1 commit
  22. 26 May, 2011 5 commits
  23. 23 May, 2011 3 commits
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) · 1997cfdd
      Script Kiddy authored
      svn path=/trunk/KDE/kdeutils/ark/; revision=1233238
      1997cfdd
    • Raphael Kubo da Costa's avatar
      Add some notes for future me. · 1f809709
      Raphael Kubo da Costa authored
      SVN_SILENT
      
      svn path=/trunk/KDE/kdeutils/ark/; revision=1233142
      1f809709
    • Raphael Kubo da Costa's avatar
      cliinterface: Do not reset the password after a wrong one was entered. · 07423196
      Raphael Kubo da Costa authored
      This partially reverts r964726. There does not seem to be any solid
      reason for resetting the password like this, and there is at least one
      reason not to do so: when in batch-extraction mode, addExtraction()
      will create a ListJob to check if an archive has a single folder. If
      the archive is header-encrypted, it will ask for a password. In case a
      wrong password is entered, preserving it means the coming
      ExtractionJob will use the wrong password and finally show the
      "Incorredt password" error message which was not shown before (and
      cancel the forthcoming jobs).
      
      This should fix the issue in comment #75 of bug 35371.
      
      svn path=/trunk/KDE/kdeutils/ark/; revision=1233141
      07423196