GitLab

Quick-extraction should work similar to "Extract To..." and drag'n'drop
extracting.

CompressionOptionsWidget needs to return compression level -1 for
archives that dont support compression levels (e.g. uncompressed tars).

Thanks to mvlabat for discovering this bug.

Multi-volume archives are set to read-only (only when non-empty) in
Archive class. This is needed because rar and 7z don't support modifying
such archives.
Also, a KMessageWidget is now shown when user drags files to a read-only
archive or an encrypted archive when password is unknown.

Unfortunately, we cant set encrypted archives with unknown password to
read-only, because we still want to support deleting files from them.

Differential Revision: D2274

There is a race condition when ListJob emits the result signal.
Both ArchiveModel::slotLoadingFinished() and Archive::onListFinished() are connected
to this signal. But the former triggers a chain of calls that ends up calling
properties of Archive that are set by the concurrent Archive::onListFinished().
An example is Archive::encryptionType() called by Part::updateActions().

This results in an endless chain of ListJob instances.

This patch is only a temporary workaround for the upcoming 16.08 stable
release, since there is no time to test and merge a proper fix (see T3300)

Differential Revision: D2272
Task: T3296

The assumption that a PreviewJob can remove its temp dir when it's done (commit 41b25127)
was wrong, at least with nested archives.
If we remove the extracted file too soon, there is no way to preview a nested archive or,
worse, a "double-nested" archive.

This patch just delays the cleanup to the Part destructor.

Differential Revision: D2265

If there are multiple Ark installations, KPluginLoader will find more than one
Part plugin installed.

GIT_SILENT

GIT_SILENT

Test cases were added to addArgsTest (clirar and cli7z) for specifying
volume size when adding files to multi-volume archives.

Support for creating multi-volume rar, 7z and zip archives was
implemented. A QDoubleSpinBox was added to CompressionOptionsWidget
which allows setting the volume size in megabytes between 0.1 to 1000.
The size in megabytes is converted by CompressionOptionsWidget to
kilobytes because 7z doesn't support volume sizes with decimals.

Creating a multi-volume archive changes the archive name
(name.part1.rar, name.7z.001, name.zip.001) so we need to re-open the
archive (the first volume) after adding files.

We only support adding files once, so add/delete actions are disabled in
Part if archive is multi-volume and non-empty.

FEATURE: 124180
FIXED-IN: 16.08.0
Differential Revision: D2194
GUI:

CCBUG: 365798

Differential Revision: D2230

QUrl::toDisplayString() results in a QString containing %25 instead of %.
This affects both batch extractions and normal extractions from the Ark Part.

Porting to QUrl::toLocalFile() fixes this issue.

BUG: 365798
FIXED-IN: 16.08.0

Differential Revision: D2229

AppImages are both executables and ISO images and can be handled by
libarchive. Support for opening AppImages was enabled in the
libarchiveplugin. The mimetype for AppImage has been committed to
shared-mime-info, but has not yet been released. We therefore install a
custom mimetype for AppImage.

Test cases for this mimetype were added to MimeTypeTest and ArchiveTest.

FEATURE: 363209
FIXED-IN: 16.08.0
Differential Revision: D2226

The direct connection was added in commit acb455da, but since Ark 16.08 is not
necessary anymore (CliInterface runs on the main thread).

This prevents a possible race condition in our jobs
(see https://git.reviewboard.kde.org/r/128113/)

CCBUG: 193908

Differential Revision: D2225

Enable testing of encrypted archives by passing the password switch to
the cli programs. When we don't know the password we disable the Test
action with an explanation in the tooltip.

Differential Revision: D2227

We don't know the password after opening a non-header-encrypted
password-protected archive. If adding files to such an archive the newly
added files will be unencrypted with no warning to the user and the
resulting archive will be a mixture of encrypted/unencrypted files.

This commit disables adding files to such archives and gives an
explanation in the tooltip for the add files action.

Differential Revision: D2196

When adding folders to RAR archives, any subfolders were not added. This
was due to a trailing slash added to the path of subfolders, which
caused rar to not add these to the archive.

BUG: 365323
FIXED-IN: 16.08.0
Differential Revision: D2197

The unittests check whether multi-volume archives are detected, parsed
correctly and also that the number of volumes is correct.

An error was fixed in the UNRAR4 parser, so the number of volumes is
detected corectly.

Other unittests for the recent p7zip v16.02 were also added.

Two variables were added to ReadOnlyArchiveInterface: A boolean
describing whether the archive is multi-volume and an int used for
storing number of volumes. Two corresponding Q_PROPERTY's were added to
Archive which fetch the info from ReadOnlyArchiveInterface.

The detection of multi-volume archives was fixed in cli7z.

The information is displayed in PropertiesDialog and will be used when
implementing support for creating multi-volume archives.

GUI:

This diff implements an AddDialog class that is used instead of
QFileDialogs for adding files/folders to an archive. Now both folders
and files are added to an archive with a single action in Part, instead
of two separate actions (Add File/Add Folder).

AddDialog has a button which opens a new dialog that allows setting
advanced compression settings (currently only compression level). Since
compression options are used both when creating a new archive and adding
files to an existing archive, a new class called
CompressionOptionsWidget was created which is used by both AddDialog and
CreateDialog.

Differential Revision: D2120
GUI:

Every time we do a 'make install' we also update the mime database (because we
install mimetypes) and this causes the ksycoca file to be regenerated the
next time we run Ark (because we load the Part using KService).

This is annoying and clutters the console output with ksycoca messages. We can use instead the new
json loading mechanism like we already do with our plugins.

Regarding ark_part.desktop, we continue to install it because Konqueror is
probably using it.

Differential Revision: D2140

This workarounds a git limitation that doesn't allow us to add an empty
directory in the repository.

Check for correct number of added folders. Add tests for empty subdirs
and folders with multiple level of subfolders.

Also test the RAR format, even though we currently dont provide a
"Compress Here (as RAR)" action in the service menu.

The number of folders is now also shown in PropertiesDialog. There was a
bug where number of files/folders and total uncompressed size didn't get
updated after adding/deleting files from archive. This is now fixed by
counting the files/folders and uncompressed size in
ArchiveModel::countEntriesAndSize().

BUG: 363368
FIXED-IN: 16.08.0
Differential Revision: D2130
GUI:

* Applications/16.04:
  Fix starting Ark from Plasma 5.7
  archivemodel: check for ListJob errors

Summary:
1. Compute also the MD5 in another thread (useful if the archive is huge)
2. Drop the member QByteArray. If the archive is huge this could be bad on
   systems with low amount of RAM. QCryptographicHash accepts a QIODevice, so we
   can just read the file three times.

Differential Revision: D2123

Previously, the compresion level was only set when creating new
archives.

This fixes all message widgets the are displayed in the Part even though they are not supposed to.

Differential Revision: D2095