1. 21 Jul, 2016 1 commit
    • Elvis Angelaccio's avatar
      Fix extraction when an archive has a percentage in the name · c98d64bf
      Elvis Angelaccio authored
      QUrl::toDisplayString() results in a QString containing %25 instead of %.
      This affects both batch extractions and normal extractions from the Ark Part.
      
      Porting to QUrl::toLocalFile() fixes this issue.
      
      BUG: 365798
      FIXED-IN: 16.08.0
      
      Differential Revision: D2229
      c98d64bf
  2. 20 Jul, 2016 2 commits
    • Ragnar Thomsen's avatar
      Add support for AppImage · bf2de67e
      Ragnar Thomsen authored
      AppImages are both executables and ISO images and can be handled by
      libarchive. Support for opening AppImages was enabled in the
      libarchiveplugin. The mimetype for AppImage has been committed to
      shared-mime-info, but has not yet been released. We therefore install a
      custom mimetype for AppImage.
      
      Test cases for this mimetype were added to MimeTypeTest and ArchiveTest.
      
      FEATURE: 363209
      FIXED-IN: 16.08.0
      Differential Revision: D2226
      bf2de67e
    • Friedrich W. H. Kossebau's avatar
      21481cb4
  3. 19 Jul, 2016 4 commits
  4. 18 Jul, 2016 2 commits
  5. 17 Jul, 2016 2 commits
  6. 16 Jul, 2016 3 commits
    • Ragnar Thomsen's avatar
      7472e158
    • Ragnar Thomsen's avatar
      Detect multi-volume archives and show info in PropertiesDialog · 0f4ae19b
      Ragnar Thomsen authored
      Two variables were added to ReadOnlyArchiveInterface: A boolean
      describing whether the archive is multi-volume and an int used for
      storing number of volumes. Two corresponding Q_PROPERTY's were added to
      Archive which fetch the info from ReadOnlyArchiveInterface.
      
      The detection of multi-volume archives was fixed in cli7z.
      
      The information is displayed in PropertiesDialog and will be used when
      implementing support for creating multi-volume archives.
      
      GUI:
      0f4ae19b
    • Ragnar Thomsen's avatar
      Implement a custom AddDialog · 07269ec7
      Ragnar Thomsen authored
      This diff implements an AddDialog class that is used instead of
      QFileDialogs for adding files/folders to an archive. Now both folders
      and files are added to an archive with a single action in Part, instead
      of two separate actions (Add File/Add Folder).
      
      AddDialog has a button which opens a new dialog that allows setting
      advanced compression settings (currently only compression level). Since
      compression options are used both when creating a new archive and adding
      files to an existing archive, a new class called
      CompressionOptionsWidget was created which is used by both AddDialog and
      CreateDialog.
      
      Differential Revision: D2120
      GUI:
      07269ec7
  7. 12 Jul, 2016 1 commit
    • Elvis Angelaccio's avatar
      part: switch to json loading · bce36ee9
      Elvis Angelaccio authored
      Every time we do a 'make install' we also update the mime database (because we
      install mimetypes) and this causes the ksycoca file to be regenerated the
      next time we run Ark (because we load the Part using KService).
      
      This is annoying and clutters the console output with ksycoca messages. We can use instead the new
      json loading mechanism like we already do with our plugins.
      
      Regarding ark_part.desktop, we continue to install it because Konqueror is
      probably using it.
      
      Differential Revision: D2140
      bce36ee9
  8. 10 Jul, 2016 3 commits
    • Elvis Angelaccio's avatar
      GIT_SILENT Fix AddToArchive test · 562f156a
      Elvis Angelaccio authored
      This workarounds a git limitation that doesn't allow us to add an empty
      directory in the repository.
      562f156a
    • Ragnar Thomsen's avatar
      Extend AddToArchiveTest · f3601127
      Ragnar Thomsen authored
      Check for correct number of added folders. Add tests for empty subdirs
      and folders with multiple level of subfolders.
      
      Also test the RAR format, even though we currently dont provide a
      "Compress Here (as RAR)" action in the service menu.
      f3601127
    • Ragnar Thomsen's avatar
      Add number of folders to PropertiesDialog and fix bugs · d78e151c
      Ragnar Thomsen authored
      The number of folders is now also shown in PropertiesDialog. There was a
      bug where number of files/folders and total uncompressed size didn't get
      updated after adding/deleting files from archive. This is now fixed by
      counting the files/folders and uncompressed size in
      ArchiveModel::countEntriesAndSize().
      
      BUG: 363368
      FIXED-IN: 16.08.0
      Differential Revision: D2130
      GUI:
      d78e151c
  9. 09 Jul, 2016 2 commits
    • Elvis Angelaccio's avatar
      Merge branch 'Applications/16.04' · af3ba6c2
      Elvis Angelaccio authored
      * Applications/16.04:
        Fix starting Ark from Plasma 5.7
        archivemodel: check for ListJob errors
      af3ba6c2
    • Elvis Angelaccio's avatar
      Improve checksums calculation · fefce76c
      Elvis Angelaccio authored
      Summary:
      1. Compute also the MD5 in another thread (useful if the archive is huge)
      2. Drop the member QByteArray. If the archive is huge this could be bad on
         systems with low amount of RAM. QCryptographicHash accepts a QIODevice, so we
         can just read the file three times.
      
      Differential Revision: D2123
      fefce76c
  10. 08 Jul, 2016 4 commits
  11. 07 Jul, 2016 2 commits
    • Elvis Angelaccio's avatar
      Port to kcoreaddons_add_plugin · 5d133a92
      Elvis Angelaccio authored
      We use this cmake function to install our plugins. For the kerfuffle ones, we
      also define a cmake wrapper that calls this function and also links to the
      kerfuffle library.
      
      Differential Revision: D2113
      5d133a92
    • Elvis Angelaccio's avatar
      Fix starting Ark from Plasma 5.7 · 132743e5
      Elvis Angelaccio authored
      Plasma 5.7 introduced some changes that exposed a bug in Ark, resulting in the
      app not starting when invoked from the start menu or KRunner.
      
      Dropping the X-KDE-HasTempFileOption property from the Ark .desktop file fixes
      this issue.
      
      This property was (wrongly) set in commit bc6dcce5, where Ark was ported
      away from KUniqueApplication.
      
      Thanks to Ragnar Thomsen for the bugfix.
      132743e5
  12. 05 Jul, 2016 1 commit
    • Elvis Angelaccio's avatar
      archivemodel: check for ListJob errors · 97eb1b35
      Elvis Angelaccio authored
      If a ListJob ends up with an error (e.g. job aborted due to corrupted archive),
      we should not add the listed entries in the model.
      
      BUG: 361757
      FIXED-IN: 16.04.3
      
      Differential Revision: D2082
      97eb1b35
  13. 02 Jul, 2016 1 commit
  14. 01 Jul, 2016 1 commit
  15. 28 Jun, 2016 1 commit
  16. 23 Jun, 2016 2 commits
  17. 19 Jun, 2016 1 commit
    • Ragnar Thomsen's avatar
      Add support for LZ4-compressed tar archives · 88ad5a0e
      Ragnar Thomsen authored
      The recently released libarchive 3.2.0 adds support for LZ4-compression.
      We utilize this to enable support for LZ4-compressed tarballs in
      libarchiveplugin.
      
      Libarchive requires the lz4 executable to be found in path.
      
      cmake < 3.6 is not able to detect version number of libarchive 3.2 and
      therefore LZ4-support will not be enabled for older cmake versions, even
      though libarchive 3.2 is installed.
      
      Differential Revision: D1821
      88ad5a0e
  18. 18 Jun, 2016 1 commit
  19. 13 Jun, 2016 6 commits