GitLab

GIT_SILENT

GIT_SILENT

Burak Hancerli authored Apr 29, 2021 and Nate Graham committed Apr 29, 2021

Up button was staying on "Enabled" state even if the user is on the "/"
path.

BUG: 434532

Alexander Lohnau authored Apr 02, 2021 and Harald Sitter committed Apr 06, 2021

See https://phabricator.kde.org/T12549 for rationale

Now it's obvious what the save action will do.

Reviewers: sandsmark

Reviewed By: sandsmark

Subscribers: kde-utils-devel

Differential Revision: https://phabricator.kde.org/D9345

path="" == path="/"

and a path cannot not start with a slash anyway, so the check is moot.

"sftp://localhosthome/me/" != "sftp://localhost/home/me/"

it also does nothing to actually assert that the path is absolute as

"sftp://localhost/home/me/../you/" is relative but would pass the slash
check.

Also, we resolve relative remote paths just fine. Would be weird if we
didn't.

path() would be /foo irregardless of platform, on Windows that's /C:/ which
is not correct as the local representation is C:/. toLocalFile handles this
for us.

I've also changed the var name to be more representitive of what it
contains and is used for i.e. checking the localPath. should remote URL
validation be introduced at a later point it would then be obvious that one
should not be using that particular variable ;)

we have no performance concerns there. this is run once when the user
inputs or selects a URI, using libc functions here serves no purpose really

this is really messy right now. the final merge really ought to get some
refactoring done to detangle business logic form representation