Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Utilities
Kate
Commits
08981495
Commit
08981495
authored
May 06, 2021
by
Waqar Ahmed
Browse files
Fix possible leak when commiting
parent
50be778a
Changes
1
Hide whitespace changes
Inline
Side-by-side
addons/project/gitwidget.cpp
View file @
08981495
...
...
@@ -624,6 +624,7 @@ void GitWidget::opencommitChangesDialog()
GitCommitDialog
*
dialog
=
new
GitCommitDialog
(
m_commitMessage
,
font
,
this
);
connect
(
dialog
,
&
QDialog
::
finished
,
this
,
[
this
,
dialog
](
int
res
)
{
dialog
->
deleteLater
();
if
(
res
==
QDialog
::
Accepted
)
{
if
(
dialog
->
subject
().
isEmpty
())
{
return
sendMessage
(
i18n
(
"Commit message cannot be empty."
),
true
);
...
...
@@ -631,7 +632,6 @@ void GitWidget::opencommitChangesDialog()
m_commitMessage
=
dialog
->
subject
()
+
QStringLiteral
(
"[[
\n\n
]]"
)
+
dialog
->
description
();
commitChanges
(
dialog
->
subject
(),
dialog
->
description
(),
dialog
->
signoff
());
}
dialog
->
deleteLater
();
});
dialog
->
open
();
...
...
Waqar Ahmed
@waqar
mentioned in commit
83ec5582
·
May 06, 2021
mentioned in commit
83ec5582
mentioned in commit 83ec5582204d547bde2fb84526270ff9b1aa4db9
Toggle commit list
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment