Commit 16161f87 authored by Christoph Cullmann's avatar Christoph Cullmann 🐮
Browse files

ensure we unify line endings

we use the strings from the tools in internal
API calls like insertText

these calls assume line endings are just \n

BUG: 436753
parent 13a4805e
......@@ -13,6 +13,7 @@
#include <KShell>
#include <KTextEditor/View>
#include <QFileInfo>
#include <QRegularExpression>
KateToolRunner::KateToolRunner(std::unique_ptr<KateExternalTool> tool, KTextEditor::View *view, QObject *parent)
: QObject(parent)
......@@ -79,14 +80,29 @@ void KateToolRunner::waitForFinished()
* Convert input from local encoding to text with only \n line endings
* @param localOutput local output from tool to convert
* @return string with proper \n line endings
static QString textFromLocal(const QByteArray &localOutput)
// normalize line endings, to e.g. catch issues with \r\n
// see bug 436753
QString s = QString::fromLocal8Bit(localOutput);
static const QRegularExpression lineEndings(QStringLiteral("\r\n?"));
s.replace(lineEndings, QStringLiteral("\n"));
return s;
QString KateToolRunner::outputData() const
return QString::fromLocal8Bit(m_stdout);
return textFromLocal(m_stdout);
QString KateToolRunner::errorData() const
return QString::fromLocal8Bit(m_stderr);
return textFromLocal(m_stderr);
// kate: space-indent on; indent-width 4; replace-tabs on;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment