Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Utilities
Kate
Commits
6349e7e1
Commit
6349e7e1
authored
Oct 22, 2022
by
Christoph Cullmann
🍨
Browse files
add test for window close behavior
use sessionNewm, the createAn.. variant will not close existing documents
parent
02b50a9d
Changes
2
Hide whitespace changes
Inline
Side-by-side
apps/lib/autotests/kate_view_mgmt_tests.cpp
View file @
6349e7e1
...
...
@@ -37,7 +37,7 @@ KateViewManagementTests::KateViewManagementTests(QObject *)
void
KateViewManagementTests
::
testSingleViewspaceDoesntCloseWhenLastViewClosed
()
{
app
->
sessionManager
()
->
activateAnonymousS
ession
();
app
->
sessionManager
()
->
s
ession
New
();
app
->
activeKateMainWindow
()
->
viewManager
()
->
slotDocumentNew
();
// Test that if we have 1 viewspaces then
...
...
@@ -60,7 +60,7 @@ void KateViewManagementTests::testSingleViewspaceDoesntCloseWhenLastViewClosed()
void
KateViewManagementTests
::
testViewspaceClosesWhenLastViewClosed
()
{
app
->
sessionManager
()
->
activateAnonymousS
ession
();
app
->
sessionManager
()
->
s
ession
New
();
app
->
activeKateMainWindow
()
->
viewManager
()
->
slotDocumentNew
();
// Test that if we have greater than 1 viewspaces then
...
...
@@ -89,7 +89,7 @@ void KateViewManagementTests::testViewspaceClosesWhenLastViewClosed()
void
KateViewManagementTests
::
testViewspaceClosesWhenThereIsWidget
()
{
app
->
sessionManager
()
->
activateAnonymousS
ession
();
app
->
sessionManager
()
->
s
ession
New
();
app
->
activeKateMainWindow
()
->
viewManager
()
->
slotDocumentNew
();
// Test that if we have greater than 1 viewspaces then
...
...
@@ -152,7 +152,7 @@ void KateViewManagementTests::testViewspaceClosesWhenThereIsWidget()
void
KateViewManagementTests
::
testMoveViewBetweenViewspaces
()
{
app
->
sessionManager
()
->
activateAnonymousS
ession
();
app
->
sessionManager
()
->
s
ession
New
();
app
->
activeKateMainWindow
()
->
viewManager
()
->
slotDocumentNew
();
KateMainWindow
*
mw
=
app
->
activeKateMainWindow
();
...
...
@@ -176,7 +176,7 @@ void KateViewManagementTests::testMoveViewBetweenViewspaces()
void
KateViewManagementTests
::
testTwoMainWindowsCloseInitialDocument1
()
{
app
->
sessionManager
()
->
activateAnonymousS
ession
();
app
->
sessionManager
()
->
s
ession
New
();
app
->
activeKateMainWindow
()
->
viewManager
()
->
slotDocumentNew
();
// get first main window
...
...
@@ -196,7 +196,7 @@ void KateViewManagementTests::testTwoMainWindowsCloseInitialDocument1()
void
KateViewManagementTests
::
testTwoMainWindowsCloseInitialDocument2
()
{
app
->
sessionManager
()
->
activateAnonymousS
ession
();
app
->
sessionManager
()
->
s
ession
New
();
app
->
activeKateMainWindow
()
->
viewManager
()
->
slotDocumentNew
();
// get first main window
...
...
@@ -216,7 +216,7 @@ void KateViewManagementTests::testTwoMainWindowsCloseInitialDocument2()
void
KateViewManagementTests
::
testTwoMainWindowsCloseInitialDocument3
()
{
app
->
sessionManager
()
->
activateAnonymousS
ession
();
app
->
sessionManager
()
->
s
ession
New
();
app
->
activeKateMainWindow
()
->
viewManager
()
->
slotDocumentNew
();
// get first main window
...
...
@@ -236,7 +236,7 @@ void KateViewManagementTests::testTwoMainWindowsCloseInitialDocument3()
void
KateViewManagementTests
::
testTabLRUWithWidgets
()
{
app
->
sessionManager
()
->
activateAnonymousS
ession
();
app
->
sessionManager
()
->
s
ession
New
();
app
->
activeKateMainWindow
()
->
viewManager
()
->
slotDocumentNew
();
// get first main window
...
...
@@ -337,7 +337,7 @@ void KateViewManagementTests::testBug460613()
// in the first viewspace, not second as well!
// TEST: closing the doc without view should work
app
->
sessionManager
()
->
activateAnonymousS
ession
();
app
->
sessionManager
()
->
s
ession
New
();
KateMainWindow
*
mw
=
app
->
activeKateMainWindow
();
auto
vm
=
mw
->
viewManager
();
vm
->
createView
(
nullptr
);
...
...
@@ -363,3 +363,27 @@ void KateViewManagementTests::testBug460613()
vs2
->
closeDocument
(
doc
);
QVERIFY
(
!
vs2
->
hasDocument
(
doc
));
}
void
KateViewManagementTests
::
testWindowsClosesDocuments
()
{
app
->
sessionManager
()
->
sessionNew
();
app
->
activeKateMainWindow
()
->
viewManager
()
->
slotDocumentNew
();
QCOMPARE
(
app
->
documentManager
()
->
documentList
().
size
(),
1
);
// get first main window
KateMainWindow
*
first
=
app
->
activeKateMainWindow
();
QVERIFY
(
first
);
// create a second one, shall not create a new document
KateMainWindow
*
second
=
app
->
newMainWindow
();
QCOMPARE
(
app
->
documentManager
()
->
documentList
().
size
(),
1
);
QVERIFY
(
second
);
// second window shall have a new document
second
->
viewManager
()
->
slotDocumentNew
();
QCOMPARE
(
app
->
documentManager
()
->
documentList
().
size
(),
2
);
// if we close the second window, the second document shall be gone
delete
second
;
QCOMPARE
(
app
->
documentManager
()
->
documentList
().
size
(),
1
);
}
apps/lib/autotests/kate_view_mgmt_tests.h
View file @
6349e7e1
...
...
@@ -36,6 +36,7 @@ private Q_SLOTS:
void
testWidgetRemovedEmittedOnRemoveWidget
();
void
testActivateNotAddedWidget
();
void
testBug460613
();
void
testWindowsClosesDocuments
();
private:
class
QTemporaryDir
*
m_tempdir
;
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment