Commit 70279f78 authored by Kåre Särs's avatar Kåre Särs
Browse files

Revert longest line note clickable

Putting the inline note directly after the last character on the line
makes it harder to place the cursor at the end of the line with the
mouse. We need another way to open the tool-tip on long lines.
parent e0a172c2
...@@ -70,7 +70,7 @@ QVector<int> GitBlameInlineNoteProvider::inlineNotes(int line) const ...@@ -70,7 +70,7 @@ QVector<int> GitBlameInlineNoteProvider::inlineNotes(int line) const
int lineLen = m_doc->line(line).size(); int lineLen = m_doc->line(line).size();
for (const auto view: m_doc->views()) { for (const auto view: m_doc->views()) {
if (view->cursorPosition().line() == line) { if (view->cursorPosition().line() == line) {
return QVector<int>{qMax(lineLen, 1)}; return QVector<int>{lineLen + 4};
} }
} }
return QVector<int>(); return QVector<int>();
...@@ -93,7 +93,7 @@ void GitBlameInlineNoteProvider::paintInlineNote(const KTextEditor::InlineNote & ...@@ -93,7 +93,7 @@ void GitBlameInlineNoteProvider::paintInlineNote(const KTextEditor::InlineNote &
QString text = info.title.isEmpty() ? QString text = info.title.isEmpty() ?
QStringLiteral(" %1: %2 ").arg(info.name, m_locale.toString(info.date, QLocale::NarrowFormat)) : QStringLiteral(" %1: %2 ").arg(info.name, m_locale.toString(info.date, QLocale::NarrowFormat)) :
QStringLiteral(" %1: %2: %3 ").arg(info.name, m_locale.toString(info.date, QLocale::NarrowFormat), info.title); QStringLiteral(" %1: %2: %3 ").arg(info.name, m_locale.toString(info.date, QLocale::NarrowFormat), info.title);
QRect rectangle{30, 0, fm.horizontalAdvance(text), note.lineHeight()}; QRect rectangle{0, 0, fm.horizontalAdvance(text), note.lineHeight()};
auto editor = KTextEditor::Editor::instance(); auto editor = KTextEditor::Editor::instance();
auto color = QColor::fromRgba(editor->theme().textColor(KSyntaxHighlighting::Theme::Normal)); auto color = QColor::fromRgba(editor->theme().textColor(KSyntaxHighlighting::Theme::Normal));
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment