Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Utilities
Kate
Commits
7f4c60e2
Commit
7f4c60e2
authored
Oct 03, 2021
by
Christoph Cullmann
🐮
Browse files
avoid crash on session rename
delay update of list out of signal/slot chain
BUG: 443267
parent
495b6230
Pipeline
#84759
passed with stage
in 5 minutes and 59 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
kate/session/katesessionmanagedialog.cpp
View file @
7f4c60e2
...
...
@@ -202,14 +202,15 @@ void KateSessionManageDialog::editDone()
{
m_editByUser
=
nullptr
;
disconnect
(
m_sessionList
,
&
QTreeWidget
::
itemChanged
,
this
,
&
KateSessionManageDialog
::
editApply
);
updateSessionList
();
// avoid crash, see bug 142127
QTimer
::
singleShot
(
0
,
this
,
&
KateSessionManageDialog
::
updateSessionList
);
m_sessionList
->
setFocus
();
m_newButton
->
setEnabled
(
true
);
m_dontAskCheckBox
->
setEnabled
(
true
);
m_closeButton
->
setEnabled
(
true
);
m_filterBox
->
setEnabled
(
true
);
m_sessionList
->
setFocus
();
}
void
KateSessionManageDialog
::
editApply
()
...
...
@@ -435,7 +436,8 @@ bool KateSessionManageDialog::eventFilter(QObject *object, QEvent *event)
}
else
if
(
object
==
m_filterBox
)
{
// Catch Return key to avoid to finish the dialog
if
(
event
->
type
()
==
QEvent
::
KeyPress
&&
(
ke
->
key
()
==
Qt
::
Key_Return
||
ke
->
key
()
==
Qt
::
Key_Enter
))
{
updateSessionList
();
// avoid crash, see bug 142127
QTimer
::
singleShot
(
0
,
this
,
&
KateSessionManageDialog
::
updateSessionList
);
m_sessionList
->
setFocus
();
return
true
;
}
...
...
Dominik Kummer
@domson
·
Oct 03, 2021
i see. Awesome! thx!
i see. Awesome! thx!
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment