Commit 82562479 authored by Christoph Cullmann's avatar Christoph Cullmann 🐮
Browse files

fix crash for HUD of actions

ensure we fill the list we render properly
assert it is not empty, otherwise bad stuff happens
afterwards
parent f86366ee
...@@ -192,15 +192,15 @@ public: ...@@ -192,15 +192,15 @@ public:
* Step 2: [ "Ctrl", ",", "Alt", ":"] * Step 2: [ "Ctrl", ",", "Alt", ":"]
*/ */
const auto spaceSplitted = splitShortcutString(shortcutString); const auto spaceSplitted = splitShortcutString(shortcutString);
QStringList list; QStringList list;
list.reserve(spaceSplitted.size() * 2); list.reserve(spaceSplitted.size() * 2);
for (const QString &shortcut : spaceSplitted) { for (const QString &shortcut : spaceSplitted) {
QStringList list = shortcut.split(QLatin1Char('+'), SkipEmptyParts); list += shortcut.split(QLatin1Char('+'), SkipEmptyParts);
if (shortcut.endsWith(QLatin1String("+"))) { if (shortcut.endsWith(QLatin1String("+"))) {
list.append(QStringLiteral("+")); list.append(QStringLiteral("+"));
} }
} }
Q_ASSERT(!list.isEmpty());
/** /**
* Create rects for each string from the previous step * Create rects for each string from the previous step
...@@ -225,6 +225,7 @@ public: ...@@ -225,6 +225,7 @@ public:
r.setWidth(r.width() + 8); r.setWidth(r.width() + 8);
btns.append({r, text}); btns.append({r, text});
} }
Q_ASSERT(!btns.isEmpty());
// we have nothing, just return // we have nothing, just return
if (btns.isEmpty()) { if (btns.isEmpty()) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment