Fix tabbar auto hide + test

apps/lib/autotests/kate_view_mgmt_tests.cpp

@@ -396,3 +396,39 @@ void KateViewManagementTests::testWindowsClosesDocuments()
     delete second;
     QCOMPARE(app->documentManager()->documentList().size(), 1);
 }
+
+void KateViewManagementTests::testTabBarHidesShows()
+{
+    app->sessionManager()->sessionNew();
+    KateMainWindow *mw = app->activeKateMainWindow();
+    auto vm = mw->viewManager();
+    auto vs = vm->activeViewSpace();
+    vs->m_autoHideTabBar = true;
+    vs->tabBarToggled();
+
+    QVERIFY(!vs->m_tabBar->isVisible());
+
+    app->activeKateMainWindow()->viewManager()->slotDocumentNew();
+    QCOMPARE(vm->views().size(), 1);
+    QVERIFY(vs->m_tabBar->isHidden());
+
+    app->activeKateMainWindow()->viewManager()->slotDocumentNew();
+    QCOMPARE(vm->views().size(), 2);
+    qApp->processEvents();
+    QVERIFY(vs->m_tabBar->isVisible());
+
+    vm->slotDocumentClose();
+    QCOMPARE(vm->views().size(), 1);
+    qApp->processEvents();
+    QVERIFY(!vs->m_tabBar->isVisible());
+
+    Utils::addWidget(new QWidget, app->activeMainWindow());
+    qApp->processEvents();
+    QVERIFY(vs->m_tabBar->isVisible());
+
+    vm->slotDocumentClose();
+    qApp->processEvents();
+    QVERIFY(!vs->m_tabBar->isVisible());
+
+    // m_autoHideTabBar
+}

apps/lib/autotests/kate_view_mgmt_tests.h

@@ -37,6 +37,7 @@ private Q_SLOTS:
     void testActivateNotAddedWidget();
     void testBug460613();
     void testWindowsClosesDocuments();
+    void testTabBarHidesShows();
 
 private:
     class QTemporaryDir *m_tempdir;

apps/lib/kateviewspace.cpp

@@ -171,8 +171,9 @@ KateViewSpace::KateViewSpace(KateViewManager *viewManager, QWidget *parent, cons
     connect(KateApp::self(), &KateApp::configurationChanged, this, &KateViewSpace::readConfig);
 
     // ensure we show/hide tabbar if needed
-    connect(KateApp::self()->documentManager(), &KateDocManager::documentCreated, this, &KateViewSpace::documentCreatedOrDeleted);
-    connect(KateApp::self()->documentManager(), &KateDocManager::documentDeleted, this, &KateViewSpace::documentCreatedOrDeleted);
+    // Queued so tabbar etc handle it first
+    connect(KateApp::self()->documentManager(), &KateDocManager::documentCreated, this, &KateViewSpace::documentCreatedOrDeleted, Qt::QueuedConnection);
+    connect(KateApp::self()->documentManager(), &KateDocManager::documentDeleted, this, &KateViewSpace::documentCreatedOrDeleted, Qt::QueuedConnection);
 }
 
 KateViewSpace::~KateViewSpace() = default;
@@ -662,6 +663,8 @@ QWidget *KateViewSpace::takeView(DocOrWidget docOrWidget)
             Qt::QueuedConnection);
     }
 
+    documentCreatedOrDeleted(nullptr);
+
     return ret;
 }
 
@@ -766,6 +769,7 @@ void KateViewSpace::closeTabRequest(int idx)
             if (m_registeredDocuments.isEmpty() && m_tabBar->count() == 0) {
                 Q_EMIT viewSpaceEmptied(this);
             }
+            documentCreatedOrDeleted(nullptr);
         }
         return;
     }