urlbar: Don't rely on focus change

Fixes the crash with stale QModelIndex + other focus issues and
accidental urlbar opening.

kate/kateurlbar.cpp

@@ -359,22 +359,13 @@ public:
         m.exec(pos);
     }
 
-protected:
-    void focusInEvent(QFocusEvent *f) override
+    void openLastIndex()
     {
-        if (f->reason() == Qt::OtherFocusReason) {
-            const auto last = m_model.index(m_model.rowCount() - 1, 0);
-            if (last.isValid()) {
-                setCurrentIndex(last);
-                QMetaObject::invokeMethod(
-                    this,
-                    [this, last] {
-                        clicked(last);
-                    },
-                    Qt::QueuedConnection);
-            }
+        const auto last = m_model.index(m_model.rowCount() - 1, 0);
+        if (last.isValid()) {
+            setCurrentIndex(last);
+            clicked(last);
         }
-        QListView::focusInEvent(f);
     }
 
 private:
@@ -475,6 +466,13 @@ KateUrlBar::KateUrlBar(KateViewSpace *parent)
     setHidden(!vm->showUrlNavBar());
 }
 
+void KateUrlBar::open()
+{
+    if (m_breadCrumbView && m_stack->currentWidget() == m_breadCrumbView) {
+        m_breadCrumbView->openLastIndex();
+    }
+}
+
 void KateUrlBar::onViewChanged(KTextEditor::View *v)
 {
     if (!v) {

kate/kateurlbar.h

@@ -15,6 +15,7 @@ class KateUrlBar : public QWidget
     Q_OBJECT
 public:
     explicit KateUrlBar(KateViewSpace *parent = nullptr);
+    void open();
 
 Q_SIGNALS:
     void openUrlRequested(const QUrl &url, Qt::KeyboardModifiers);

kate/kateviewspace.cpp

@@ -745,7 +745,7 @@ void KateViewSpace::closeTabWithWidget(QWidget *widget)
 void KateViewSpace::focusNavigationBar()
 {
     if (!m_urlBar->isHidden()) {
-        m_urlBar->setFocus();
+        m_urlBar->open();
     }
 }