GitLab

Boris Petrov authored Jul 18, 2021 and Mark Nauwelaerts committed Jul 26, 2021

The current server, pyls, is no longer worked on. This commit replaces
it with an actively developed fork of the same server, pylsp.

Currently we are sending requests on every typed character and everytime
we change view. This can be really heavy on the server, especially with
large documents. It results in problems such as "incorrect highlighting"
because server isn't in sync with the latest changes in the document.

This change introduces a simple mechanism to fix this: Use a QTimer to
reduce the amount of requests. Every time we type or change the current
KTE::View this timer gets started/restarted and when it times out, it
just refreshes the highlighting.

This means no more highlight-as-you-type, which is both good and bad but
since we can't really control the servers, I think this is better.
Signed-off-by: Waqar Ahmed <waqar.17a@gmail.com>

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Christoph Cullmann authored Jul 17, 2021 and Alexander Lohnau committed Jul 19, 2021

if you e.g. have some session with already loaded projects,
these were active after you start kate from a terminal
or via kate /project/path

now we delay the project open of such fresh stuff until
the event loop starts after session restore

=> new projects are properly activated

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

378c65d5 broke the plugin size restore
when kate is closed with no active plugin views.
This is because the sidebar will (mistakenly) be thought
as collapsed, when in fact no plugins are activated.

avoid crash if point is out of range

BUG: 439804

This MR improves double click detection on the splitter handle. Sometimes QSplitterHandle doesn't receive MouseButtonDblClick event. We can detect that MouseButtonDblClick event should have been received if we receive two MouseButtonRelease events in a row.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Jan Paul Batrina authored Jul 12, 2021 and Christoph Cullmann committed Jul 13, 2021

bccc7d35 hides plugin views when their
sidebar is collapsed which made the sidebar unresizable.

This commit adds a placeholder (an empty QLabel) which is shown
when the sidebar is collapsed so that it will still be resizable.
The plugin views are properly shown again after the sidebar is
manually expanded using the mouse.

For highlight color, editor color is used now. This fixes the look with
light color scheme and dark editor theme.
Signed-off-by: Waqar Ahmed <waqar.17a@gmail.com>

Signed-off-by: Waqar Ahmed <waqar.17a@gmail.com>

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

See: https://bugs.kde.org/show_bug.cgi?id=268913
See: !422

General idea:

* anonymous session is
  * still without name (and not explicitly displayed)
  * is saved whenever the named session would be
  * is saved to "Last session" so it can be restored (if kate sessions are configured to restore the last one on start)
* its possible to store the configuration (plugins loaded, etc...) as session default
* the new session is created from defaults and stored as anonymous

Since the sidebar is collapsed, the plugin view is not
visible to the user, so it makes sense to show the
tool view (by expanding the sidebar) instead.

When their sidebar is collapsed, plugin views are still
technically visible (e.g. isVisible() returns true), but
visually they are hidden. This leads to a visual mismatch
of state (e.g. toggling the plugin view will disable it
instead of showing).

This commit makes it so that active plugin views are hidden
when their sidebar is collapsed, and then they are restored
when their sidebar is expanded again.

This ensures that the tool view can be restored
not just through moving the splitter via mouse,
but also by showing/hiding tool views.

This enables a user to temporarily hide
multiple (persistent) tool views on one sidebar
without having to hide each individual toolview.

BUG: 439535

This reverts commit fba7677a.

Christoph Cullmann authored Jul 07, 2021 and Jan Paul Batrina committed Jul 11, 2021

if people want to hide the toolview,
there is the button or shortcut

this avoids that collapsing via dragging leads
to confusion

BUG: 439535

as discussed in

!450

Splitter of views space should react on mouse double click by
resizing the viewspace to 50/50 split.

Bug: 438983

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Reason: Almost all editors and even many programs (konsole) do this in
KDE and other operating systems.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

(cherry picked from commit b1e3e8ce)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"