1. 28 Feb, 2020 1 commit
    • Christoph Cullmann's avatar
      Session manager: empty session list · 8ee53e3a
      Christoph Cullmann authored
      Summary: When opening the session manager, the session list is empty although the menu "sessions" >"quick open session" shows the complete list.
      
      Test Plan:
      The "Behaviour on Application Startup" is "Start new session".
      
      Open the session manager through the menu or a shortcut, all the sessions available in "quick open session" are also available.
      
      Reviewers: #kate, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: cullmann, kwrite-devel, #kate
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D27719
      8ee53e3a
  2. 11 Feb, 2020 2 commits
    • Christoph Cullmann's avatar
      remove use of obsolete function · 54b3fd74
      Christoph Cullmann authored
      54b3fd74
    • Raphael Rosch's avatar
      Add sortable columns to session manager dialog, and remove previous sorting code · 4b0260eb
      Raphael Rosch authored
      Summary:
      I really like the new session manager dialog (session chooser) but when I went to click on the column headers to sort, it didn't work. So I wondered how hard it would be to implement and just went for it.
      
      I know the diff is supposed to be done with arc, but I don't yet have that all set up, and I wanted to get you the patch over as soon as possible. I hope that's ok.
      
      One thing that does not work properly is the sorting by number of open files, since that requires numeric sort which was beyond my current abilities, maybe someone else can take that up for the next round, once this simple patch is in.
      
      I also corrected a couple spelling mistakes, which accounts for the extra lines.
      
      Test Plan:
      Apply patch (should apply cleanly to most recent master).
      Compile.
      Run kate.
      
      Reviewers: #kate, dhaumann, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D27180
      4b0260eb
  3. 28 Oct, 2019 1 commit
  4. 20 Oct, 2019 1 commit
  5. 16 Sep, 2019 1 commit
  6. 23 Aug, 2019 1 commit
  7. 13 Jul, 2019 1 commit
  8. 09 Dec, 2018 1 commit
  9. 08 Dec, 2018 1 commit
    • Christoph Cullmann's avatar
      Review user interaction in session management · e078ee32
      Christoph Cullmann authored
      Summary:
      * SessionManageDialog
          - Build user interface by ui file
          - Avoid obsolete Qt members
          - Choose more meaningful member names
          - Add filter field and sort button
          - Open session by double click
          - Add buttons for "Copy" and "Open as Template"
          - Reorder a couple of code to be a little bit more logic ordered
          - Delete a session with delay which offer a restore and avoid annoying
            confirmation dialog
          - Rename a session inside of the list view to avoid extra popup
            window to enter the new name.
      
      * Remove SessionOpenDialog, use SessionManageDialog instead
      * Remove SessionChooser, use SessionManageDialog instead
      
      * SessionManager
          - Add signal sessionListChanged()
            To avoid unneded signals is updateSessionList() slightly modified
            with a clearer look and an added check for changes in an easy way.
          - Add copySession()
          - Let rename/copySession() ask for a new name when needed
          - Move session creation parts from newSessionName() to sessionSaveAs()
          - Rename newSessionName() to askForNewSessionName()
          - Add suggestNewSessionName()
          - Don't create anonymous session in ctor
          - Don't save anonymous session as last session
      
      * MainWindow
          - Remove from sessions menu "Open Session" because it's now the
            same as "Manage Sessions"
      
      Test Plan:
      {F6443763}
      {F6443766}
      
      Reviewers: #kate, dhaumann, ngraham, #vdg, cullmann
      
      Reviewed By: #kate, dhaumann, cullmann
      
      Subscribers: fabianr, anthonyfieroni, cullmann, kwrite-devel, #kate
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D16926
      e078ee32
  10. 15 Sep, 2017 1 commit
  11. 14 Oct, 2015 1 commit
  12. 23 Jan, 2014 3 commits
  13. 21 Jan, 2014 1 commit
  14. 20 Jan, 2014 2 commits
  15. 09 Jan, 2014 1 commit
  16. 04 Jan, 2014 3 commits
    • Michal Humpula's avatar
      add -DQT_NO_CAST_FROM_ASCII flags (2/?) · bf2185e5
      Michal Humpula authored
      bf2185e5
    • Michal Humpula's avatar
      changes headers of katesession to LGPLv2+ · b155f3e7
      Michal Humpula authored
      b155f3e7
    • Michal Humpula's avatar
      break down the katession.h/.cpp files · 96164b94
      Michal Humpula authored
      Changes:
      
      One class per file. Code is now testable (almost) independently from
      the app, so adding bunch of unit tests.
      
      KateSession
       * simple container
       * remove read/writeConfig() in favour of config()
       * move rename method to manager
       * decouple name from filename (manager does the coupling now)
       * hide constructor in favour of factories returning KateSession::Ptr
       * not dependent on KateSessionManager anymore
       * add sorting functions
       * add timestamp (last time the session was saved)
      
      KateSessionManager
       * add activeSession(QString, bool, bool, bool)
       * add activeAnonymousSession()
       * change internal storage from QList to QHash (faster lookups)
       * remove sorting from sessionList() to callers
       * use KDirWatch to monitor session dir (this removes the constant
         updates of m_sessions)
      
      KateSessionsAction
       * add possibility to depency-inject the KateSessionManager
       * sort by modification time (desc)
       * limit to ten items
       * disable action, when there are no sessions
      
      KateSessionChooser
       * guarantee that selectedSession() will be valid, when result is resultOpen or
         resultCopy. This simplifies the KateSessionManager workflow.
      
      BUG: 139009
      BUG: 319397
      FIXED-IN: 5.0
      96164b94