In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The new conntect() syntax along with a lambda is not automatically
destroyed when the plugin is unloaded, since the connection does not
track the "this" pointer that is captured in the lambda function,
a typicall programming error :-/

This change turns the connection into a proper member function, so
the connection is cleaned up when the plugin view is deleted.

FIXED-IN: 19.12.1

(cherry picked from commit c8e04248)

based on feedback by u/emilsedgh on reddit


(cherry picked from commit 9f80b100)

Pino Toscano authored Dec 29, 2019 and Christoph Cullmann committed Jan 02, 2020

The LSP server moved in its own project, and its executable was
recently renamed.


(cherry picked from commit eb0f19df)

this allows to add new servers without needing to adapt the highlighting
to mode mapping manually in the plugin sources

KDevelop makes use of those icons e.g. in the settings.
The icons are chosen to match the icons of the toolview titles.

Yuri Chornoivan authored Dec 03, 2019 and Pino Toscano committed Dec 03, 2019

(cherry picked from commit 71905f74)

BUG: 181528

CCBUG: 181528

David Redondo authored Nov 24, 2019 and Christoph Cullmann committed Nov 24, 2019

The user visible name and the name of a colorscheme as configured in kdeglobals
can differ. For example "Breeze Light" and "BreezeLight". This causes no color
scheme to be checked when such a scheme is the default scheme and no color
scheme has been selected in Kate.

Thanks to Antonio Rojas for pointing this out.

Summary: They were set but never used.

Test Plan: Builds

Reviewers: #kate, cullmann

Subscribers: kwrite-devel

Tags: #kate

Differential Revision: https://phabricator.kde.org/D25412

Summary:
KF5I18n is required anyway. If it isn't searched and found when the
ki18n_install call, which is injected by the release scripts, is
encountered the build will fail with "CMake Error: No script
specified for argument -P" because a variable usually set by
ki18n_install is not defined.
The same applies to KF5DocTools and kdoctools_install as well, but
it is guarded by a "if (KF5DocTools_FOUND)" so it doesn't error out
but just doesn't install any handbooks, even if KF5DocTools is found.

Test Plan: The 19.11.80 tarball builds fine with the patch applied

Reviewers: #kate, cullmann

Subscribers: kwrite-devel

Tags: #kate

Differential Revision: https://phabricator.kde.org/D25411

Summary:
Otherwise Qt5Widgets_VERSION just doesn't exist at the time the if
is encountered.

Test Plan: Confirmed that camke enters the if branch

Reviewers: #kate, cullmann

Subscribers: kwrite-devel

Tags: #kate

Differential Revision: https://phabricator.kde.org/D25410

(cherry picked from commit 8b9f75ef)

Useful when looking at files with whitespace-free compact formatting.

GIT_SILENT

Summary: (this is in order to make KWindowSystem independent from QtWidgets)

Test Plan: Builds

Reviewers: cullmann, dhaumann

Subscribers: kwrite-devel

Tags: #kate

Differential Revision: https://phabricator.kde.org/D25232

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 413306

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"