1. 05 Jun, 2018 1 commit
  2. 31 May, 2018 1 commit
    • Nate Graham's avatar
      Re-allow running Kate and KWrite as the actual root user (but still not using sudo) · bf6d5b75
      Nate Graham authored
      Summary:
      The original change (9adcebd3) to prevent sudo usage broke the use case of running KWrite or Kate while logged in as the actual `root` user with a GUI session. This is how the Kali distro is set up by default, so the original change amounted to making Kate and KWrite not launch at all on this KDE distro.
      
      This patch re-enables running as the actual root user, but keeps blocking usage via `sudo` or `kdesu`. There are no negative security implications associated with re-allowing usage via the root user, since if you're running a GUI session, you were already exposed to the original security threat and Kate and KWrite do not increase the attack surface.
      
      I have submitted a similar change for Dolphin that has been accepted (D12795), but @elvisangelaccio wants that to go in at the same time as this, to keep them in sync.
      
      BUG: 387973
      FIXED-IN: 18.08.0
      
      Test Plan:
      - Log in as normal user and run `sudo kate` or `sudo kwrite`: you get an error message.
      - Log in as normal user and run `kdesu kate` or `kdesu kwrite`: you get an error message.
      - Log in as the root user and run Kate or KWrite normally: it works.
      
      Reviewers: #kate, dhaumann, cullmann, #ktexteditor
      
      Reviewed By: #kate, dhaumann, #ktexteditor
      
      Subscribers: kwrite-devel, elvisangelaccio
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D13138
      bf6d5b75
  3. 27 May, 2018 1 commit
  4. 26 May, 2018 1 commit
    • Thomas Surrel's avatar
      Fix CTags dialog error message when adding target · 1418739a
      Thomas Surrel authored
      Summary:
      When trying to add a new index target in the CTags addon (from the view, not from the settings), the dialog message to select the folder is set to point to the current _file_ instead of the current file _directory_. The dialog than complains about it not being a directory.
      
      BUG: 394402
      
      Reviewers: #kate, sars
      
      Reviewed By: #kate, sars
      
      Subscribers: sars, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D13115
      1418739a
  5. 25 May, 2018 2 commits
  6. 24 May, 2018 3 commits
  7. 23 May, 2018 1 commit
  8. 21 May, 2018 2 commits
  9. 12 May, 2018 1 commit
  10. 11 May, 2018 1 commit
  11. 10 May, 2018 1 commit
  12. 01 May, 2018 2 commits
  13. 30 Apr, 2018 1 commit
  14. 27 Apr, 2018 1 commit
  15. 23 Apr, 2018 1 commit
  16. 18 Apr, 2018 2 commits
  17. 17 Apr, 2018 1 commit
  18. 15 Apr, 2018 1 commit
    • Nate Graham's avatar
      Use Tree View as the default view mode in the Filesystem Browser plugin · c87e4cb1
      Nate Graham authored
      Summary:
      Previously, Kate's Filesystem Browser plugin was replying on a bug in KDirOperator that was just fixed: the fact that columns perviously did not auto-size correctly and did not stick to the right edge when the view was resized. This was fixed in D11993.
      
      Now that this bug is fixed, the plugin needs to default to a more sensible view mode--one that does not have additional columns. This patch does that.
      
      Test Plan:
      {nav Create and log into a new user account > open Kate > Settings > Configure Kate > Plugins > turn on "Filesystem Browser" plugin > hit Apply > click "Filesystem Browser" on the sidebar}
      
      Before:
      {F5808728}
      
      After:
      {F5808725}
      
      Reviewers: #kate, dhaumann
      
      Reviewed By: #kate, dhaumann
      
      Subscribers: dhaumann, sharvey
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D12224
      c87e4cb1
  19. 08 Apr, 2018 2 commits
  20. 03 Apr, 2018 2 commits
  21. 02 Apr, 2018 2 commits
    • Алексей Шилин's avatar
      c3ca6641
    • Алексей Шилин's avatar
      Don't restart the blocking process on session restore · 0a73e00e
      Алексей Шилин authored
      Summary:
      All blocking Kate processes were restarted on session restore which
      led to launching (possibly) multiple redundant instances.
      
      This change asks the session manager to not restart such processes.
      
      Note: QObject::connect() is used here because the session manager
      can't be accessed directly according to the documentation [1]:
      
          In Qt, session management requests for action are handled by
          the two signals QGuiApplication::commitDataRequest() and
          QGuiApplication::saveStateRequest(). Both provide a reference
          to a QSessionManager object as argument. The session manager
          can only be accessed in slots invoked by these signals.
      
       [1] http://doc.qt.io/qt-5/qsessionmanager.html#details
      
      BUG: 360066
      FIXED-IN: 18.04
      
      Test Plan:
        0. Make sure that Plasma is configured to restore previous session
           on startup.
        1. Open Dolphin and create 'test1' and 'test2' text files.
        2. Open 'test1' in Kate from Dolphin.
        3. Open 'test2' in the already running Kate instance from Dolphin.
        4. Log out and back in. Check that there are no redundant Kate
           instances running.
      
      Reviewers: #kate, dhaumann
      
      Reviewed By: #kate, dhaumann
      
      Subscribers: ngraham, dhaumann
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D11818
      0a73e00e
  22. 31 Mar, 2018 5 commits
  23. 26 Mar, 2018 1 commit
  24. 19 Mar, 2018 2 commits
  25. 18 Mar, 2018 1 commit
  26. 13 Mar, 2018 1 commit