Waqar Ahmed authored Jul 21, 2022 and Christoph Cullmann committed Jul 21, 2022

Proxy models dont emit rowsMoved

Eric Armbruster authored Jul 09, 2022 and Christoph Cullmann committed Jul 09, 2022

As is done in kio

Eric Armbruster authored Jul 08, 2022 and Christoph Cullmann committed Jul 09, 2022

This is to be consistent with other Dolphin.

Yes/No buttons in dialogs are discouraged (not only) by KDE HIG in favour
of actions terms.

Ahmad Samir authored Jun 25, 2022 and Christoph Cullmann committed Jun 26, 2022

Which will close all the docs under it.

Ahmad Samir authored Jun 25, 2022 and Christoph Cullmann committed Jun 26, 2022

Instead capture the sender with a lambda.

Ahmad Samir authored Jun 25, 2022 and Christoph Cullmann committed Jun 26, 2022

- Store pointers to the proxy and source models, less casting
- Add some convenience methods, less code duplication
- Remove QVariant::isValid() checks, QVariant::value() will return a
  default contructed/empty QList if the conversion/cast fails anyway
- Initialize a member

Ahmad Samir authored Jun 25, 2022 and Christoph Cullmann committed Jun 26, 2022

Also use PMF signal/slot syntax.

Waqar Ahmed authored Jan 14, 2022 and Christoph Cullmann committed Jan 16, 2022

Don't remove + insert, we loose state that way. Instead move rows and
then recursively expand parents if needed.

BUG: 410143

Waqar Ahmed authored Mar 11, 2021 and Christoph Cullmann committed Mar 12, 2021

Signed-off-by: Waqar Ahmed <waqar.17a@gmail.com>

If you want git blame to ignore formatting revisions run:
git config blame.ignoreRevsFile .git-blame-ignore-revs

Let JobUiDelegate handle the error messages.

Keep the code building with older KF versions.

It is about to be deprecated

See https://phabricator.kde.org/T12177

Only reinterpret cast was needed for:
`reinterpret_cast<qptrdiff>(doc)`

With this patch, Kate compiles even if deprecated Qt functions
are disabled.

Summary: It (should) simplify code a bit. It some cases prevents copying strings, shared_ptrs.

Reviewers: #kate, cullmann

Reviewed By: #kate, cullmann

Subscribers: cullmann, kwrite-devel, #kate

Tags: #kate

Differential Revision: https://phabricator.kde.org/D23010

Kai Uwe Broulik authored Feb 24, 2019 and Christoph Cullmann committed Feb 24, 2019

Summary: It was present in the Projects view but not the Documents tree.

Test Plan: {F6627981}

Reviewers: #kate, #vdg, dhaumann

Reviewed By: #kate, #vdg, dhaumann

Subscribers: dhaumann, abetts, ngraham, kwrite-devel

Tags: #kate

Differential Revision: https://phabricator.kde.org/D19197

Add file related actions to Tabbar context menu and File menu: Rename, Delete, Compare (new), and some more

Summary:
Add some actions to Tabbar context menu and File menu

New items in Tabbar context menu:
- 'Rename file'
- 'Delete file'
- 'Properties'
- 'Compare'

'Compare' does the following: compare two files with an external diff tool. It works like this: right click on a tab which is NOT active and select the appropriate menu item (see screenshot). Then, the external tool opens and compares the active document with the one which was clicked on. Currently, three diff tools are supported: kdiff3, kompare and meld.

New items in File main menu:
- 'Rename file'
- 'Delete file'
- 'Compare'
- 'Copy File Path'
- 'Open Containing Folder'
- 'Properties'

Screenshots:

Tab context menu:

{F6414794}

Tab context menu when no file is associated:

{F6414793}

Tab context menu with the compare feature:

{F6431032}

Diff tools not found:

{F6450993}

Actions are also available in the main File menu:

{F6450928}

NOTE: Some code of kfileactions.cpp was copied and adapted from katefiletree.cpp. TODO: reuse code there. Probably, this means kfileactions.h must be moved to KTextEditor.

TODO: in a later change the 'Open with...' menu item which is currently available in the Projects and FileTree plugin could also be extracted and be added to the Tabbar context menu and File menu (Gwenview has it, too).

Reviewers: #kate, #vdg, ngraham, cullmann

Reviewed By: #kate, #vdg, ngraham, cullmann

Subscribers: cullmann, anthonyfieroni, dhaumann, mmustac, ngraham, kwrite-devel

Tags: #kate

Differential Revision: https://phabricator.kde.org/D16830

Summary:
In the context menus of the Document Tree View plugin, the Project plugin,
and the Tabbar, use the term Use 'Copy File Path' consistently.

Reviewers: #kate, cullmann

Reviewed By: #kate, cullmann

Subscribers: kfunk, cullmann, ngraham, kwrite-devel

Tags: #kate

Differential Revision: https://phabricator.kde.org/D16819

be consistent with the project tree view

1) single click activates document, like in project tree
2) non-document tree parts collapse/expand like normal

BUG: 395082

Summary:
Update most of the connections of all files inside addons
folder to qt5 pattern.

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Reviewers: cullmann kfunk

Tags: #kate

Differential Revision: https://phabricator.kde.org/D7851