1. 22 Nov, 2019 1 commit
  2. 19 Nov, 2019 1 commit
  3. 16 Aug, 2019 5 commits
    • Daan De Meyer's avatar
    • Daan De Meyer's avatar
      Clean up main CMake scripts. · a167b312
      Daan De Meyer authored
      - Use target based commands instead of source variables and directory
      based commands.
      - Move `find_package` calls from top level CMake script into kate and
      kwrite subdirectories. This is consistent with the addons where each
      target finds its own required dependencies.
      - Syntax cleanup: Two spaces indentation and, spaces after command
      names and split long commands over multiple lines.
      - Append to `CMAKE_MODULE_PATH` instead of overriding it so that it can
      be overriden manually from the command line by developers if needed.
      - Remove obvious comments.
      - Remove nested `project` calls as they are unnecessary.
      - Rename `kdeinit_kate` to `kate` and `kate` to `kate-bin`.
      - Remove `qt5_add_resources` usage and pass resource files directly to
      `target_sources` instead (thanks to `CMAKE_AUTORC`).
      - Remove unnecessary and transitive dependencies.
      - Exclusively use variables for MacOS bundle strings.
      a167b312
    • Daan De Meyer's avatar
      Refactor config.h handling. · 458e7832
      Daan De Meyer authored
      - Use separate config.h files for kate and kwrite.
      - Add `KWRITE_VERSION` for use in kwrite source code.
      - Use the more widely used .in suffix for config.h templates instead of
      the .cmake suffix which is primarily used by CMake script files.
      - Rename `KActivities_FOUND` define to `KF5Activities_FOUND` so that
      cmakedefine in config.h.in automatically picks it up when
      `KF5Activities_FOUND` is set during CMake's configure stage.
      - Remove config.h include from source files that don't need it.
      458e7832
    • Daan De Meyer's avatar
      f99afa4e
    • Daan De Meyer's avatar
      Add source file for katewaiter.h. · 10fff7e1
      Daan De Meyer authored
      10fff7e1
  4. 08 Dec, 2018 1 commit
    • Christoph Cullmann's avatar
      Review user interaction in session management · e078ee32
      Christoph Cullmann authored
      Summary:
      * SessionManageDialog
          - Build user interface by ui file
          - Avoid obsolete Qt members
          - Choose more meaningful member names
          - Add filter field and sort button
          - Open session by double click
          - Add buttons for "Copy" and "Open as Template"
          - Reorder a couple of code to be a little bit more logic ordered
          - Delete a session with delay which offer a restore and avoid annoying
            confirmation dialog
          - Rename a session inside of the list view to avoid extra popup
            window to enter the new name.
      
      * Remove SessionOpenDialog, use SessionManageDialog instead
      * Remove SessionChooser, use SessionManageDialog instead
      
      * SessionManager
          - Add signal sessionListChanged()
            To avoid unneded signals is updateSessionList() slightly modified
            with a clearer look and an added check for changes in an easy way.
          - Add copySession()
          - Let rename/copySession() ask for a new name when needed
          - Move session creation parts from newSessionName() to sessionSaveAs()
          - Rename newSessionName() to askForNewSessionName()
          - Add suggestNewSessionName()
          - Don't create anonymous session in ctor
          - Don't save anonymous session as last session
      
      * MainWindow
          - Remove from sessions menu "Open Session" because it's now the
            same as "Manage Sessions"
      
      Test Plan:
      {F6443763}
      {F6443766}
      
      Reviewers: #kate, dhaumann, ngraham, #vdg, cullmann
      
      Reviewed By: #kate, dhaumann, cullmann
      
      Subscribers: fabianr, anthonyfieroni, cullmann, kwrite-devel, #kate
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D16926
      e078ee32
  5. 03 Dec, 2018 1 commit
    • Gregor Mi's avatar
      Add file related actions to Tabbar context menu and File menu: Rename, Delete,... · e8496c60
      Gregor Mi authored
      Add file related actions to Tabbar context menu and File menu: Rename, Delete, Compare (new), and some more
      
      Summary:
      Add some actions to Tabbar context menu and File menu
      
      New items in Tabbar context menu:
      - 'Rename file'
      - 'Delete file'
      - 'Properties'
      - 'Compare'
      
      'Compare' does the following: compare two files with an external diff tool. It works like this: right click on a tab which is NOT active and select the appropriate menu item (see screenshot). Then, the external tool opens and compares the active document with the one which was clicked on. Currently, three diff tools are supported: kdiff3, kompare and meld.
      
      New items in File main menu:
      - 'Rename file'
      - 'Delete file'
      - 'Compare'
      - 'Copy File Path'
      - 'Open Containing Folder'
      - 'Properties'
      
      Screenshots:
      
      Tab context menu:
      
      {F6414794}
      
      Tab context menu when no file is associated:
      
      {F6414793}
      
      Tab context menu with the compare feature:
      
      {F6431032}
      
      Diff tools not found:
      
      {F6450993}
      
      Actions are also available in the main File menu:
      
      {F6450928}
      
      NOTE: Some code of kfileactions.cpp was copied and adapted from katefiletree.cpp. TODO: reuse code there. Probably, this means kfileactions.h must be moved to KTextEditor.
      
      TODO: in a later change the 'Open with...' menu item which is currently available in the Projects and FileTree plugin could also be extracted and be added to the Tabbar context menu and File menu (Gwenview has it, too).
      
      Reviewers: #kate, #vdg, ngraham, cullmann
      
      Reviewed By: #kate, #vdg, ngraham, cullmann
      
      Subscribers: cullmann, anthonyfieroni, dhaumann, mmustac, ngraham, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D16830
      e8496c60
  6. 17 Oct, 2018 1 commit
    • Tomaz  Canabrava's avatar
      Fix Duplicates on Quick Open File · d6e38c0c
      Tomaz Canabrava authored
      Summary:
      The logic on the quick open was overcomplex, and it led to
      bugs while filling the document list.
      The new logic fills a vector with all the files,
      organizes them by Url, remove the files based on the
      duplicated url's (so name matching doesn't matter) and only
      then starts to populate the view.
      
      I belive this is also faster than the old code as I minimized
      the amount of memory allocations and deallocations.
      
      I'm unsure about the use of QFileInfo in the end of the code as
      we can have too many files there and creating a temporary
      QFileInfo just to get the name is a huge overhead, we can do a split('/').last()
      for the file name. I'll do some measurements with that.
      
      Reviewers: cullmann, brauch, neundorf
      
      Reviewed By: cullmann
      
      Subscribers: gregormi, dhaumann, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D15804
      d6e38c0c
  7. 01 Aug, 2018 1 commit
    • Heiko Becker's avatar
      Honor BUILD_TESTING · 7a6e7342
      Heiko Becker authored
      Summary:
      Although ecm_optional_add_subdirectory(autotests) allows to skip
      building the autotests with -DBUILD_autotests=FALSE, it doesn't seem
      reasonable to have two options controlling similar behaviour and
      BUILD_TESTING is the de-facto standard for cmake and already used
      when discovering Qt5::Test.
      
      Furthermore it avoids a cmake warning when BUILD_TESTING is set to
      FALSE because Qt5::Test is passed to target_link_libraries but
      isn't a valid target.
      
      Test Plan: Warning disappears and builds successfully
      
      Reviewers: #kate
      
      Subscribers: kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D14538
      7a6e7342
  8. 14 Jul, 2018 1 commit
  9. 18 Jun, 2016 1 commit
  10. 17 Jun, 2016 1 commit
  11. 26 May, 2016 1 commit
  12. 23 Oct, 2015 1 commit
  13. 21 Oct, 2015 1 commit
  14. 14 Oct, 2015 5 commits
  15. 30 Aug, 2015 1 commit
  16. 26 Apr, 2014 1 commit
  17. 23 Jan, 2014 3 commits
  18. 21 Jan, 2014 2 commits
  19. 20 Jan, 2014 3 commits
  20. 05 Jan, 2014 2 commits
  21. 01 Jan, 2014 2 commits
  22. 27 Dec, 2013 1 commit
  23. 21 Dec, 2013 1 commit
  24. 08 Dec, 2013 2 commits